From: "Gustavo A. R. Silva" <gustavo@embeddedor.com>
To: Quentin Schulz <quentin.schulz@bootlin.com>
Cc: Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Kishon Vijay Abraham I <kishon@ti.com>,
"David S. Miller" <davem@davemloft.net>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 0/2] phy: ocelot-serdes: fix out-of-bounds bug
Date: Tue, 9 Oct 2018 16:13:13 +0200 [thread overview]
Message-ID: <bbaed401-0ea1-f5bb-43b9-0e38bcdbdfa5@embeddedor.com> (raw)
In-Reply-To: <20181009072853.t4jjqdlvc4g735hm@qschulz>
On 10/9/18 9:28 AM, Quentin Schulz wrote:
> Hi Gustavo,
>
> On Tue, Oct 09, 2018 at 12:20:28AM +0200, Gustavo A. R. Silva wrote:
>> This patchset aims to fix an out-of-bounds bug in
>> the phy-ocelot-serdes driver.
>>
>> Currently, there is an out-of-bounds read on array ctrl->phys,
>> once variable i reaches the maximum array size of SERDES_MAX
>> in the for loop.
>>
>> Quentin Schulz pointed out that SERDES_MAX is a valid value to
>> index ctrl->phys. So, I updated SERDES_MAX to be SERDES6G_MAX + 1
>> in include/dt-bindings/phy/phy-ocelot-serdes.h.
>>
>> Then I changed the condition in the for loop from
>> i <= SERDES_MAX to i < SERDES_MAX in order to
>> complete the fix.
>>
>> The reason I'm sending this fix as series is because
>> checkpatch reported an error when I first tried to
>> integrate the whole solution into a singe patch. So,
>> changes to dt-bindings should be sent as a separate
>> patch.
>>
>
> Much appreciated, thank you!
>
Glad to help. :)
Thanks
--
Gustavo
prev parent reply other threads:[~2018-10-09 14:14 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-08 22:20 Gustavo A. R. Silva
2018-10-08 22:21 ` [PATCH 1/2] dt-bindings: phy: Update SERDES_MAX to be SERDES_MAX + 1 Gustavo A. R. Silva
2018-10-09 7:27 ` Quentin Schulz
2018-10-16 8:44 ` Gustavo A. R. Silva
2018-10-17 15:09 ` Rob Herring
2018-10-17 15:19 ` Gustavo A. R. Silva
2018-10-17 15:23 ` Rob Herring
2018-10-17 15:45 ` Gustavo A. R. Silva
2018-10-08 22:22 ` [PATCH 2/2] phy: ocelot-serdes: fix out-of-bounds read Gustavo A. R. Silva
2018-10-09 7:28 ` Quentin Schulz
2018-10-16 8:46 ` Gustavo A. R. Silva
2018-10-16 8:48 ` Kishon Vijay Abraham I
2018-10-17 15:37 ` Gustavo A. R. Silva
2018-11-12 8:27 ` Kishon Vijay Abraham I
2018-10-09 7:28 ` [PATCH 0/2] phy: ocelot-serdes: fix out-of-bounds bug Quentin Schulz
2018-10-09 14:13 ` Gustavo A. R. Silva [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bbaed401-0ea1-f5bb-43b9-0e38bcdbdfa5@embeddedor.com \
--to=gustavo@embeddedor.com \
--cc=davem@davemloft.net \
--cc=kishon@ti.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=quentin.schulz@bootlin.com \
--cc=robh+dt@kernel.org \
--subject='Re: [PATCH 0/2] phy: ocelot-serdes: fix out-of-bounds bug' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).