From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CB247C11D00 for ; Thu, 20 Feb 2020 22:17:54 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 7E12620801 for ; Thu, 20 Feb 2020 22:17:54 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="swphFoMY" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729158AbgBTWRx (ORCPT ); Thu, 20 Feb 2020 17:17:53 -0500 Received: from mail-ot1-f67.google.com ([209.85.210.67]:34309 "EHLO mail-ot1-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727656AbgBTWRx (ORCPT ); Thu, 20 Feb 2020 17:17:53 -0500 Received: by mail-ot1-f67.google.com with SMTP id j16so245579otl.1; Thu, 20 Feb 2020 14:17:51 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:autocrypt:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=yTy/vQqrL06eFwjAezXHG8dLAd5pWpP0AFPfvMFyoYg=; b=swphFoMYNBEUiDnLDMNYMZh4dlPHt9J54/tfhokUm3SoGFNGJHedQLRIQyi4ljzSaO fZB8aK8RKdAabjHYY4+4I5BVyACk+4v3mala9+47WDk7GDwFspfARe1X30Z+S/fWC0bC aAd5aF1F7E1cVqb6oT32tJzBDbUwDD3RQFDv3WgkdMmleTW6pAoWDtmDCVMq3jwsYCtT XO7FOhk+1uUBtDMOEFvvNIC9ePA6Xvgcb0DHqr7e23O+xjejkVWOzlMUIHpOYFqOg66a /KZ71hnNJj/M7qRu08WcQAopk7xlC5OllAZ2nsiQiHTvvx/3KLn1tzc2iGkdNfDlPPa6 kKXw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:autocrypt :message-id:date:user-agent:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=yTy/vQqrL06eFwjAezXHG8dLAd5pWpP0AFPfvMFyoYg=; b=gkRooFMrmQt9tueXjLB8kcSnfBx9rFReDz5S1B/BuUuZb+d/L0RE8iV1hkJBShym9k LLv6YPtaRuBt9jp//vP8wC3E5IP+up9uYTw40/Ca3kV4biUzWbJsvhdNHIRgtxjF8hqt Yiqwy4bsT933MhyOqbZYeE5WKEl48/oWx0WzAN+IngD+gryZEoR/6dZxuSyq/0xLWNnh gjBfd0vL+/+4JxxvHPUXyPEZF1jeqjwuUx2o9YgKBj+1EfgHyi2tHDfpHSPd3FpdUB0C 1+oZ2wfkBrti6MCqJ6Cxq8HbUGiWl17ag5EyxWqUSsPLj+LOJ+bBuOFnVBEirG3LAIgo qHcw== X-Gm-Message-State: APjAAAV338qINI4XTC4M1OiQc4oqqtcFxRO75vCcbpcJP5oZimzgFTtj hWQP3RK7CXuVAmikkllZJUY= X-Google-Smtp-Source: APXvYqxePzBp2/a06Ne4T58403jibHLf5zYT1E2LZCo8mlCM0RLg4NiSzKSwei+fJjpurVPn4t4e0g== X-Received: by 2002:a9d:6e8f:: with SMTP id a15mr24762621otr.178.1582237071272; Thu, 20 Feb 2020 14:17:51 -0800 (PST) Received: from ziggy.stardust ([213.195.113.243]) by smtp.gmail.com with ESMTPSA id k201sm217082oih.43.2020.02.20.14.17.48 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 20 Feb 2020 14:17:50 -0800 (PST) Subject: Re: [PATCH v7 3/5] arm64: dts: mt8173: fix unit name warnings To: Hsin-Yi Wang , linux-arm-kernel@lists.infradead.org Cc: Rob Herring , Mark Rutland , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mediatek@lists.infradead.org, Nicolas Boichat , Enric Balletbo i Serra , Daniel Kurtz References: <20200210063523.133333-1-hsinyi@chromium.org> <20200210063523.133333-4-hsinyi@chromium.org> From: Matthias Brugger Autocrypt: addr=matthias.bgg@gmail.com; prefer-encrypt=mutual; keydata= mQINBFP1zgUBEAC21D6hk7//0kOmsUrE3eZ55kjc9DmFPKIz6l4NggqwQjBNRHIMh04BbCMY fL3eT7ZsYV5nur7zctmJ+vbszoOASXUpfq8M+S5hU2w7sBaVk5rpH9yW8CUWz2+ZpQXPJcFa OhLZuSKB1F5JcvLbETRjNzNU7B3TdS2+zkgQQdEyt7Ij2HXGLJ2w+yG2GuR9/iyCJRf10Okq gTh//XESJZ8S6KlOWbLXRE+yfkKDXQx2Jr1XuVvM3zPqH5FMg8reRVFsQ+vI0b+OlyekT/Xe 0Hwvqkev95GG6x7yseJwI+2ydDH6M5O7fPKFW5mzAdDE2g/K9B4e2tYK6/rA7Fq4cqiAw1+u EgO44+eFgv082xtBez5WNkGn18vtw0LW3ESmKh19u6kEGoi0WZwslCNaGFrS4M7OH+aOJeqK fx5dIv2CEbxc6xnHY7dwkcHikTA4QdbdFeUSuj4YhIZ+0QlDVtS1QEXyvZbZky7ur9rHkZvP ZqlUsLJ2nOqsmahMTIQ8Mgx9SLEShWqD4kOF4zNfPJsgEMB49KbS2o9jxbGB+JKupjNddfxZ HlH1KF8QwCMZEYaTNogrVazuEJzx6JdRpR3sFda/0x5qjTadwIW6Cl9tkqe2h391dOGX1eOA 1ntn9O/39KqSrWNGvm+1raHK+Ev1yPtn0Wxn+0oy1tl67TxUjQARAQABtClNYXR0aGlhcyBC cnVnZ2VyIDxtYXR0aGlhcy5iZ2dAZ21haWwuY29tPokCUgQTAQIAPAIbAwYLCQgHAwIGFQgC CQoLBBYCAwECHgECF4AWIQTmuZIYwPLDJRwsOhfZFAuyVhMC8QUCWt3scQIZAQAKCRDZFAuy VhMC8WzRD/4onkC+gCxG+dvui5SXCJ7bGLCu0xVtiGC673Kz5Aq3heITsERHBV0BqqctOEBy ZozQQe2Hindu9lasOmwfH8+vfTK+2teCgWesoE3g3XKbrOCB4RSrQmXGC3JYx6rcvMlLV/Ch YMRR3qv04BOchnjkGtvm9aZWH52/6XfChyh7XYndTe5F2bqeTjt+kF/ql+xMc4E6pniqIfkv c0wsH4CkBHqoZl9w5e/b9MspTqsU9NszTEOFhy7p2CYw6JEa/vmzR6YDzGs8AihieIXDOfpT DUr0YUlDrwDSrlm/2MjNIPTmSGHH94ScOqu/XmGW/0q1iar/Yr0leomUOeeEzCqQtunqShtE 4Mn2uEixFL+9jiVtMjujr6mphznwpEqObPCZ3IcWqOFEz77rSL+oqFiEA03A2WBDlMm++Sve 9jpkJBLosJRhAYmQ6ey6MFO6Krylw1LXcq5z1XQQavtFRgZoruHZ3XlhT5wcfLJtAqrtfCe0 aQ0kJW+4zj9/So0uxJDAtGuOpDYnmK26dgFN0tAhVuNInEVhtErtLJHeJzFKJzNyQ4GlCaLw jKcwWcqDJcrx9R7LsCu4l2XpKiyxY6fO4O8DnSleVll9NPfAZFZvf8AIy3EQ8BokUsiuUYHz wUo6pclk55PZRaAsHDX/fNr24uC6Eh5oNQ+v4Pax/gtyybkCDQRd1TkHARAAt1BBpmaH+0o+ deSyJotkrpzZZkbSs5ygBniCUGQqXpWqgrc7Uo/qtxOFL91uOsdX1/vsnJO9FyUv3ZNI2Thw NVGCTvCP9E6u4gSSuxEfVyVThCSPvRJHCG2rC+EMAOUMpxokcX9M2b7bBEbcSjeP/E4KTa39 q+JJSeWliaghUfMXXdimT/uxpP5Aa2/D/vcUUGHLelf9TyihHyBohdyNzeEF3v9rq7kdqamZ Ihb+WYrDio/SzqTd1g+wnPJbnu45zkoQrYtBu58n7u8oo+pUummOuTR2b6dcsiB9zJaiVRIg OqL8p3K2fnE8Ewwn6IKHnLTyx5T/r2Z0ikyOeijDumZ0VOPPLTnwmb780Nym3LW1OUMieKtn I3v5GzZyS83NontvsiRd4oPGQDRBT39jAyBr8vDRl/3RpLKuwWBFTs1bYMLu0sYarwowOz8+ Mn+CRFUvRrXxociw5n0P1PgJ7vQey4muCZ4VynH1SeVb3KZ59zcQHksKtpzz2OKhtX8FCeVO mHW9u4x8s/oUVMZCXEq9QrmVhdIvJnBCqq+1bh5UC2Rfjm/vLHwt5hes0HDstbCzLyiA0LTI ADdP77RN2OJbzBkCuWE21YCTLtc8kTQlP+G8m23K5w8k2jleCSKumprCr/5qPyNlkie1HC4E GEAfdfN+uLsFw6qPzSAsmukAEQEAAYkEbAQYAQgAIBYhBOa5khjA8sMlHCw6F9kUC7JWEwLx BQJd1TkHAhsCAkAJENkUC7JWEwLxwXQgBBkBCAAdFiEEUdvKHhzqrUYPB/u8L21+TfbCqH4F Al3VOQcACgkQL21+TfbCqH79RRAAtlb6oAL9y8JM5R1T3v02THFip8OMh7YvEJCnezle9Apq C6Vx26RSQjBV1JwSBv6BpgDBNXarTGCPXcre6KGfX8u1r6hnXAHZNHP7bFGJQiBv5RqGFf45 OhOhbjXCyHc0jrnNjY4M2jTkUC+KIuOzasvggU975nolC8MiaBqfgMB2ab5W+xEiTcNCOg3+ 1SRs5/ZkQ0iyyba2FihSeSw3jTUjPsJBF15xndexoc9jpi0RKuvPiJ191Xa3pzNntIxpsxqc ZkS1HSqPI63/urNezeSejBzW0Xz2Bi/b/5R9Hpxp1AEC3OzabOBATY/1Bmh2eAVK3xpN2Fe1 Zj7HrTgmzBmSefMcSXN0oKQWEI5tHtBbw5XUj0Nw4hMhUtiMfE2HAqcaozsL34sEzi3eethZ IvKnIOTmllsDFMbOBa8oUSoaNg7GzkWSKJ59a9qPJkoj/hJqqeyEXF+WTCUv6FcA8BtBJmVf FppFzLFM/QzF5fgDZmfjc9czjRJHAGHRMMnQlW88iWamjYVye57srNq9pUql6A4lITF7w00B 5PXINFk0lMcNUdkWipu24H6rJhOO6xSP4n6OrCCcGsXsAR5oH3d4TzA9iPYrmfXAXD+hTp82 s+7cEbTsCJ9MMq09/GTCeroTQiqkp50UaR0AvhuPdfjJwVYZfmMS1+5IXA/KY6DbGBAAs5ti AK0ieoZlCv/YxOSMCz10EQWMymD2gghjxojf4iwB2MbGp8UN4+++oKLHz+2j+IL08rd2ioFN YCJBFDVoDRpF/UnrQ8LsH55UZBHuu5XyMkdJzMaHRVQc1rzfluqx+0a/CQ6Cb2q7J2d45nYx 8jMSCsGj1/iU/bKjMBtuh91hsbdWCxMRW0JnGXxcEUklbhA5uGj3W4VYCfTQxwK6JiVt7JYp bX7JdRKIyq3iMDcsTXi7dhhwqsttQRwbBci0UdFGAG4jT5p6u65MMDVTXEgYfZy0674P06qf uSyff73ivwvLR025akzJui8MLU23rWRywXOyTINz8nsPFT4ZSGT1hr5VnIBs/esk/2yFmVoc FAxs1aBO29iHmjJ8D84EJvOcKfh9RKeW8yeBNKXHrcOV4MbMOts9+vpJgBFDnJeLFQPtTHuI kQXT4+yLDvwOVAW9MPLfcHlczq/A/nhGVaG+RKWDfJWNSu/mbhqUQt4J+RFpfx1gmL3yV8NN 7JXABPi5M97PeKdx6qc/c1o3oEHH8iBkWZIYMS9fd6rtAqV3+KH5Ors7tQVtwUIDYEvttmeO ifvpW6U/4au4zBYfvvXagbyXJhG9mZvz+jN1cr0/G2ZC93IbjFFwUmHtXS4ttQ4pbrX6fjTe lq5vmROjiWirpZGm+WA3Vx9QRjqfMdS5Ag0EXdU5SAEQAJu/Jk58uOB8HSGDSuGUB+lOacXC bVOOSywZkq+Ayv+3q/XIabyeaYMwhriNuXHjUxIORQoWHIHzTCqsAgHpJFfSHoM4ulCuOPFt XjqfEHkA0urB6S0jnvJ6ev875lL4Yi6JJO7WQYRs/l7OakJiT13GoOwDIn7hHH/PGUqQoZlA d1n5SVdg6cRd7EqJ+RMNoud7ply6nUSCRMNWbNqbgyWjKsD98CMjHa33SB9WQQSQyFlf+dz+ dpirWENCoY3vvwKJaSpfeqKYuqPVSxnqpKXqqyjNnG9W46OWZp+JV5ejbyUR/2U+vMwbTilL cIUpTgdmxPCA6J0GQjmKNsNKKYgIMn6W4o/LoiO7IgROm1sdn0KbJouCa2QZoQ0+p/7mJXhl tA0XGZhNlI3npD1lLpjdd42lWboU4VeuUp4VNOXIWU/L1NZwEwMIqzFXl4HmRi8MYbHHbpN5 zW+VUrFfeRDPyjrYpax+vWS+l658PPH+sWmhj3VclIoAU1nP33FrsNfp5BiQzao30rwe4ntd eEdPENvGmLfCwiUV2DNVrmJaE3CIUUl1KIRoB5oe7rJeOvf0WuQhWjIU98glXIrh3WYd7vsf jtbEXDoWhVtwZMShMvp7ccPCe2c4YBToIthxpDhoDPUdNwOssHNLD8G4JIBexwi4q7IT9lP6 sVstwvA5ABEBAAGJAjYEGAEIACAWIQTmuZIYwPLDJRwsOhfZFAuyVhMC8QUCXdU5SAIbDAAK CRDZFAuyVhMC8bXXD/4xyfbyPGnRYtR0KFlCgkG2XWeWSR2shSiM1PZGRPxR888zA2WBYHAk 7NpJlFchpaErV6WdFrXQjDAd9YwaEHucfS7SAhxIqdIqzV5vNFrMjwhB1N8MfdUJDpgyX7Zu k/Phd5aoZXNwsCRqaD2OwFZXr81zSXwE2UdPmIfTYTjeVsOAI7GZ7akCsRPK64ni0XfoXue2 XUSrUUTRimTkuMHrTYaHY3544a+GduQQLLA+avseLmjvKHxsU4zna0p0Yb4czwoJj+wSkVGQ NMDbxcY26CMPK204jhRm9RG687qq6691hbiuAtWABeAsl1AS+mdS7aP/4uOM4kFCvXYgIHxP /BoVz9CZTMEVAZVzbRKyYCLUf1wLhcHzugTiONz9fWMBLLskKvq7m1tlr61mNgY9nVwwClMU uE7i1H9r/2/UXLd+pY82zcXhFrfmKuCDmOkB5xPsOMVQJH8I0/lbqfLAqfsxSb/X1VKaP243 jzi+DzD9cvj2K6eD5j5kcKJJQactXqfJvF1Eb+OnxlB1BCLE8D1rNkPO5O742Mq3MgDmq19l +abzEL6QDAAxn9md8KwrA3RtucNh87cHlDXfUBKa7SRvBjTczDg+HEPNk2u3hrz1j3l2rliQ y1UfYx7Vk/TrdwUIJgKS8QAr8Lw9WuvY2hSqL9vEjx8VAkPWNWPwrQ== Message-ID: Date: Thu, 20 Feb 2020 23:17:46 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.5.0 MIME-Version: 1.0 In-Reply-To: <20200210063523.133333-4-hsinyi@chromium.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 10/02/2020 07:35, Hsin-Yi Wang wrote: > Fixing several unit name warnings: > > Warning (unit_address_vs_reg): /oscillator@0: node has a unit name, but no reg property > Warning (unit_address_vs_reg): /oscillator@1: node has a unit name, but no reg property > Warning (unit_address_vs_reg): /oscillator@2: node has a unit name, but no reg property > Warning (unit_address_vs_reg): /thermal-zones/cpu_thermal/trips/trip-point@0: node has a unit name, but no reg property > Warning (unit_address_vs_reg): /thermal-zones/cpu_thermal/trips/trip-point@1: node has a unit name, but no reg property > Warning (unit_address_vs_reg): /thermal-zones/cpu_thermal/trips/cpu_crit@0: node has a unit name, but no reg property > Warning (unit_address_vs_reg): /thermal-zones/cpu_thermal/cooling-maps/map@0: node has a unit name, but no reg property > Warning (unit_address_vs_reg): /thermal-zones/cpu_thermal/cooling-maps/map@1: node has a unit name, but no reg property > Warning (unit_address_vs_reg): /reserved-memory/vpu_dma_mem_region: node has a reg or ranges property, but no unit name > Warning (simple_bus_reg): /soc/pinctrl@10005000: simple-bus unit address format error, expected "1000b000" > Warning (simple_bus_reg): /soc/interrupt-controller@10220000: simple-bus unit address format error, expected "10221000" > Warning (alias_paths): /aliases: aliases property name must include only lowercase and '-' > > Signed-off-by: Hsin-Yi Wang > --- > arch/arm64/boot/dts/mediatek/mt8173.dtsi | 38 ++++++++++++------------ > 1 file changed, 19 insertions(+), 19 deletions(-) > > diff --git a/arch/arm64/boot/dts/mediatek/mt8173.dtsi b/arch/arm64/boot/dts/mediatek/mt8173.dtsi > index 790cd64aa447..2b7f566fb407 100644 > --- a/arch/arm64/boot/dts/mediatek/mt8173.dtsi > +++ b/arch/arm64/boot/dts/mediatek/mt8173.dtsi > @@ -42,14 +42,14 @@ aliases { > dpi0 = &dpi0; > dsi0 = &dsi0; > dsi1 = &dsi1; > - mdp_rdma0 = &mdp_rdma0; > - mdp_rdma1 = &mdp_rdma1; > - mdp_rsz0 = &mdp_rsz0; > - mdp_rsz1 = &mdp_rsz1; > - mdp_rsz2 = &mdp_rsz2; > - mdp_wdma0 = &mdp_wdma0; > - mdp_wrot0 = &mdp_wrot0; > - mdp_wrot1 = &mdp_wrot1; > + mdp-rdma0 = &mdp_rdma0; > + mdp-rdma1 = &mdp_rdma1; > + mdp-rsz0 = &mdp_rsz0; > + mdp-rsz1 = &mdp_rsz1; > + mdp-rsz2 = &mdp_rsz2; > + mdp-wdma0 = &mdp_wdma0; > + mdp-wrot0 = &mdp_wrot0; > + mdp-wrot1 = &mdp_wrot1; Won't we need to update the mdp driver as well, as it uses of_alias_get_id()? > serial0 = &uart0; > serial1 = &uart1; > serial2 = &uart2; > @@ -246,21 +246,21 @@ psci { > cpu_on = <0x84000003>; > }; > > - clk26m: oscillator@0 { > + clk26m: oscillator0 { > compatible = "fixed-clock"; > #clock-cells = <0>; > clock-frequency = <26000000>; > clock-output-names = "clk26m"; > }; > > - clk32k: oscillator@1 { > + clk32k: oscillator1 { > compatible = "fixed-clock"; > #clock-cells = <0>; > clock-frequency = <32000>; > clock-output-names = "clk32k"; > }; > > - cpum_ck: oscillator@2 { > + cpum_ck: oscillator2 { > compatible = "fixed-clock"; > #clock-cells = <0>; > clock-frequency = <0>; > @@ -276,19 +276,19 @@ cpu_thermal: cpu_thermal { > sustainable-power = <1500>; /* milliwatts */ > > trips { > - threshold: trip-point@0 { > + threshold: trip-point0 { > temperature = <68000>; > hysteresis = <2000>; > type = "passive"; > }; > > - target: trip-point@1 { > + target: trip-point1 { > temperature = <85000>; > hysteresis = <2000>; > type = "passive"; > }; > > - cpu_crit: cpu_crit@0 { > + cpu_crit: cpu_crit0 { > temperature = <115000>; > hysteresis = <2000>; > type = "critical"; > @@ -296,13 +296,13 @@ cpu_crit: cpu_crit@0 { > }; > > cooling-maps { > - map@0 { > + map0 { > trip = <&target>; > cooling-device = <&cpu0 0 0>, > <&cpu1 0 0>; > contribution = <3072>; > }; > - map@1 { > + map1 { > trip = <&target>; > cooling-device = <&cpu2 0 0>, > <&cpu3 0 0>; > @@ -316,7 +316,7 @@ reserved-memory { > #address-cells = <2>; > #size-cells = <2>; > ranges; > - vpu_dma_reserved: vpu_dma_mem_region { > + vpu_dma_reserved: vpu_dma_mem_region@b7000000 { > compatible = "shared-dma-pool"; > reg = <0 0xb7000000 0 0x500000>; > alignment = <0x1000>; > @@ -368,7 +368,7 @@ syscfg_pctl_a: syscfg_pctl_a@10005000 { > reg = <0 0x10005000 0 0x1000>; > }; > > - pio: pinctrl@10005000 { > + pio: pinctrl@1000b000 { > compatible = "mediatek,mt8173-pinctrl"; > reg = <0 0x1000b000 0 0x1000>; > mediatek,pctl-regmap = <&syscfg_pctl_a>; > @@ -575,7 +575,7 @@ mipi_tx1: mipi-dphy@10216000 { > status = "disabled"; > }; > > - gic: interrupt-controller@10220000 { > + gic: interrupt-controller@10221000 { > compatible = "arm,gic-400"; > #interrupt-cells = <3>; > interrupt-parent = <&gic>; >