From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B59B2C10DCE for ; Sun, 8 Mar 2020 20:33:19 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 85F7C20828 for ; Sun, 8 Mar 2020 20:33:19 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="YQ9Pl+Ye" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726373AbgCHUdS (ORCPT ); Sun, 8 Mar 2020 16:33:18 -0400 Received: from mail-pg1-f195.google.com ([209.85.215.195]:34725 "EHLO mail-pg1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726332AbgCHUdS (ORCPT ); Sun, 8 Mar 2020 16:33:18 -0400 Received: by mail-pg1-f195.google.com with SMTP id t3so3752667pgn.1 for ; Sun, 08 Mar 2020 13:33:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=message-id:subject:from:to:cc:date:in-reply-to:references :mime-version:content-transfer-encoding; bh=GK4c/eKJ7QEQIDQAkYSm28K6U9vkh6nkkxoflqtOBfo=; b=YQ9Pl+YeSr6cLsgl4sKOvl+ys4fHwJetGN0TQ3EF5eCM3m5kDEv3WUwdl2Ds/0qXaF Rhv4JlRNB3tsaVf31sBW8J5QNYSK+AFXGvNvs9ivLoUvu3NhF39E0BNhzC64Yvk4R/WJ CGIR6BWsby68t75OOBIMbfsWEpWK7kU1ydCr7dxSE02WiGFvnVMbFlL4+NFYd+ASaesd leLSZ7fciTuowxUbPjv7/YAR6LrCwkaaoV8qOzCPQyYO6P8mhXtLkZ46rT6ZSdedu08X 5jw4Qgfq2R/A3BvQ7xMuU47vnybhjuheS8Sc68tk7FkxNdkR6X3CuLeqpTrVfomtGwsL 1Sjw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:message-id:subject:from:to:cc:date:in-reply-to :references:mime-version:content-transfer-encoding; bh=GK4c/eKJ7QEQIDQAkYSm28K6U9vkh6nkkxoflqtOBfo=; b=eX0ZbCRgJsS9+2Hh8Dm7FTd9Dl+SReWGArxo8b+BNxGy3cad2QZi1QqZ89pDS0NLqq Q2xkOOdhG/I8yeSBLHzkP38xR5ZGrzuETK1SKdVYlIdJb1gnq2AFCXGn1qHr8Y/vGAE1 ci0mMkCPv7oS5cXTH3zW88bxzdRy79R7B7ZPPgQ8RX1gFOSH7RbbuAQzItHwyN9z4uob 9DUXskMUChoKnaOl6EYQkkrZ9dzM9SDmyWfGpp02+kxUlmaaFHfHLQv/BGxjDETkL5hI 8xQ7POzGOM/lXjg7jhv1Zobx/LFvN+tLZKt19jBlShNmD4CKSQbImnkm+y1qAkXj+d7N +9LA== X-Gm-Message-State: ANhLgQ1meSE49iW5IKsrrCd5ZNN1rK0TRWrBEm74GiiKEZohhrltiDEP Z0PCIMcZL7WE6YqNC1+qscg= X-Google-Smtp-Source: ADFU+vs1cWEri/U86lkcqDV3qe4fzJ8+NJwNql2lW614C0+3iLxWtCOh2+S2Vs0Oyl/OeDzoki142w== X-Received: by 2002:a63:a055:: with SMTP id u21mr10473931pgn.100.1583699597039; Sun, 08 Mar 2020 13:33:17 -0700 (PDT) Received: from Shreeya-Patel ([1.23.250.201]) by smtp.googlemail.com with ESMTPSA id c17sm21500825pfo.71.2020.03.08.13.33.13 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sun, 08 Mar 2020 13:33:16 -0700 (PDT) Message-ID: Subject: Re: [Outreachy kernel] [PATCH] Staging: rtl8188eu: Add space around operator From: Shreeya Patel To: Joe Perches , Julia Lawall Cc: Larry.Finger@lwfinger.net, gregkh@linuxfoundation.org, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org, outreachy-kernel@googlegroups.com, sbrivio@redhat.com, daniel.baluta@gmail.com, nramas@linux.microsoft.com, hverkuil@xs4all.nl Date: Mon, 09 Mar 2020 02:03:11 +0530 In-Reply-To: References: <20200308192152.26403-1-shreeya.patel23498@gmail.com> <5a28241e8c3b11cbfe1776caadcb799cd9e39ee4.camel@perches.com> <465a7cfe822438a8edd32d3a5120bd565797ca4d.camel@gmail.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.28.5-0ubuntu0.18.04.1 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, 2020-03-08 at 13:19 -0700, Joe Perches wrote: > On Mon, 2020-03-09 at 01:40 +0530, Shreeya Patel wrote: > > On Sun, 2020-03-08 at 12:59 -0700, Joe Perches wrote: > > Hi Joe, > > Hello. > [] > > > > > diff --git a/drivers/staging/rtl8188eu/core/rtw_mlme.c > > > > > b/drivers/staging/rtl8188eu/core/rtw_mlme.c > > > > > > [] > > > > > @@ -924,7 +924,7 @@ static void > > > > > rtw_joinbss_update_network(struct > > > > > adapter *padapter, struct wlan_net > > > > > /* update fw_state will clr _FW_UNDER_LINKING here > > > > > indirectly > > > > > */ > > > > > switch (pnetwork->network.InfrastructureMode) { > > > > > case Ndis802_11Infrastructure: > > > > > - if (pmlmepriv->fw_state&WIFI_UNDER_WPS) > > > > > + if (pmlmepriv->fw_state & WIFI_UNDER_WPS) > > > > > pmlmepriv->fw_state = > > > > > WIFI_STATION_STATE|WIFI_UNDER_WPS; > > > > > > Like adding spaces around the | here too. > > > > > > > I thought of doing this but then it was introducing another warning > > of > > "Line over 80 charachters" that is why I didn't proceed with it. > > [] > > What is your suggestion over it? Should I let the line be over 80 > > characters and add spaces around the operators? > > Just ignore the long line warnings, there are many already > existing long > lines in that subsystem. > > That should be a style challenge for a later time. Okay got it. > > $ git ls-files drivers/staging/rtl8188eu | \ > xargs awk '{ print length($0); }' | \ > sort | uniq -c | sort -rn -k2 > 1 187 > 1 180 > 1 171 > 1 166 > 1 163 > 1 159 > 1 158 > 2 157 > 1 153 > 2 151 > 1 146 > 1 145 > 1 144 > 1 143 > 1 142 > 2 141 > 1 140 > 1 139 > 1 137 > 1 135 > 5 134 > 6 132 > 3 131 > 3 130 > 6 129 > 3 128 > 6 127 > 6 126 > 3 125 > 3 124 > 5 123 > 4 122 > 8 121 > 6 120 > 4 119 > 7 118 > 10 117 > 11 116 > 9 115 > 5 114 > 11 113 > 13 112 > 8 111 > 17 110 > 25 109 > 24 108 > 14 107 > 20 106 > 19 105 > 34 104 > 19 103 > 26 102 > 22 101 > 22 100 > 25 99 > 20 98 > 23 97 > 33 96 > 32 95 > 43 94 > 40 93 > 49 92 > 47 91 > 51 90 > 48 89 > 55 88 > 50 87 > 37 86 > 48 85 > 57 84 > 45 83 > 61 82 > 61 81 I think the idea of yours to automate the change for some common warnings will be really helpful to get rid of them. Thanks, I'm going to try doing it for other drivers as well :) > >