From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0A7B9C27C76 for ; Wed, 25 Jan 2023 15:52:02 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235634AbjAYPwA (ORCPT ); Wed, 25 Jan 2023 10:52:00 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35098 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234770AbjAYPv6 (ORCPT ); Wed, 25 Jan 2023 10:51:58 -0500 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4DF9B5975A; Wed, 25 Jan 2023 07:51:53 -0800 (PST) Received: from pps.filterd (m0279870.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 30PEP7B4030492; Wed, 25 Jan 2023 15:51:04 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; h=message-id : date : mime-version : subject : to : references : from : in-reply-to : content-type : content-transfer-encoding; s=qcppdkim1; bh=Ot3thYC/XF960Hm4CCL8hZjS2AUE9XkW1K+tW89TnXg=; b=j3XjAWjmmitofe6f7v7wRCAN+q81GZLuePym9+Bn5377FTG/XGTIWIUwM7bMGaxbbTNe vUoX9oc6N6ylVzNtYtVgVr9f9gNFIOfSp3C3sOQPwX5+fEd1dSuS9S9bLnf3EcVMnx+0 mbJIfNWC73UX5XqRq8IlWYw8LkdxaiG3o7mA3ABA9Nz8UGFU4VMwrE4Kqa4vodPOV6xC RqRnkNQJvbDg7JhidIrFRv66RwtM6UMv5uPaPn6R8DppB/tUoZqsx+9wxUmVjEg0kwvb zX9m5I9ePSQv8POPCUuUyh6ehikdnUcmYhzz3Eeq0Mv+sorwKZ+Z/gsxpU3oWcYqWoeU CQ== Received: from nalasppmta01.qualcomm.com (Global_NAT1.qualcomm.com [129.46.96.20]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 3napvhhgdb-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 25 Jan 2023 15:51:03 +0000 Received: from nalasex01a.na.qualcomm.com (nalasex01a.na.qualcomm.com [10.47.209.196]) by NALASPPMTA01.qualcomm.com (8.17.1.5/8.17.1.5) with ESMTPS id 30PFp1La011821 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 25 Jan 2023 15:51:01 GMT Received: from [10.50.43.172] (10.80.80.8) by nalasex01a.na.qualcomm.com (10.47.209.196) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.36; Wed, 25 Jan 2023 07:50:52 -0800 Message-ID: Date: Wed, 25 Jan 2023 21:20:49 +0530 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.7.0 Subject: Re: [PATCH 04/10] dt-bindings: clock: Add Qualcomm IPQ5332 GCC Content-Language: en-US To: Krzysztof Kozlowski , , , , , , , , , , , , , , , , , , , , , , , , , , , References: <20230125104520.89684-1-quic_kathirav@quicinc.com> <20230125104520.89684-5-quic_kathirav@quicinc.com> From: Kathiravan Thirumoorthy In-Reply-To: Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.80.80.8] X-ClientProxiedBy: nasanex01b.na.qualcomm.com (10.46.141.250) To nalasex01a.na.qualcomm.com (10.47.209.196) X-QCInternal: smtphost X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=5800 signatures=585085 X-Proofpoint-GUID: eGeuIrkmqau1Mo9Fudal6J6rV-ngOgyJ X-Proofpoint-ORIG-GUID: eGeuIrkmqau1Mo9Fudal6J6rV-ngOgyJ X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.219,Aquarius:18.0.930,Hydra:6.0.562,FMLib:17.11.122.1 definitions=2023-01-25_10,2023-01-25_01,2022-06-22_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 lowpriorityscore=0 bulkscore=0 malwarescore=0 mlxlogscore=999 phishscore=0 adultscore=0 impostorscore=0 mlxscore=0 spamscore=0 suspectscore=0 priorityscore=1501 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2212070000 definitions=main-2301250141 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 1/25/2023 4:43 PM, Krzysztof Kozlowski wrote: > On 25/01/2023 11:45, Kathiravan Thirumoorthy wrote: >> From: Kathiravan T >> >> Add binding for the Qualcomm IPQ5332 Global Clock Controller. >> >> Signed-off-by: Kathiravan T >> --- > Thank you for your patch. There is something to discuss/improve. Thanks for taking time to review the patch. > >> + clocks: >> + items: >> + - description: Board XO clock source >> + - description: Sleep clock source >> + - description: PCIE 2lane PHY pipe clock source >> + - description: PCIE 2lane x1 PHY pipe clock source (For second lane) >> + - description: USB PCIE wrapper pipe clock source >> + >> + clock-names: >> + items: >> + - const: xo >> + - const: sleep_clk >> + - const: pcie_2lane_phy_pipe_clk >> + - const: pcie_2lane_phy_pipe_clk_x1 >> + - const: usb_pcie_wrapper_pipe_clk >> + >> +required: >> + - compatible > clocks are required Ack. > >> + >> +unevaluatedProperties: false >> + >> +examples: >> + - | >> + clock-controller@1800000 { >> + compatible = "qcom,ipq5332-gcc"; >> + reg = <0x01800000 0x80000>; >> + #clock-cells = <1>; >> + #power-domain-cells = <1>; >> + #reset-cells = <1>; >> + }; >> +... >> diff --git a/include/dt-bindings/clock/qcom,gcc-ipq5332.h b/include/dt-bindings/clock/qcom,gcc-ipq5332.h >> new file mode 100644 >> index 000000000000..a305c648b724 >> --- /dev/null >> +++ b/include/dt-bindings/clock/qcom,gcc-ipq5332.h > Filename should match bindings/compatible. Ack. > > > Best regards, > Krzysztof Thanks, Kathiravan T.