From: Guenter Roeck <linux@roeck-us.net>
To: Avri Altman <Avri.Altman@wdc.com>,
"James E . J . Bottomley" <jejb@linux.vnet.ibm.com>,
"Martin K . Petersen" <martin.petersen@oracle.com>
Cc: "linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Bart Van Assche <bvanassche@acm.org>,
Adrian Hunter <adrian.hunter@intel.com>,
Bean Huo <beanhuo@micron.com>
Subject: Re: [PATCH v3 1/2] scsi: ufs: Probe for temperature notification support
Date: Mon, 13 Sep 2021 07:24:29 -0700 [thread overview]
Message-ID: <bbe45ecf-853f-77f7-9094-ded8c59075f4@roeck-us.net> (raw)
In-Reply-To: <DM6PR04MB657565612A342272B2160A72FCD99@DM6PR04MB6575.namprd04.prod.outlook.com>
On 9/13/21 12:49 AM, Avri Altman wrote:
>>>> The "enable" attribute only makes sense if it can be used to actually
>>>> enable or disable a specific sensor, and is not tied to limit
>>>> attributes but to the actual sensor values.
>>> See explanation above.
>>> Will make it writable as well.
>>>
>>
>> That only makes sense if the information is passed to the chip. What is going to
>> happen if the user writes 0 into the attribute ?
> Will turn off the temperature exception bits, so that Tcase is no longer valid,
> and the device will always return Tcase = 0.
>
Ok. Then attempts to read the temperature should return -ENODATA, not -EINVAL,
if Tcase == 0.
Guenter
next prev parent reply other threads:[~2021-09-13 15:26 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-12 13:19 [PATCH v3 0/2] Add temperature notification support Avri Altman
2021-09-12 13:19 ` [PATCH v3 1/2] scsi: ufs: Probe for " Avri Altman
2021-09-12 15:24 ` Guenter Roeck
2021-09-13 7:06 ` Avri Altman
2021-09-13 7:41 ` Guenter Roeck
2021-09-13 7:49 ` Avri Altman
2021-09-13 14:24 ` Guenter Roeck [this message]
2021-09-13 15:26 ` Avri Altman
2021-09-12 13:19 ` [PATCH v3 2/2] scsi: ufs: Add temperature notification exception handling Avri Altman
2021-09-12 15:43 ` kernel test robot
2021-09-12 15:55 ` Guenter Roeck
2021-09-13 6:09 ` Avri Altman
2021-09-12 16:33 ` kernel test robot
2021-09-12 16:50 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bbe45ecf-853f-77f7-9094-ded8c59075f4@roeck-us.net \
--to=linux@roeck-us.net \
--cc=Avri.Altman@wdc.com \
--cc=adrian.hunter@intel.com \
--cc=beanhuo@micron.com \
--cc=bvanassche@acm.org \
--cc=jejb@linux.vnet.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).