From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A508FC433EF for ; Tue, 19 Jul 2022 17:07:07 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237847AbiGSRHG (ORCPT ); Tue, 19 Jul 2022 13:07:06 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60496 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238136AbiGSRG5 (ORCPT ); Tue, 19 Jul 2022 13:06:57 -0400 Received: from mail-wr1-x434.google.com (mail-wr1-x434.google.com [IPv6:2a00:1450:4864:20::434]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5C6E65A45D for ; Tue, 19 Jul 2022 10:06:44 -0700 (PDT) Received: by mail-wr1-x434.google.com with SMTP id h17so22622091wrx.0 for ; Tue, 19 Jul 2022 10:06:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=PPoKfBGkXXxmGl6O1Gk3RK4S8Nhp870sCocHUBEXJII=; b=ggzcS2a91OOnHLScrhNTeWz1TSdg4gFtX5yMfeZLPwtfcqOyOmobVOPjLQZ4rlE+xR Bq6B/cR1Z/y0nPj/9OrvBKy7LM8B3LMPhZ7YZfY4WeYacZKpAwJfrLaU3523tNLoAKI8 mtmsrrw+zMsiBfHZ3umy8xolYJw8A7vTKzk0bQ3lYL4jNDVSXCKm54iIAeON1J+Q+z3I aEYI4IAd2bLqJ+t508ju7MZmlpyruWaxCOFmfk1+BXh+pQYSd1azpYc8EHQr4B/GAKwh xgANz7Ab/4Kk9/2tNFr5wD6TITAfzK0JxWh5w/Rv6+zA7uZHhOGTFGcPLcqAHKBLhzrU TSCg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=PPoKfBGkXXxmGl6O1Gk3RK4S8Nhp870sCocHUBEXJII=; b=dmzugFVPRkzKIaqAip2PQqLjZQtytGTS8YZ8pIaEIXo1tdRnNXyoz9sKmc1FmsbnIP qKzOEtd9JjIUQMLwQ5Tp8q8tiuPUE8KmSnuTePZE7Bu3GXaR1zMdNqhx+oOGWD67RQtw rdauxz0+yDsg6q+5j9HYclMy3rExwi2trE+YtxIj3wpUNSseJp7iJCvT5+GmdNXOlZby HAVUkLqdRR2Y114eJQOR15MGaF+f3mD1SfliU+BczDgrCs92NaCADi4tXQQZNF5IUUwA MAhduSEZrizv818VjNaxnnBzQu2j3K8RPUby0XeHxvokph+V2BgmM2XtB8hTVKYcwYim 1t+g== X-Gm-Message-State: AJIora8/CW9Viaz99sMuTo4dhbIcQoi7LKFC/XUJ3oL7ZDtjodtZPRyc RC6+XioHuHxYXGR/S7eYEdpNOw== X-Google-Smtp-Source: AGRyM1vL+bLH1TV5rnrlHM7im1g77qgAlj+SscRCiKMGDazhRA+LaVuI+eN5qQuPFJBsUL48zgM5hw== X-Received: by 2002:a05:6000:8e:b0:21d:7e97:67ed with SMTP id m14-20020a056000008e00b0021d7e9767edmr26686956wrx.343.1658250402825; Tue, 19 Jul 2022 10:06:42 -0700 (PDT) Received: from ?IPV6:2a05:6e02:1041:c10:b579:e7b5:219d:267c? ([2a05:6e02:1041:c10:b579:e7b5:219d:267c]) by smtp.googlemail.com with ESMTPSA id p10-20020a05600c1d8a00b003a30af0ec83sm17505000wms.25.2022.07.19.10.06.41 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 19 Jul 2022 10:06:42 -0700 (PDT) Message-ID: Date: Tue, 19 Jul 2022 19:06:40 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.9.1 Subject: Re: [PATCH RESEND] tools/thermal: tmon: include pthread and time headers in tmon.h Content-Language: en-US To: Florian Fainelli , linux-kernel@vger.kernel.org Cc: Markus Mayer , Sumeet Pawnikar , =?UTF-8?Q?Alejandro_Gonz=c3=a1lez?= , "Rafael J. Wysocki" , Amit Kucheria , Zhang Rui , Markus Mayer , "open list:THERMAL" References: <20220718031040.44714-1-f.fainelli@gmail.com> From: Daniel Lezcano In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 19/07/2022 18:11, Florian Fainelli wrote: > > > On 7/17/2022 8:10 PM, Florian Fainelli wrote: >> From: Markus Mayer >> >> Include sys/time.h and pthread.h in tmon.h, so that types >> "pthread_mutex_t" and "struct timeval tv" are known when tmon.h >> references them. >> >> Without these headers, compiling tmon against musl-libc will fail with >> these errors: >> >> In file included from sysfs.c:31:0: >> tmon.h:47:8: error: unknown type name 'pthread_mutex_t' >>   extern pthread_mutex_t input_lock; >>          ^~~~~~~~~~~~~~~ >> make[3]: *** [: sysfs.o] Error 1 >> make[3]: *** Waiting for unfinished jobs.... >> In file included from tui.c:31:0: >> tmon.h:54:17: error: field 'tv' has incomplete type >>    struct timeval tv; >>                   ^~ >> make[3]: *** [: tui.o] Error 1 >> make[2]: *** [Makefile:83: tmon] Error 2 >> >> Signed-off-by: Markus Mayer >> Acked-by: Florian Fainelli >> Reviewed-by: Sumeet Pawnikar >> Acked-by: Alejandro González >> Tested-by: Alejandro González >> --- >> This patch was first submitted here: >> >> https://lore.kernel.org/all/20200617235809.6817-1-mmayer@broadcom.com/ >> >> but never applied, meanwhile the issue is still present > > Daniel, Rafael, any chance to get that into v5.19-rc7? I should probably > also have added: > > Fixes: 94f69966faf8 ("tools/thermal: Introduce tmon, a tool for thermal > subsystem") Yes, I'll pick it up Thanks for resending -- Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog