From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.2 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1EBBFC49EA7 for ; Fri, 25 Jun 2021 17:26:28 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 02A4D6199C for ; Fri, 25 Jun 2021 17:26:27 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230083AbhFYR2r (ORCPT ); Fri, 25 Jun 2021 13:28:47 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41078 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229630AbhFYR2p (ORCPT ); Fri, 25 Jun 2021 13:28:45 -0400 Received: from mail-wr1-x430.google.com (mail-wr1-x430.google.com [IPv6:2a00:1450:4864:20::430]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C5907C061574; Fri, 25 Jun 2021 10:26:23 -0700 (PDT) Received: by mail-wr1-x430.google.com with SMTP id a13so11371377wrf.10; Fri, 25 Jun 2021 10:26:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-transfer-encoding:content-language; bh=4QI+hOEPUjUXgGj/0NkLNcxkrgoIPtZX2ZwWHw7Tor0=; b=JuXFHVRf8avdk6DJPLBA8wpDI1/HBLfgM4g2AX5CM/b6sZb1QPSzQw5+ymOX66jZLR vg2/hAm9ZRwEnqX/AqZrKXE8uIFVZTGY846oips89npSGgAA+8Gk164AzP8FEDegFaeF ehffEJ511FCWd4CKP/GFEFYzkkrUgO4UPB2qx1CfQ/C69sBdKK+MsloTrUQZV/WiNGT0 PSo39vzMbMNUcOhMeQ7aYX9pyqxMsBqKw4Ityz7v4Hsrzl+tPrHcy+xxWmshQbEk+sGA WJHyWIzC8yPCEcIl9wPGpdeAy71bQlKy1JyvoTkYTZjwzNeA8s/KV8mTsQDtD5kJOi6C Tyew== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding :content-language; bh=4QI+hOEPUjUXgGj/0NkLNcxkrgoIPtZX2ZwWHw7Tor0=; b=YKpb3cZlb6barptozYeomHeg8+j6ZORNmMHt2eTLX2oiAExqvRZauK6texePy5X7Z+ sJWISY5YEwXjb2tZ+cbiSOue+6zGigBQqOkJ3KPiTRxCGNnatwVUUBqAfHh8upq0+bWy CYx5fSffq4KrsoZIQxbqz04bKHunBKdSFWHSPhDnf9DKyLMg4ammjcSCRPfFiiTVzmUr HZHp7H3jpKQVosXe7oGGN2ehgpU1i5HixAKKyF1hnRsi/6QYhHzEwKQZfk8LkHUDwyBX H5nmFu/uMnCOGyIKSj185tt75Ykf1oxJSJSWoPQgAkXQBL07+nFRmlymjTgpWbSuDmcW 7zeA== X-Gm-Message-State: AOAM530zOvp6oJtzBuiOxyIj5VY/nZDjGre/y9Uy+6XS//dMDRKk3gJD rXXKsAg1HLfYSGSSECV8DgbJ2NHzkdFXzQ== X-Google-Smtp-Source: ABdhPJwzxA9RRn9LlPBaD6PzNaRqzDeqYVg+jF+ZjyPUhEtVOcN/QYSI9Zjc9h5n1zVOWc2EAjbqcg== X-Received: by 2002:a5d:6d8d:: with SMTP id l13mr10740085wrs.358.1624641982413; Fri, 25 Jun 2021 10:26:22 -0700 (PDT) Received: from localhost.localdomain (haganm.plus.com. [212.159.108.31]) by smtp.gmail.com with ESMTPSA id w9sm6609998wru.3.2021.06.25.10.26.21 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 25 Jun 2021 10:26:22 -0700 (PDT) Subject: Re: [PATCH v4 2/4] ARM: dts: NSP: Add DT files for Meraki MX64 series To: Arnd Bergmann List-Id: Cc: Florian Fainelli , Vladimir Oltean , Rob Herring , Olof Johansson , SoC Team , Ray Jui , Scott Branden , bcm-kernel-feedback-list , Viresh Kumar , Sam Ravnborg , Geert Uytterhoeven , DTML , Linux Kernel Mailing List , Linux ARM References: <20210625095000.3358973-1-mnhagan88@gmail.com> <20210625095000.3358973-3-mnhagan88@gmail.com> From: Matthew Hagan Message-ID: Date: Fri, 25 Jun 2021 18:26:19 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Content-Language: en-US Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 25/06/2021 10:59, Arnd Bergmann wrote: > On Fri, Jun 25, 2021 at 11:52 AM Matthew Hagan wrote: >> MX64 & MX64W Hardware info: >> - CPU: Broadcom BCM58625 Cortex A9 @ 1200Mhz >> - RAM: 2 GB (4 x 4Gb SK Hynix H5TC4G83CFR) >> - Storage: 1 GB (Micron MT29F8G08ABACA) >> - Networking: BCM58625 internal switch (5x 1GbE ports) >> - USB: 1x USB2.0 >> - Serial: Internal header >> - WLAN(MX64W only): 2x Broadcom BCM43520KMLG on the PCI bus >> >> This patch adds the Meraki MX64 series-specific bindings. Since some >> devices make use of the older A0 SoC, changes need to be made to >> accommodate this case, including removal of coherency options and >> modification to the secondary-boot-reg. >> >> Signed-off-by: Matthew Hagan > Removing the dma-coherent flags in the dts file seemed really odd until > I read the text above. It would seem more logical to me to have a .dtsi file > that has all the a0 revision specific changes, and include that from the > dts file. How about having separate bcm-nsp-ax and bcm-nsp-bx dtsi files with the appropriate secondary-boot-reg and dma-coherent (or lack of) properties, which then include bcm-nsp.dtsi. Thus we can also avoid use of /delete-property/. Would this be preferable? > > On the other hand, the /chosen, /aliases and /memory nodes that you have > in the .dtsi file should probably get moved into the .dts files, as these tend > to be board specific settings, even if the examples you have are all > the same. I did not come across any convention regarding this, though there are plenty of cases where the /chosen, /aliases and /memory nodes are defined in a .dtsi file and used by multiple similar boards. Also note in this case /aliases is defined in bcm-nsp.dtsi, not by me. Would we not prefer to avoid having 6x duplication? > Arnd > Matthew