From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.3 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DCD36C63777 for ; Mon, 23 Nov 2020 10:38:52 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 8AD8C2076E for ; Mon, 23 Nov 2020 10:38:52 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=nvidia.com header.i=@nvidia.com header.b="X1usOJU0" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728657AbgKWKia (ORCPT ); Mon, 23 Nov 2020 05:38:30 -0500 Received: from hqnvemgate26.nvidia.com ([216.228.121.65]:3872 "EHLO hqnvemgate26.nvidia.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727444AbgKWKi3 (ORCPT ); Mon, 23 Nov 2020 05:38:29 -0500 Received: from hqmail.nvidia.com (Not Verified[216.228.121.13]) by hqnvemgate26.nvidia.com (using TLS: TLSv1.2, AES256-SHA) id ; Mon, 23 Nov 2020 02:38:31 -0800 Received: from [10.26.72.66] (10.124.1.5) by HQMAIL107.nvidia.com (172.20.187.13) with Microsoft SMTP Server (TLS) id 15.0.1473.3; Mon, 23 Nov 2020 10:38:26 +0000 Subject: Re: [PATCH v5 0/6] Tegra210 audio graph card To: Sameer Pujar , , , CC: , , , , , References: <1605119676-32273-1-git-send-email-spujar@nvidia.com> From: Jon Hunter Message-ID: Date: Mon, 23 Nov 2020 10:38:24 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <1605119676-32273-1-git-send-email-spujar@nvidia.com> Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [10.124.1.5] X-ClientProxiedBy: HQMAIL111.nvidia.com (172.20.187.18) To HQMAIL107.nvidia.com (172.20.187.13) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nvidia.com; s=n1; t=1606127911; bh=rja4mFvPtVCeH4UELYSy3t07Yo+UPDvUCyzzCQixKww=; h=Subject:To:CC:References:From:Message-ID:Date:User-Agent: MIME-Version:In-Reply-To:Content-Type:Content-Language: Content-Transfer-Encoding:X-Originating-IP:X-ClientProxiedBy; b=X1usOJU0UqprKtf9SA4DFxYJrh+6K9X8SYt/mat5kG4dSMka4gKP49pcyT+p8VgMd C+RHSlT9DCECut9i25KXabM0IxvutDNtWbugyunFjn0LqQlhgoJXa+ta3UkfzVm4XO XEF+/6ueRwEjEcEWdzXXOOej6W5Qgd80k5W+UWwjNrurK3OhrJJ+i87dEmtGhT7pfr E1wGOeL9KWUjTZkz1tKSi1j9C8Eyvq1PfaSQ83Ks9XxpXcJ52QNV0EZAf5zjx8aI5D ntYZjtEFwhHiXVgiCJxXImRFz5M4DgFwlR6ST45KR+i02u0QRE2bwMHBRBHVs2/CQf KiJk20Zt8/N0Q== Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 11/11/2020 18:34, Sameer Pujar wrote: > This series adds audio graph based sound card support for Tegra210 > platforms like Jetson-TX1 an Jetson-Nano. The following preparatory > audio graph enhancement series is already merged. > * https://patchwork.kernel.org/project/alsa-devel/list/?series=375629&state=* > > Following are the summary of changes: > * Add graph/audio-graph based schemas or schema updates for Tegra210 > component and machine drivers. > * Add Tegra audio graph machine driver. > * Add required DT support for Jetson-TX1/Nano. > > This work is based on earlier discussion of DPCM usage for Tegra > and simple card driver updates. > * https://lkml.org/lkml/2020/4/30/519 > * https://lkml.org/lkml/2020/6/27/4 > > This series has dependency over following graph and audio-graph series. > * http://patchwork.ozlabs.org/project/devicetree-bindings/patch/20201102203656.220187-2-robh@kernel.org/ > * https://patchwork.kernel.org/project/alsa-devel/list/?series=382009&state=* Only one minor comment, but this looks good to me. Otherwise for the series ... Reviewed-by: Jon Hunter Cheers Jon -- nvpublic