From: Dmitry Osipenko <firstname.lastname@example.org> To: Guenter Roeck <email@example.com> Cc: Jean Delvare <firstname.lastname@example.org>, email@example.com, firstname.lastname@example.org Subject: Re: [PATCH v1] hwmon: (lm90) Use edge-triggered interrupt Date: Thu, 17 Jun 2021 17:46:33 +0300 [thread overview] Message-ID: <email@example.com> (raw) In-Reply-To: <20210617141300.GA1366442@roeck-us.net> 17.06.2021 17:13, Guenter Roeck пишет: ... >> This is a device-tree based system, in particular it's NVIDIA Tegra30 >> Nexus 7. The interrupt support was originally added to the lm90 driver >> by Wei Ni who works at NVIDIA and did it for the Tegra boards. The Tegra >> device-trees are specifying the trigger mask and apparently they all are >> cargo-culted and wrong because they use IRQ_TYPE_LEVEL_HIGH, while it > > Be fair, no one is perfect. This is a very minor problem, so no wonder that nobody noticed or bothered to fix it yet. I'm just clarifying the status here. >> should be IRQ_TYPE_EDGE_FALLING. > > It should probably be both IRQ_TYPE_EDGE_FALLING and IRQ_TYPE_EDGE_RISING, For now I see that the rising edge isn't needed, the TEMP_ALERT goes HIGH by itself when temperature backs to normal. But I will try to double check. > and the interrupt handler should call hwmon_notify_event() instead of > clogging the kernel log, but that should be done in a separate patch. Thank you for suggestion, I will take a look. > Anyway, the tegra30 dts files in the upstream kernel either use > IRQ_TYPE_LEVEL_LOW or no interrupts for nct1008. The Nexus 7 dts file > in the upstream kernel has no interrupt configured (and coincidentally > it was you who added that entry). Where do you see IRQ_TYPE_LEVEL_HIGH ? I have a patch that will add the interrupt property, it's stashed locally for the next kernel release. IIUC, it's not only the Tegra30 dts, but all the TegraXXX boards that use IRQ_TYPE_LEVEL_LOW are in the same position. >> The IRQF flag in devm_request_threaded_irq() overrides the trigger mask >> specified in a device-tree. IIUC, the interrupt is used only by OF-based >> devices, hence I think we could simply remove the IRQF flag from the >> code and fix the device-trees. Does it sound good to you? > > Yes, that is a better approach. Thank you for reviewing this patch. I'll prepare v2.
next prev parent reply other threads:[~2021-06-17 14:46 UTC|newest] Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-06-16 19:07 Dmitry Osipenko 2021-06-17 0:12 ` Guenter Roeck 2021-06-17 7:11 ` Dmitry Osipenko 2021-06-17 13:12 ` Guenter Roeck 2021-06-17 13:48 ` Dmitry Osipenko 2021-06-17 14:13 ` Guenter Roeck 2021-06-17 14:46 ` Dmitry Osipenko [this message] 2021-06-17 15:12 ` Guenter Roeck 2021-06-17 15:27 ` Dmitry Osipenko 2021-06-17 21:42 ` Guenter Roeck 2021-06-18 8:55 ` Dmitry Osipenko
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --subject='Re: [PATCH v1] hwmon: (lm90) Use edge-triggered interrupt' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).