From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757104AbYGILoi (ORCPT ); Wed, 9 Jul 2008 07:44:38 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753156AbYGILob (ORCPT ); Wed, 9 Jul 2008 07:44:31 -0400 Received: from rv-out-0506.google.com ([209.85.198.230]:33478 "EHLO rv-out-0506.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751171AbYGILoa (ORCPT ); Wed, 9 Jul 2008 07:44:30 -0400 DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=message-id:date:from:to:subject:cc:in-reply-to:mime-version :content-type:content-transfer-encoding:content-disposition :references; b=rAQzEVfvHJVVxXNjJeaTUVeo9/KQL8cl/TXH1BqHgs81Sh3rtaYUzVz36IBvb5SvaD 1EQ5eUxlOKAkmqy+ZlucxsWbt7toUBBRevgr8ikrYHFpI8c6uGW0OY47VMTeoy4DQhnc j8L4OFcSIuqRKMsxy7Hl1aIriwvEVIyXKoAm8= Message-ID: Date: Wed, 9 Jul 2008 15:44:30 +0400 From: Dmitry To: "Ben Dooks" Subject: Re: [patch 3/4] MFD: Remove unnecessary fields if mfd_cell structure. Cc: linux-kernel@vger.kernel.org, linux-arm-kernel@lists.arm.linux.org.uk In-Reply-To: <20080709113818.GJ8517@trinity.fluff.org> MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Content-Disposition: inline References: <20080709104916.200210922@fluff.org> <20080709104932.905074060@fluff.org> <20080709111215.GL8489@trinity.fluff.org> <20080709113818.GJ8517@trinity.fluff.org> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 2008/7/9 Ben Dooks : > On Wed, Jul 09, 2008 at 03:16:47PM +0400, Dmitry wrote: >> 2008/7/9 Ben Dooks : >> > On Wed, Jul 09, 2008 at 03:09:12PM +0400, Dmitry wrote: >> >> 2008/7/9 Ben Dooks : >> >> > The enable,disable,suspend and resume entry in the struct mfd_cell >> >> > do not seem to be necessary as they should be handled by the >> >> > platform driver that the device created has bound to. >> >> >> >> NAK. It's used e.g. by the tmio-nand driver. These fields provide easy >> >> way to support >> >> enhanced power management, etc. >> > >> > What enhancements over the standard platform device model do you need? >> >> As an example of what we need, please check the tmio-nand driver. > > As posted below, the driver on the linux-mtd list does not use this, > and further more in [1] the method of getting to the the mfd_cell from > a given platform_device has gone which would be used by [2] if it > actually touched the mfd_cell information. It is used. Go, search for mfd_get_cell. And yes, it will require a minor change as discussed in the mfd thread yesterday. > > [1] http://lists.arm.linux.org.uk/lurker/message/20080708.153450.bb33046d.en.html > [2] http://lists.infradead.org/pipermail/linux-mtd/2008-June/022137.html > >> > >> >> > >> >> > Signed-off-by: Ben Dooks >> >> > >> >> > Index: linux-2.6.26-rc9-next20080709/include/linux/mfd/core.h >> >> > =================================================================== >> >> > --- linux-2.6.26-rc9-next20080709.orig/include/linux/mfd/core.h 2008-07-09 10:44:45.000000000 +0100 >> >> > +++ linux-2.6.26-rc9-next20080709/include/linux/mfd/core.h 2008-07-09 10:45:06.000000000 +0100 >> >> > @@ -23,12 +26,6 @@ >> >> > */ >> >> > struct mfd_cell { >> >> > const char *name; >> >> > - >> >> > - int (*enable)(struct platform_device *dev); >> >> > - int (*disable)(struct platform_device *dev); >> >> > - int (*suspend)(struct platform_device *dev); >> >> > - int (*resume)(struct platform_device *dev); >> >> > - >> >> > void *driver_data; /* driver-specific data */ >> >> > >> >> > /* >> >> > >> >> > -- >> >> > >> >> >> >> >> >> >> >> -- >> >> With best wishes >> >> Dmitry >> > >> > -- >> > -- >> > Ben >> > >> > Q: What's a light-year? >> > A: One-third less calories than a regular year. >> > >> > >> >> >> >> -- >> With best wishes >> Dmitry >> >> ------------------------------------------------------------------- >> List admin: http://lists.arm.linux.org.uk/mailman/listinfo/linux-arm-kernel >> FAQ: http://www.arm.linux.org.uk/mailinglists/faq.php >> Etiquette: http://www.arm.linux.org.uk/mailinglists/etiquette.php > > -- > -- > Ben > > Q: What's a light-year? > A: One-third less calories than a regular year. > > -- With best wishes Dmitry