From: Mike Galbraith <efault@gmx.de>
To: Thomas Gleixner <tglx@linutronix.de>,
linux-kernel@vger.kernel.org, linux-tip-commits@vger.kernel.org
Cc: Peter Zijlstra <peterz@infradead.org>, x86@kernel.org
Subject: Re: [tip: timers/core] hrtimer: Consolidate reprogramming code
Date: Thu, 12 Aug 2021 17:04:02 +0200 [thread overview]
Message-ID: <bc6b74396cd6b5a4eb32ff90bcc1cb059216e0f3.camel@gmx.de> (raw)
In-Reply-To: <877dgqivhy.ffs@tglx>
[-- Attachment #1: Type: text/plain, Size: 3086 bytes --]
On Thu, 2021-08-12 at 16:32 +0200, Thomas Gleixner wrote:
>
> Can you please test whether the below fixes it for you?
Yes, that boots.
> I have yet to find a machine which reproduces it as I really want to
> understand which particular part is causing this.
Config attached just in case.
> Thanks,
>
> tglx
> ---
> --- a/kernel/time/hrtimer.c
> +++ b/kernel/time/hrtimer.c
> @@ -652,24 +652,10 @@ static inline int hrtimer_hres_active(vo
> return __hrtimer_hres_active(this_cpu_ptr(&hrtimer_bases));
> }
>
> -static void
> -__hrtimer_reprogram(struct hrtimer_cpu_base *cpu_base, int skip_equal,
> - struct hrtimer *next_timer, ktime_t expires_next)
> +static void __hrtimer_reprogram(struct hrtimer_cpu_base *cpu_base,
> + struct hrtimer *next_timer,
> + ktime_t expires_next)
> {
> - /*
> - * If the hrtimer interrupt is running, then it will reevaluate
> the
> - * clock bases and reprogram the clock event device.
> - */
> - if (cpu_base->in_hrtirq)
> - return;
> -
> - if (expires_next > cpu_base->expires_next)
> - return;
> -
> - if (skip_equal && expires_next == cpu_base->expires_next)
> - return;
> -
> - cpu_base->next_timer = next_timer;
> cpu_base->expires_next = expires_next;
>
> /*
> @@ -707,8 +693,10 @@ hrtimer_force_reprogram(struct hrtimer_c
>
> expires_next = hrtimer_update_next_event(cpu_base);
>
> - __hrtimer_reprogram(cpu_base, skip_equal, cpu_base->next_timer,
> - expires_next);
> + if (skip_equal && expires_next == cpu_base->expires_next)
> + return;
> +
> + __hrtimer_reprogram(cpu_base, cpu_base->next_timer,
> expires_next);
> }
>
> /* High resolution timer related functions */
> @@ -863,7 +851,19 @@ static void hrtimer_reprogram(struct hrt
> if (base->cpu_base != cpu_base)
> return;
>
> - __hrtimer_reprogram(cpu_base, true, timer, expires);
> + if (expires >= cpu_base->expires_next)
> + return;
> +
> + /*
> + * If the hrtimer interrupt is running, then it will reevaluate
> the
> + * clock bases and reprogram the clock event device.
> + */
> + if (cpu_base->in_hrtirq)
> + return;
> +
> + cpu_base->next_timer = timer;
> +
> + __hrtimer_reprogram(cpu_base, timer, expires);
> }
>
> static bool update_needs_ipi(struct hrtimer_cpu_base *cpu_base,
[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 39362 bytes --]
next prev parent reply other threads:[~2021-08-12 15:04 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-13 13:39 [patch V2 00/10] hrtimer: Reprogramming and clock_was_set() overhaul Thomas Gleixner
2021-07-13 13:39 ` [patch V2 01/10] hrtimer: Avoid double reprogramming in __hrtimer_start_range_ns() Thomas Gleixner
2021-08-10 16:02 ` [tip: timers/core] " tip-bot2 for Thomas Gleixner
2021-07-13 13:39 ` [patch V2 02/10] hrtimer: Consolidate reprogramming code Thomas Gleixner
2021-08-10 16:02 ` [tip: timers/core] " tip-bot2 for Peter Zijlstra
2021-08-12 7:19 ` Mike Galbraith
2021-08-12 14:11 ` Thomas Gleixner
2021-08-12 14:32 ` Thomas Gleixner
2021-08-12 15:04 ` Mike Galbraith [this message]
2021-08-12 15:22 ` Thomas Gleixner
2021-08-12 15:31 ` Mike Galbraith
2021-08-12 16:58 ` Thomas Gleixner
2021-08-12 15:27 ` Mike Galbraith
2021-08-12 20:32 ` [PATCH] hrtimer: Unbreak hrtimer_force_reprogram() Thomas Gleixner
2021-08-12 20:40 ` [tip: timers/core] " tip-bot2 for Thomas Gleixner
2021-08-13 7:58 ` [PATCH] " Thomas Gleixner
2021-08-12 20:31 ` [PATCH] hrtimer: Use raw_cpu_ptr() in clock_was_set() Thomas Gleixner
2021-08-12 20:40 ` [tip: timers/core] " tip-bot2 for Thomas Gleixner
2021-08-13 6:42 ` [PATCH] " Marek Szyprowski
[not found] ` <CGME20210812130945eucas1p117fc1e90f31c8d9fd177932cd1a18512@eucas1p1.samsung.com>
2021-08-12 13:09 ` [patch V2 02/10] hrtimer: Consolidate reprogramming code Marek Szyprowski
2021-07-13 13:39 ` [patch V2 03/10] hrtimer: Ensure timerfd notification for HIGHRES=n Thomas Gleixner
2021-08-10 16:02 ` [tip: timers/core] " tip-bot2 for Thomas Gleixner
2021-07-13 13:39 ` [patch V2 04/10] hrtimer: Force clock_was_set() handling for the HIGHRES=n, NOHZ=y case Thomas Gleixner
2021-08-10 16:02 ` [tip: timers/core] " tip-bot2 for Thomas Gleixner
2021-07-13 13:39 ` [patch V2 05/10] timerfd: Provide timerfd_resume() Thomas Gleixner
2021-08-10 16:02 ` [tip: timers/core] " tip-bot2 for Thomas Gleixner
2021-07-13 13:39 ` [patch V2 06/10] timekeeping: Distangle resume and clock-was-set events Thomas Gleixner
2021-08-10 16:02 ` [tip: timers/core] " tip-bot2 for Thomas Gleixner
2021-07-13 13:39 ` [patch V2 07/10] time/timekeeping: Avoid invoking clock_was_set() twice Thomas Gleixner
2021-08-10 16:02 ` [tip: timers/core] " tip-bot2 for Thomas Gleixner
2021-07-13 13:39 ` [patch V2 08/10] hrtimer: Add bases argument to clock_was_set() Thomas Gleixner
2021-08-10 16:02 ` [tip: timers/core] " tip-bot2 for Thomas Gleixner
2021-07-13 13:39 ` [patch V2 09/10] hrtimer: Avoid unnecessary SMP function calls in clock_was_set() Thomas Gleixner
2021-08-10 16:02 ` [tip: timers/core] " tip-bot2 for Marcelo Tosatti
2021-07-13 13:39 ` [patch V2 10/10] hrtimer: Avoid more " Thomas Gleixner
2021-08-10 16:02 ` [tip: timers/core] " tip-bot2 for Thomas Gleixner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bc6b74396cd6b5a4eb32ff90bcc1cb059216e0f3.camel@gmx.de \
--to=efault@gmx.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tip-commits@vger.kernel.org \
--cc=peterz@infradead.org \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).