From: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
To: Yue Haibing <yuehaibing@huawei.com>,
liam.r.girdwood@linux.intel.com, yang.jie@linux.intel.com,
broonie@kernel.org, perex@perex.cz, tiwai@suse.com
Cc: linux-kernel@vger.kernel.org, alsa-devel@alsa-project.org
Subject: Re: [alsa-devel] [PATCH v2 -next] ASoC: Intel: Haswell: Remove set but not used variable 'stage_type'
Date: Thu, 18 Apr 2019 07:54:16 -0500 [thread overview]
Message-ID: <bc824d69-7afc-6acb-7251-57dbe6d4c3f1@linux.intel.com> (raw)
In-Reply-To: <20190418024848.39112-1-yuehaibing@huawei.com>
On 4/17/19 9:48 PM, Yue Haibing wrote:
> From: YueHaibing <yuehaibing@huawei.com>
>
> Fixes gcc '-Wunused-but-set-variable' warning:
>
> sound/soc/intel/haswell/sst-haswell-ipc.c: In function 'hsw_stream_message':
> sound/soc/intel/haswell/sst-haswell-ipc.c:669:29: warning: variable 'stage_type' set but not used [-Wunused-but-set-variable]
>
> It is never used since introduction in
> commit ba57f68235cf ("ASoC: Intel: create haswell folder and move haswell platform files in")
>
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
Acked-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Thanks!
> ---
> v2: also remove the variable declaration and the static inline mst_get_stage_type
> ---
> sound/soc/intel/haswell/sst-haswell-ipc.c | 8 +-------
> 1 file changed, 1 insertion(+), 7 deletions(-)
>
> diff --git a/sound/soc/intel/haswell/sst-haswell-ipc.c b/sound/soc/intel/haswell/sst-haswell-ipc.c
> index 31fcdf12..74acf9c 100644
> --- a/sound/soc/intel/haswell/sst-haswell-ipc.c
> +++ b/sound/soc/intel/haswell/sst-haswell-ipc.c
> @@ -345,11 +345,6 @@ static inline u32 msg_get_stream_type(u32 msg)
> return (msg & IPC_STR_TYPE_MASK) >> IPC_STR_TYPE_SHIFT;
> }
>
> -static inline u32 msg_get_stage_type(u32 msg)
> -{
> - return (msg & IPC_STG_TYPE_MASK) >> IPC_STG_TYPE_SHIFT;
> -}
> -
> static inline u32 msg_get_stream_id(u32 msg)
> {
> return (msg & IPC_STR_ID_MASK) >> IPC_STR_ID_SHIFT;
> @@ -666,13 +661,12 @@ static int hsw_module_message(struct sst_hsw *hsw, u32 header)
>
> static int hsw_stream_message(struct sst_hsw *hsw, u32 header)
> {
> - u32 stream_msg, stream_id, stage_type;
> + u32 stream_msg, stream_id;
> struct sst_hsw_stream *stream;
> int handled = 0;
>
> stream_msg = msg_get_stream_type(header);
> stream_id = msg_get_stream_id(header);
> - stage_type = msg_get_stage_type(header);
>
> stream = get_stream_by_id(hsw, stream_id);
> if (stream == NULL)
>
next prev parent reply other threads:[~2019-04-18 12:54 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-17 15:11 [PATCH -next] ASoC: Intel: Haswell: Remove set but not used variable 'stage_type' Yue Haibing
2019-04-17 17:41 ` [alsa-devel] " Pierre-Louis Bossart
2019-04-18 1:25 ` YueHaibing
2019-04-18 2:48 ` [PATCH v2 " Yue Haibing
2019-04-18 12:54 ` Pierre-Louis Bossart [this message]
2019-04-19 16:14 ` Applied "ASoC: Intel: Haswell: Remove set but not used variable 'stage_type'" to the asoc tree Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bc824d69-7afc-6acb-7251-57dbe6d4c3f1@linux.intel.com \
--to=pierre-louis.bossart@linux.intel.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=liam.r.girdwood@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=perex@perex.cz \
--cc=tiwai@suse.com \
--cc=yang.jie@linux.intel.com \
--cc=yuehaibing@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).