From: Matheus Castello <matheus@castello.eng.br>
To: Rob Herring <robh@kernel.org>
Cc: sre@kernel.org, krzk@kernel.org, mark.rutland@arm.com,
cw00.choi@samsung.com, b.zolnierkie@samsung.com,
lee.jones@linaro.org, linux-pm@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 2/4] dt-bindings: power: supply: Max17040: Add low level SOC alert threshold
Date: Sun, 26 May 2019 20:13:31 -0300 [thread overview]
Message-ID: <bca953be-8e9e-b20c-abeb-42f3615c7ddb@castello.eng.br> (raw)
In-Reply-To: <20190429221353.GA25837@bogus>
On 4/29/19 7:13 PM, Rob Herring wrote:
> On Sun, Apr 14, 2019 at 10:26:33PM -0300, Matheus Castello wrote:
>> For configure low level state of charge threshold alert signaled from
>> max17040 we add "maxim,alert-soc-level" property.
>>
>> Signed-off-by: Matheus Castello <matheus@castello.eng.br>
>> ---
>> .../power/supply/max17040_battery.txt | 24 +++++++++++++++++++
>> 1 file changed, 24 insertions(+)
>> create mode 100644 Documentation/devicetree/bindings/power/supply/max17040_battery.txt
>>
>> diff --git a/Documentation/devicetree/bindings/power/supply/max17040_battery.txt b/Documentation/devicetree/bindings/power/supply/max17040_battery.txt
>> new file mode 100644
>> index 000000000000..9b2cc67d556f
>> --- /dev/null
>> +++ b/Documentation/devicetree/bindings/power/supply/max17040_battery.txt
>> @@ -0,0 +1,24 @@
>> +max17040_battery
>> +~~~~~~~~~~~~~~~~
>> +
>> +Required properties :
>> + - compatible : "maxim,max17040" or "maxim,max77836-battery"
>
> This is really a charger, not a battery.
>
max17040 is a fuel gauge, max77836 MUIC has it integrated. Because of
this we use it in the compatible list.
>> +
>> +Optional properties :
>> +- maxim,alert-soc-level : The alert threshold that sets the state of
>> + charge level where an interrupt is generated.
>> + Can be configured from 1 up to 32. If skipped
>> + the power up default value of 4 will be used.
>
> Units? This is a low or high alert? Does a common property make sense
> here?
>
It is a low level alert. I will change the name of the property to
"maxim,alert-low-soc-level" to make this clear and I will put the
percent unit in the description.
I do not find any common property that I can use here, if I am wrong let
me know.
>> +- interrupt-parent : The GPIO bank from the interrupt line.
>
> Drop this. interrupt-parent is implied.
Ok, I will do.
>
>> +- interrupts : Interrupt line see Documentation/devicetree/
>> + bindings/interrupt-controller/interrupts.txt
>> +
>> +Example:
>> +
>> + battery-charger@36 {
>> + compatible = "maxim,max17040";
>> + reg = <0x36>;
>> + maxim,alert-soc-level = <10>;
>> + interrupt-parent = <&gpio7>;
>> + interrupts = <2 IRQ_TYPE_EDGE_FALLING>;
>
> Usually there are battery properties that need to be described too...
>
I will fix this for "battery-fuel-gauge@36". I will also add the
description for wake-source as optional property.
Thanks.
Best Regards,
Matheus Castello
>> + };
>> --
>> 2.17.0
>>
next prev parent reply other threads:[~2019-05-26 23:37 UTC|newest]
Thread overview: 71+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-23 4:08 [PATCH 0/4] power: supply: MAX17040: Add IRQ for low level and alert SOC changes Matheus Castello
2018-07-23 4:08 ` [PATCH 1/4] power: supply: max17040: Add IRQ handler for low SOC alert Matheus Castello
2018-07-25 10:27 ` Krzysztof Kozlowski
2018-07-23 4:08 ` [PATCH 2/4] power: supply: max17040: Config alert SOC low level threshold from FDT Matheus Castello
2018-07-25 10:42 ` Krzysztof Kozlowski
2018-07-23 4:08 ` [PATCH 3/4] dt-bindings: power: supply: Max17040: Add low level SOC alert threshold Matheus Castello
2018-07-25 10:45 ` Krzysztof Kozlowski
2018-07-23 4:08 ` [PATCH 4/4] power: supply: max17040: Send uevent in SOC changes Matheus Castello
2018-07-25 10:52 ` Krzysztof Kozlowski
2018-09-16 11:45 ` [PATCH 0/4] power: supply: MAX17040: Add IRQ for low level and alert " Sebastian Reichel
2018-09-17 11:32 ` Krzysztof Kozlowski
2018-09-18 3:45 ` Matheus Castello
2019-04-15 1:26 ` [PATCH v2 " Matheus Castello
2019-04-15 1:26 ` [PATCH v2 1/4] power: supply: max17040: Add IRQ handler for low SOC alert Matheus Castello
2019-04-15 7:10 ` Krzysztof Kozlowski
2019-04-19 18:12 ` Matheus Castello
2019-04-15 1:26 ` [PATCH v2 2/4] dt-bindings: power: supply: Max17040: Add low level SOC alert threshold Matheus Castello
2019-04-15 7:13 ` Krzysztof Kozlowski
2019-04-29 22:13 ` Rob Herring
2019-05-26 23:13 ` Matheus Castello [this message]
2019-04-15 1:26 ` [PATCH v2 3/4] power: supply: max17040: Config alert SOC low level threshold from FDT Matheus Castello
2019-04-15 7:27 ` Krzysztof Kozlowski
2019-04-15 1:26 ` [PATCH v2 4/4] power: supply: max17040: Send uevent in SOC changes Matheus Castello
2019-04-15 7:30 ` Krzysztof Kozlowski
2019-05-27 2:22 ` [PATCH v3 0/5] power: supply: MAX17040: Add IRQ for low level and alert " Matheus Castello
2019-05-27 2:22 ` [PATCH v3 1/5] power: supply: max17040: Add IRQ handler for low SOC alert Matheus Castello
2019-05-29 14:26 ` Krzysztof Kozlowski
2019-05-27 2:22 ` [PATCH v3 2/5] dt-bindings: power: supply: Max17040: Add low level SOC alert threshold Matheus Castello
2019-05-29 14:40 ` Krzysztof Kozlowski
2019-05-29 14:57 ` Krzysztof Kozlowski
2019-06-02 21:38 ` Matheus Castello
2019-06-05 12:04 ` Krzysztof Kozlowski
2019-05-27 2:22 ` [PATCH v3 3/5] power: supply: max17040: Config alert SOC low level threshold from FDT Matheus Castello
2019-05-29 14:46 ` Krzysztof Kozlowski
2019-06-02 22:26 ` Matheus Castello
2019-06-05 12:05 ` Krzysztof Kozlowski
2019-05-27 2:22 ` [PATCH v3 4/5] power: supply: max17040: Clear ALRT bit when the SOC are above threshold Matheus Castello
2019-05-29 14:54 ` Krzysztof Kozlowski
2019-05-27 2:22 ` [PATCH v3 5/5] power: supply: max17040: Send uevent in SOC and status change Matheus Castello
2019-05-29 15:00 ` Krzysztof Kozlowski
2019-10-31 18:41 ` [PATCH v4 0/4] power: supply: MAX17040: Add IRQ for low level and alert SOC changes Matheus Castello
2019-10-31 18:41 ` [PATCH v4 1/4] power: supply: max17040: Add IRQ handler for low SOC alert Matheus Castello
2019-11-01 15:08 ` Krzysztof Kozlowski
2019-10-31 18:41 ` [PATCH v4 2/4] dt-bindings: power: supply: Max17040: Add low level SOC alert threshold Matheus Castello
2019-11-01 15:10 ` Krzysztof Kozlowski
2019-11-05 1:58 ` Rob Herring
2019-11-05 5:42 ` [PATCH v5 0/5] power: supply: MAX17040: Add IRQ for low level and alert SOC changes Matheus Castello
2019-11-05 5:42 ` [PATCH v5 1/5] power: supply: max17040: Add IRQ handler for low SOC alert Matheus Castello
2019-11-05 5:42 ` [PATCH v5 2/5] dt-bindings: power: supply: Max17040: Add DT bindings for max17040 fuel gauge Matheus Castello
2019-11-05 5:42 ` [PATCH v5 3/5] devicetree: mfd: max14577: Add reference to max14040_battery.txt descriptions Matheus Castello
2019-11-05 5:42 ` [PATCH v5 4/5] power: supply: max17040: Config alert SOC low level threshold from FDT Matheus Castello
2019-11-05 9:59 ` Krzysztof Kozlowski
2019-11-07 3:17 ` [PATCH v6 0/5] power: supply: MAX17040: Add IRQ for low level and alert SOC changes Matheus Castello
2019-11-07 3:17 ` [PATCH v6 1/5] power: supply: max17040: Add IRQ handler for low SOC alert Matheus Castello
2019-11-07 3:17 ` [PATCH v6 2/5] dt-bindings: power: supply: Max17040: Add DT bindings for max17040 fuel gauge Matheus Castello
2019-11-14 0:53 ` Rob Herring
2019-11-07 3:17 ` [PATCH v6 3/5] devicetree: mfd: max14577: Add reference to max14040_battery.txt descriptions Matheus Castello
2019-11-11 10:09 ` Lee Jones
2019-11-14 0:54 ` Rob Herring
2019-11-07 3:17 ` [PATCH v6 4/5] power: supply: max17040: Config alert SOC low level threshold from FDT Matheus Castello
2019-11-07 3:17 ` [PATCH v6 5/5] power: supply: max17040: Send uevent in SOC and status change Matheus Castello
2019-11-11 9:59 ` [PATCH v6 0/5] power: supply: MAX17040: Add IRQ for low level and alert SOC changes Lee Jones
2019-11-05 5:42 ` [PATCH v5 5/5] power: supply: max17040: Send uevent in SOC and status change Matheus Castello
2019-10-31 18:41 ` [PATCH v4 3/4] power: supply: max17040: Config alert SOC low level threshold from FDT Matheus Castello
2019-11-01 15:27 ` Krzysztof Kozlowski
2019-11-01 16:52 ` Matheus Castello
2019-11-02 18:12 ` Matheus Castello
2019-11-04 11:04 ` Krzysztof Kozlowski
2019-11-04 10:59 ` Krzysztof Kozlowski
2019-10-31 18:41 ` [PATCH v4 4/4] power: supply: max17040: Send uevent in SOC and status change Matheus Castello
2019-11-01 15:30 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bca953be-8e9e-b20c-abeb-42f3615c7ddb@castello.eng.br \
--to=matheus@castello.eng.br \
--cc=b.zolnierkie@samsung.com \
--cc=cw00.choi@samsung.com \
--cc=devicetree@vger.kernel.org \
--cc=krzk@kernel.org \
--cc=lee.jones@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=robh@kernel.org \
--cc=sre@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).