From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2EC27CCA480 for ; Wed, 20 Jul 2022 16:55:35 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235644AbiGTQzd (ORCPT ); Wed, 20 Jul 2022 12:55:33 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54988 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235504AbiGTQzb (ORCPT ); Wed, 20 Jul 2022 12:55:31 -0400 Received: from mail-lf1-x12c.google.com (mail-lf1-x12c.google.com [IPv6:2a00:1450:4864:20::12c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A99BDBC84 for ; Wed, 20 Jul 2022 09:55:30 -0700 (PDT) Received: by mail-lf1-x12c.google.com with SMTP id t1so31167984lft.8 for ; Wed, 20 Jul 2022 09:55:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=ghsRIl9JuEUAT7RkLvrtAJh5nIX2+4oeY+8sAkTqUi8=; b=rrij9HiBkRbqiSHMRbuOYeDYl/1QDqdjMLDsMCllht89qyWj039D33oBZUzR62CBuK WdSRzgXyO41YyPlFU5drYbYssIzqcYVDxLSaBjArT9IX8nBPC5bOrphbtCbi1OHsZwRV ZpjYuDIhJbF9axDINZh6UiTHADnes0C+A4XibyzgKZ35/LoEpNphQlZh5SXgLvrt0A2C m2z9n52ly2xSKbbnUIQXocBNzuyi0/he/66ipoZrJ5fj7hRYLYMSzgz8IP07hyknjazv Ax/KB3y2KjPO1xHiJj0m/lGt6q3fCSEeIsAJEE5cm+B/NBsJQrxxN3bjkZlFwCac17Ss LN8A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=ghsRIl9JuEUAT7RkLvrtAJh5nIX2+4oeY+8sAkTqUi8=; b=p5WBC3HYKE9UV4mEXCERz6pp3UNFWFFyj3voNwL5FZCNrALFoR2H2NHetPfg6XW6Fi 3+XVWou5QsD7hCa7AWUo0fLZYh6OtVWmpSIznrFGnc8zrgBKPD9IRwHtwXY195MniZTR yQDdK3oUvq/9zHexAusOyaNjPl0jElvvbYFcxvQlVKuI62+KJjjVQ1W3ukzSPm3umjU9 ALP5RApXZWeFzjG6OQl83gh4jYt6p6BVOmpv1v/PKtoNadtt/j8AjDWYGCa5Ino4sRuq Df5bnXIR9hZYZnlNMlG/75Tp4RKcf+1sLOCFkR84uVwWw2csBmHPYOlsbVtk1G6S9RZT nenw== X-Gm-Message-State: AJIora+pzdw0+rjoxtcVuk9LuCIxsSr8OnabU358yRP6kj3I3qNB65BZ b+GlF6d/xHdEthRjZIIWBNlxlw== X-Google-Smtp-Source: AGRyM1vBII7bdjh9XymGuoIsbKTl3kq4QQ2UANvX7Rp6zTPRF7Oz9vGJ+aKWRqdUofgP5Ddq2mFV/Q== X-Received: by 2002:a05:6512:3d15:b0:489:d97d:8927 with SMTP id d21-20020a0565123d1500b00489d97d8927mr21395907lfv.80.1658336129030; Wed, 20 Jul 2022 09:55:29 -0700 (PDT) Received: from [192.168.115.193] (89-162-31-138.fiber.signal.no. [89.162.31.138]) by smtp.gmail.com with ESMTPSA id h24-20020a0565123c9800b004855e979abcsm3894307lfv.99.2022.07.20.09.55.27 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 20 Jul 2022 09:55:28 -0700 (PDT) Message-ID: Date: Wed, 20 Jul 2022 18:55:27 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH] arm64: dts: qcom: Add SKU6 for sc7180-trogdor-pazquel-lte-parade Content-Language: en-US To: Doug Anderson Cc: Yunlong Jia , LKML , Henry Sun , Bob Moragues , Andy Gross , Bjorn Andersson , Konrad Dybcio , Krzysztof Kozlowski , Rob Herring , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , linux-arm-msm References: <20220720025058.1.I5bfba8857ea0d43c747ecdc3a950875abd56927f@changeid> <7a04c9af-0ccb-7711-249f-73908fe7ec36@linaro.org> From: Krzysztof Kozlowski In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 20/07/2022 17:13, Doug Anderson wrote: > Hi, > > On Tue, Jul 19, 2022 at 11:10 PM Krzysztof Kozlowski > wrote: >> >> On 20/07/2022 04:51, Yunlong Jia wrote: >>> SKU6 is LTE(w/o eSIM)+WIFI+Parade >>> >>> Signed-off-by: Yunlong Jia >>> --- >>> >>> arch/arm64/boot/dts/qcom/sc7180-trogdor-pazquel-lte-parade.dts | 2 +- >>> 1 file changed, 1 insertion(+), 1 deletion(-) >>> >>> diff --git a/arch/arm64/boot/dts/qcom/sc7180-trogdor-pazquel-lte-parade.dts b/arch/arm64/boot/dts/qcom/sc7180-trogdor-pazquel-lte-parade.dts >>> index 764c451c1a857..4649eaec6318d 100644 >>> --- a/arch/arm64/boot/dts/qcom/sc7180-trogdor-pazquel-lte-parade.dts >>> +++ b/arch/arm64/boot/dts/qcom/sc7180-trogdor-pazquel-lte-parade.dts >>> @@ -14,7 +14,7 @@ >>> >>> / { >>> model = "Google Pazquel (Parade,LTE)"; >>> - compatible = "google,pazquel-sku4", "qcom,sc7180"; >>> + compatible = "google,pazquel-sku4", "google,pazquel-sku6", "qcom,sc7180"; >> >> You miss binding change and sku6 should be rather added before sku4 as >> it is more specific, isn't it? > > Just to close the loop: the order doesn't matter at all. Neither sku4 > nor sku6 is "more specific". One has the eSIM stuffed and one doesn't. Thanks Doug. Then the commit description could be improved, so reviewer does not have to ask such questions. Otherwise it is confusing to see a board which says it is for LTE version but it is actually not for LTE version (or whatever combination you have). Best regards, Krzysztof