From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.6 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B7B95C3524D for ; Mon, 3 Feb 2020 07:16:31 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 8B1FE20661 for ; Mon, 3 Feb 2020 07:16:31 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="key not found in DNS" (0-bit key) header.d=mg.codeaurora.org header.i=@mg.codeaurora.org header.b="iYXohi9s" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727352AbgBCHQa (ORCPT ); Mon, 3 Feb 2020 02:16:30 -0500 Received: from mail25.static.mailgun.info ([104.130.122.25]:29978 "EHLO mail25.static.mailgun.info" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725973AbgBCHQa (ORCPT ); Mon, 3 Feb 2020 02:16:30 -0500 DKIM-Signature: a=rsa-sha256; v=1; c=relaxed/relaxed; d=mg.codeaurora.org; q=dns/txt; s=smtp; t=1580714189; h=Message-ID: References: In-Reply-To: Subject: Cc: To: From: Date: Content-Transfer-Encoding: Content-Type: MIME-Version: Sender; bh=jUeEF/Zuy5Iv2uD5XELfW5OO2/vfRduEY6ZeD7zd/Vc=; b=iYXohi9szRzXMJSru6EstvuO3ugHR6/9cbeaVpq/F+Nhy/dP1ela1t4RH//wbHQFVZfXvBy/ TGlOtuQxMefo8qlv6fEA3RtgqBztRGutqb6lNpkPdaufXLuM53XQDBZfX3TX42Kcqz6iwVtl wB3pGhxHGFZQTrMZC/jMrCY0zEA= X-Mailgun-Sending-Ip: 104.130.122.25 X-Mailgun-Sid: WyI0MWYwYSIsICJsaW51eC1rZXJuZWxAdmdlci5rZXJuZWwub3JnIiwgImJlOWU0YSJd Received: from smtp.codeaurora.org (ec2-35-166-182-171.us-west-2.compute.amazonaws.com [35.166.182.171]) by mxa.mailgun.org with ESMTP id 5e37c8cd.7fcc923c9ae8-smtp-out-n03; Mon, 03 Feb 2020 07:16:29 -0000 (UTC) Received: by smtp.codeaurora.org (Postfix, from userid 1001) id 59490C447AA; Mon, 3 Feb 2020 07:16:27 +0000 (UTC) Received: from mail.codeaurora.org (localhost.localdomain [127.0.0.1]) (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) (Authenticated sender: cang) by smtp.codeaurora.org (Postfix) with ESMTPSA id B22F0C43383; Mon, 3 Feb 2020 07:16:26 +0000 (UTC) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Mon, 03 Feb 2020 15:16:26 +0800 From: Can Guo To: Bart Van Assche Cc: asutoshd@codeaurora.org, nguyenb@codeaurora.org, hongwus@codeaurora.org, rnayak@codeaurora.org, linux-scsi@vger.kernel.org, kernel-team@android.com, saravanak@google.com, salyzyn@google.com, Alim Akhtar , Avri Altman , Pedro Sousa , "James E.J. Bottomley" , "Martin K. Petersen" , Tomas Winkler , Stanley Chu , Venkat Gopalakrishnan , open list Subject: Re: [PATCH v4 6/8] scsi: ufs: Add dev ref clock gating wait time support In-Reply-To: References: <1579764349-15578-1-git-send-email-cang@codeaurora.org> <1579764349-15578-7-git-send-email-cang@codeaurora.org> Message-ID: X-Sender: cang@codeaurora.org User-Agent: Roundcube Webmail/1.3.9 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2020-01-26 11:34, Bart Van Assche wrote: > On 2020-01-22 23:25, Can Guo wrote: >> + /* getting Specification Version in big endian format */ >> + hba->dev_info.spec_version = desc_buf[DEVICE_DESC_PARAM_SPEC_VER] << >> 8 | >> + desc_buf[DEVICE_DESC_PARAM_SPEC_VER + 1]; > > Please use get_unaligned_be16() instead of open-coding it. > > Thanks, > > Bart. I am just keeping symmetry with the other device descriptors, for example w_manufacturer_id. Thanks, Can Guo.