From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Arnd Bergmann <arnd@arndb.de>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Jeremy Kerr <jk@ozlabs.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] fsi: ast: select GENERIC_ALLOCATOR
Date: Tue, 14 Aug 2018 10:41:23 +1000 [thread overview]
Message-ID: <bcc8541923f57f534c609d7e00335baa29b00a10.camel@kernel.crashing.org> (raw)
In-Reply-To: <20180813223733.991653-1-arnd@arndb.de>
On Tue, 2018-08-14 at 00:37 +0200, Arnd Bergmann wrote:
> In randconfig builds without CONFIG_GENERIC_ALLOCATOR, this driver
> fails to link:
>
> ERROR: "gen_pool_alloc_algo" [drivers/fsi/fsi-master-ast-cf.ko] undefined!
> ERROR: "gen_pool_fixed_alloc" [drivers/fsi/fsi-master-ast-cf.ko] undefined!
> ERROR: "of_gen_pool_get" [drivers/fsi/fsi-master-ast-cf.ko] undefined!
> ERROR: "gen_pool_free" [drivers/fsi/fsi-master-ast-cf.ko] undefined!
>
> Select the dependency as all other users do.
>
> Fixes: 6a794a27daca ("fsi: master-ast-cf: Add new FSI master using Aspeed ColdFire")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
Thanks, I'll pick it up and send to Greg with a slightly different
subject
Cheers,
Ben.
> drivers/fsi/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/fsi/Kconfig b/drivers/fsi/Kconfig
> index af3a20dd5aa4..99c99a5d57fe 100644
> --- a/drivers/fsi/Kconfig
> +++ b/drivers/fsi/Kconfig
> @@ -46,6 +46,7 @@ config FSI_MASTER_AST_CF
> tristate "FSI master based on Aspeed ColdFire coprocessor"
> depends on GPIOLIB
> depends on GPIO_ASPEED
> + select GENERIC_ALLOCATOR
> ---help---
> This option enables a FSI master using the AST2400 and AST2500 GPIO
> lines driven by the internal ColdFire coprocessor. This requires
prev parent reply other threads:[~2018-08-14 0:41 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-13 22:37 [PATCH] fsi: ast: select GENERIC_ALLOCATOR Arnd Bergmann
2018-08-14 0:41 ` Benjamin Herrenschmidt [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bcc8541923f57f534c609d7e00335baa29b00a10.camel@kernel.crashing.org \
--to=benh@kernel.crashing.org \
--cc=arnd@arndb.de \
--cc=gregkh@linuxfoundation.org \
--cc=jk@ozlabs.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).