From: "Christian König" <deathsimple@vodafone.de>
To: Andy Shevchenko <andy.shevchenko@gmail.com>
Cc: helgaas@kernel.org,
"linux-pci@vger.kernel.org" <linux-pci@vger.kernel.org>,
dri-devel@lists.freedesktop.org,
Platform Driver <platform-driver-x86@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/4] PCI: add resizeable BAR infrastructure v4
Date: Tue, 2 May 2017 16:56:55 +0200 [thread overview]
Message-ID: <bd126097-1aa4-eeb0-39fd-2e8820b448c5@vodafone.de> (raw)
In-Reply-To: <CAHp75VfJKkFTXbia=CiZapriEg6ObUh=js6cKJv3xe=2DBHbqA@mail.gmail.com>
Am 26.04.2017 um 18:45 schrieb Andy Shevchenko:
> [SNIP]
>> -#define PCI_REBAR_CTRL_NBAR_MASK (7 << 5) /* mask for # bars */
>> -#define PCI_REBAR_CTRL_NBAR_SHIFT 5 /* shift for # bars */
>> +#define PCI_REBAR_CTRL_NBAR_MASK (7 << 5) /* mask for # BARs */
>> +#define PCI_REBAR_CTRL_NBAR_SHIFT 5 /* shift for # BARs */
> I understand why, but I dunno it worth to do.
Bjorn suggested that. Either way is fine with me, but he needs to stick
his signed-of-by on it when pushing it upstream. So his opinion usually
wins.
All other comments will be integrated in the next version of the patch.
Thanks for the review,
Christian.
next prev parent reply other threads:[~2017-05-02 14:57 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-25 13:19 Resizeable PCI BAR support V4 Christian König
2017-04-25 13:19 ` [PATCH 1/4] PCI: add resizeable BAR infrastructure v4 Christian König
2017-04-25 15:00 ` Alex Deucher
2017-04-26 16:45 ` Andy Shevchenko
2017-05-02 14:56 ` Christian König [this message]
2017-04-25 13:19 ` [PATCH 2/4] PCI: add functionality for resizing resources v3 Christian König
2017-04-26 17:00 ` Andy Shevchenko
2017-05-02 15:51 ` Christian König
2017-05-02 20:27 ` Andy Shevchenko
2017-05-04 9:23 ` Christian König
2017-05-04 10:15 ` Andy Shevchenko
2017-05-04 16:44 ` Andy Shevchenko
2017-04-25 13:19 ` [PATCH 3/4] x86/PCI: Enable a 64bit BAR on AMD Family 15h (Models 30h-3fh) Processors v2 Christian König
2017-04-25 15:00 ` Alex Deucher
2017-04-26 17:18 ` Andy Shevchenko
2017-04-25 13:19 ` [PATCH 4/4] drm/amdgpu: resize VRAM BAR for CPU access v2 Christian König
2017-04-25 14:34 ` Alex Deucher
2017-04-25 15:09 ` Christian König
2017-04-25 15:14 ` Alex Deucher
2017-04-25 16:22 ` Christian König
2017-04-25 16:29 ` Alex Deucher
2017-04-25 14:25 ` Resizeable PCI BAR support V4 Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bd126097-1aa4-eeb0-39fd-2e8820b448c5@vodafone.de \
--to=deathsimple@vodafone.de \
--cc=andy.shevchenko@gmail.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=helgaas@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=platform-driver-x86@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).