From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1756177AbcIOUSP (ORCPT <rfc822;w@1wt.eu>);
        Thu, 15 Sep 2016 16:18:15 -0400
Received: from mout.web.de ([212.227.15.3]:56114 "EHLO mout.web.de"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1754559AbcIOUSH (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Thu, 15 Sep 2016 16:18:07 -0400
Subject: Re: clk/Renesas-MSTP: Delete an error message for a failed memory
 allocation
To: Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
        Geert Uytterhoeven <geert@linux-m68k.org>
References: <566ABCD9.1060404@users.sourceforge.net>
 <04cf79a5-df91-d8c2-83b2-ad9e9130ee7a@users.sourceforge.net>
 <CAMuHMdVtvg99JY=_+Wj7jpd82=5rKDKOVxg0TYW3wUQsUQzAOA@mail.gmail.com>
 <2927869.3rNkSDiBcX@avalon>
Cc: linux-clk <linux-clk@vger.kernel.org>,
        Geert Uytterhoeven <geert+renesas@glider.be>,
        Michael Turquette <mturquette@baylibre.com>,
        Simon Horman <horms+renesas@verge.net.au>,
        Stephen Boyd <sboyd@codeaurora.org>,
        Ulf Hansson <ulf.hansson@linaro.org>,
        LKML <linux-kernel@vger.kernel.org>,
        "kernel-janitors@vger.kernel.org" <kernel-janitors@vger.kernel.org>,
        Julia Lawall <julia.lawall@lip6.fr>, Wolfram Sang <wsa@the-dreams.de>
From: SF Markus Elfring <elfring@users.sourceforge.net>
Message-ID: <bd139d45-f7c1-ac79-6b38-93b1eb1f3e9a@users.sourceforge.net>
Date: Thu, 15 Sep 2016 22:17:41 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101
 Thunderbird/45.3.0
MIME-Version: 1.0
In-Reply-To: <2927869.3rNkSDiBcX@avalon>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
X-Provags-ID: V03:K0:mT4IBEaYBHxydgivEaJPxd1HtM5iUnr80JYsjirMMVLtx3xcv7e
 SbFSXtc9kWsuVYWdMDr2nrDAf3HKkadJsTkEYWrX1U0gAnsYxSBI2t5Wa19XX+sy7ke/MC+
 r93/OzktSL90KBFymhDagS2aKhGyrywrN7AYFTjbWzp4TkcOBB7BnchsKGp81MzHpcFyxg3
 m/iN179zYrxJc0NfkjQ2w==
X-UI-Out-Filterresults: notjunk:1;V01:K0:xg4zpCjprWE=:HltLSPgYSF8WOTH1Tf6FVA
 4+h1H0c54ZWqTPYchHCGggwjOA+g8B13HsNk3FfpIj03kqDVCfqCx1PJWI+tJ09iX0gQmPGyd
 jH/b8yPMFsJiz0qQll/P9ssquViaHJCCgMj4ACtMjPWDwNwXVV5zWZZALVr5i3ieNMydkq2h7
 62VfrEGVtLX8R6egTEWtM3OVs5x+iWqI+rh/1EbPKBB/9CQRYE028TxGOs6CoQIqpVHvLmHKa
 fTHNc4SMu40nJOmIsUkAdPgzUs3BmssNOQeHLLkHX1ktpa8Kvom9tLHHfsAdVrLbw5gnlc+y7
 D6Ib2oaqVbFr1g9/jd0VaAtx0tV5RuFsZriLTIZiEdRVXd0jg6jOiOZsnPHiVO0cVH0Vm/BO5
 a+B7nFW0qjlCTEKr5QOxDDDKFAjw52I9L697SjAqHS6NbcIw6KlbBucIuSyQIL7F7mJ3NZgdI
 R2HBNWXFmh75JqfMl/3lLGCkn7t5MjHirhac+kr/zDFc3FBkMA8VKalHY+ybo7xjNy59ODehR
 H4a+liAXBFhOL69h77KmDZj8+x69rNp7ch8Y5hTZoq9cJ5JP3RK6sGFYiMrf9dv+soRBgSNgo
 u0uQH+ZvuaJzlyxufi0Kvw90HgFWZ0tjDxADd6sKtcHKTgKCcxMmECr7uS+N20qIVrIS0Xuvb
 IWs609S5LH2W+13xbIRO2fJFVp9w/X+qd00td+TLRpvIyW2KgCi1gNTdUoJ8mrh3kG9d7CcAl
 bkdenWViBZB2SwaOFoDwzjryQnlIaz7aWfPGJvWuupxdvPN6HHbjUWmGqB6HOSx4wThbFdOAf
 rkZCOmZ
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

>>> Omit an extra message for a memory allocation failure in this function.
>>>
>>> Link:
>>> http://events.linuxfoundation.org/sites/events/files/slides/LCJ16-Refacto
>>> r_Strings-WSang_0.pdf
>>>
>>> Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
>>
>> Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
> 
> There are two other memory allocation failures printed by drivers in the same 
> directory that, you'll get my ack

Does this kind of feedback express a general acceptance for the deletion
of similar error messages?


> if you extend this patch to remove the three messages in one go.

Does this wish influence the handling of suggested changes for the source file
"drivers/clk/renesas/clk-mstp.c" anyhow?
https://patchwork.kernel.org/patch/9332363/

Regards,
Markus