From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751854AbdJTBvR (ORCPT ); Thu, 19 Oct 2017 21:51:17 -0400 Received: from regular1.263xmail.com ([211.150.99.131]:43976 "EHLO regular1.263xmail.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751709AbdJTBvQ (ORCPT ); Thu, 19 Oct 2017 21:51:16 -0400 X-263anti-spam: KSV:0; X-MAIL-GRAY: 0 X-MAIL-DELIVERY: 1 X-KSVirus-check: 0 X-ABS-CHECKED: 4 X-RL-SENDER: mark.yao@rock-chips.com X-FST-TO: linux-arm-kernel@lists.infradead.org X-SENDER-IP: 103.29.142.67 X-LOGIN-NAME: mark.yao@rock-chips.com X-UNIQUE-TAG: X-ATTACHMENT-NUM: 0 X-DNS-TYPE: 0 Subject: Re: [PATCH v6 10/10] drm/rockchip: dw_hdmi: Fix error handling path To: Jeffy Chen , linux-kernel@vger.kernel.org Cc: briannorris@chromium.org, seanpaul@chromium.org, dianders@chromium.org, heiko@sntech.de, tfiga@chromium.org, dri-devel@lists.freedesktop.org, linux-rockchip@lists.infradead.org, David Airlie , linux-arm-kernel@lists.infradead.org References: <20171019034812.13768-1-jeffy.chen@rock-chips.com> <20171019034812.13768-11-jeffy.chen@rock-chips.com> From: Mark yao Message-ID: Date: Fri, 20 Oct 2017 09:51:16 +0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 MIME-Version: 1.0 In-Reply-To: <20171019034812.13768-11-jeffy.chen@rock-chips.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-US Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2017年10月19日 11:48, Jeffy Chen wrote: > Add missing clk_disable_unprepare() in bind()'s error handling path and > unbind(). > > Also inline clk_prepare_enable() with bind(). > > Fixes: 12b9f204e804 ("drm: bridge/dw_hdmi: add rockchip rk3288 support") > Signed-off-by: Jeffy Chen Looks good for me Acked-by: Mark Yao Mark