From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.3 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E6635C47087 for ; Fri, 28 May 2021 08:37:21 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id C2A5061184 for ; Fri, 28 May 2021 08:37:21 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235396AbhE1Iiy (ORCPT ); Fri, 28 May 2021 04:38:54 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38616 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232481AbhE1Iit (ORCPT ); Fri, 28 May 2021 04:38:49 -0400 Received: from mail-wr1-x42e.google.com (mail-wr1-x42e.google.com [IPv6:2a00:1450:4864:20::42e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8725AC061574 for ; Fri, 28 May 2021 01:37:14 -0700 (PDT) Received: by mail-wr1-x42e.google.com with SMTP id n4so2460718wrw.3 for ; Fri, 28 May 2021 01:37:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=JIRtjIzGskNvRkjqhrSGu/TOKcOeVjAntp6g2x55agM=; b=eCxTTDpQelaF5VKo9Z6PrNKAhcprFauifycnFSy9xh8HbD4gtY1Sx/zf0hx5omPUss 8SPVxKrdK9skGTnLhR9JZvM2fIaJpiSzL3T3HMJmXo/c7I899Wnw6cq2A12lgw7A6LUq HCZ7dnH7fxY9OtLhhhTKz/bS48DgPJRAHtpyMxDcBOq6jnd3mIXKFMQMWGD/A94G1Xe8 emtBsERU2sR2W3YP4Z1REDHa+f6WM8kRwZVz4aY7g1e9Ic0SQal4TV65F2FM1oBG8wMJ ZHjCCzJa7aa86N0H6iI2xafaUIh6P7ylj3eYmb8CiqrxT11GlmVFdmWhs9yf2gM/1ZF4 g7TA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=JIRtjIzGskNvRkjqhrSGu/TOKcOeVjAntp6g2x55agM=; b=BnsNYCCCPk9cj+oRNT8FKwfVy1TKThcO9yvXSqF1/KDGg4pSjsQMb2+Dqnjv+CGrAM HNUirMGX+Qo4r++RHbC0L41kvodYSLwyJmxb8JdHMl8oK8AP0nZf1iiVyQ35B9l4acv3 rFqUTgwxXetdsRQ+5v5niSVvAzHBQYGnARvhmj0vyMXc5N65SbHlwwsiiHQwJMU7LOM3 p5tk++bS+tCU63PzePxLP4Yi3SFmp0zcupOKOqLnf1642LPqId3wS1GFZrVXn2gveVjl ku3Txk7rlgVrWxpXC1UbDhhvDDQkzoj3ybjIk10DbPDTZ1/DXW4QDSrqEAsPCij1zsFs +SKw== X-Gm-Message-State: AOAM5308P3eSImxyj23B3azLBCkCncUeJpLdxq7P4zOLb74Fdq8xxYmo iZ9qxd69eXYJZ2XGGOSFOCLfAw== X-Google-Smtp-Source: ABdhPJw5NKRu7nGRD7H482yIuy9oXYSyXuPAHcI//JL1z90goZosB5wAFGeCCxbxaIjvpuPgVRZLPA== X-Received: by 2002:a05:6000:cb:: with SMTP id q11mr7399883wrx.13.1622191033222; Fri, 28 May 2021 01:37:13 -0700 (PDT) Received: from [192.168.86.34] (cpc86377-aztw32-2-0-cust226.18-1.cable.virginm.net. [92.233.226.227]) by smtp.googlemail.com with ESMTPSA id 11sm6110413wmo.24.2021.05.28.01.37.11 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Fri, 28 May 2021 01:37:12 -0700 (PDT) Subject: Re: [PATCH 4/5] ASoC: qcom: q6asm-dai: Constify static struct snd_compress_ops To: Rikard Falkeborn , Liam Girdwood , Mark Brown Cc: Jaroslav Kysela , Takashi Iwai , alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org, Banajit Goswami References: <20210526231013.46530-1-rikard.falkeborn@gmail.com> <20210526231013.46530-5-rikard.falkeborn@gmail.com> From: Srinivas Kandagatla Message-ID: Date: Fri, 28 May 2021 09:37:11 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 MIME-Version: 1.0 In-Reply-To: <20210526231013.46530-5-rikard.falkeborn@gmail.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 27/05/2021 00:10, Rikard Falkeborn wrote: > The snd_compress_ops structs are only stored in the compress_ops field > of a snd_soc_component_driver struct, so make it const to allow the > compiler to put it in read-only memory. > > Signed-off-by: Rikard Falkeborn Reviewed-by: Srinivas Kandagatla > --- > sound/soc/qcom/qdsp6/q6asm-dai.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/sound/soc/qcom/qdsp6/q6asm-dai.c b/sound/soc/qcom/qdsp6/q6asm-dai.c > index 9766725c2916..5ff56a735419 100644 > --- a/sound/soc/qcom/qdsp6/q6asm-dai.c > +++ b/sound/soc/qcom/qdsp6/q6asm-dai.c > @@ -1169,7 +1169,7 @@ static int q6asm_dai_compr_get_codec_caps(struct snd_soc_component *component, > return 0; > } > > -static struct snd_compress_ops q6asm_dai_compress_ops = { > +static const struct snd_compress_ops q6asm_dai_compress_ops = { > .open = q6asm_dai_compr_open, > .free = q6asm_dai_compr_free, > .set_params = q6asm_dai_compr_set_params, >