From: Randy Dunlap <rdunlap@infradead.org>
To: Masahiro Yamada <masahiroy@kernel.org>, linux-kbuild@vger.kernel.org
Cc: Mauro Carvalho Chehab <mchehab@kernel.org>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 06/11] kconfig: qconf: allow to edit "int", "hex", "string" menus in-place
Date: Sat, 29 Aug 2020 21:54:20 -0700 [thread overview]
Message-ID: <bd8696df-72b7-fb92-d53a-edff715fe5a0@infradead.org> (raw)
In-Reply-To: <20200829081417.725978-6-masahiroy@kernel.org>
On 8/29/20 1:14 AM, Masahiro Yamada wrote:
> Previously, when you double-clicked the "int", "hex", or "string" menus,
> a line-edit gadget showed up to allow you to input the value, which
> looked clumsy.
>
> Also, it was buggy; the editor opened even if the config option was not
> editable. For example, just try to double-click CC_VERSION_TEXT, which
> has no prompt.
>
> This commit sub-classes QStyleItemDelegate to allow users to edit
> "int", "hex", "string" menus in-place. Just double-click (or press
> the F2 key) in the data column. Then, an editor widget is placed on
> top of the item view.
The F2 key doesn't work for me. I guess that's a desktop environment
issue (I am using Xfce).
> The two methods are overridden:
>
> createEditor - process only when the data column is being accessed
> and the menu is visible. Otherwise, return nullptr to disallow editing.
>
> setModelData - take the new data from the editor, and set it to the
> addressed symbol. If it was successful, update all the list windows.
> Otherwise, (the reason for the failure is possibly the input data was
> out of range), set the old value back to the editor.
>
> Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
> ---
>
> scripts/kconfig/qconf.cc | 93 ++++++++++++++++++++++++++++++++--------
> scripts/kconfig/qconf.h | 15 +++++++
> 2 files changed, 91 insertions(+), 17 deletions(-)
>
--
~Randy
next prev parent reply other threads:[~2020-08-30 4:54 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-29 8:14 [PATCH 01/11] kconfig: qconf: reformat the intro message Masahiro Yamada
2020-08-29 8:14 ` [PATCH 02/11] kconfig: qconf: update the intro message to match to the current code Masahiro Yamada
2020-08-30 4:58 ` Randy Dunlap
2020-08-29 8:14 ` [PATCH 03/11] kconfig: qconf: remove unused ConfigItem::okRename() Masahiro Yamada
2020-08-29 8:14 ` [PATCH 04/11] kconfig: qconf: move ConfigView::updateList(All) to ConfigList class Masahiro Yamada
2020-08-29 8:14 ` [PATCH 05/11] kconfig: qconf: show data column all the time Masahiro Yamada
2020-08-30 4:54 ` Randy Dunlap
2020-08-30 9:59 ` Masahiro Yamada
2020-08-29 8:14 ` [PATCH 06/11] kconfig: qconf: allow to edit "int", "hex", "string" menus in-place Masahiro Yamada
2020-08-30 4:54 ` Randy Dunlap [this message]
2020-08-30 10:01 ` Masahiro Yamada
2020-08-29 8:14 ` [PATCH 07/11] kconfig: qconf: remove ConfigLineEdit class Masahiro Yamada
2020-08-29 8:14 ` [PATCH 08/11] kconfig: qconf: move setShowName/Range() to ConfigList from ConfigView Masahiro Yamada
2020-08-29 8:14 ` [PATCH 09/11] kconfig: qconf: remove ConfigView class Masahiro Yamada
2020-08-29 8:14 ` [PATCH 10/11] kconfig: qconf: remove Y, M, N columns Masahiro Yamada
2020-08-29 8:14 ` [PATCH 11/11] kconfig: qconf: create QApplication after option checks Masahiro Yamada
2020-08-30 4:58 ` Randy Dunlap
2020-08-30 4:59 ` [PATCH 01/11] kconfig: qconf: reformat the intro message Randy Dunlap
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bd8696df-72b7-fb92-d53a-edff715fe5a0@infradead.org \
--to=rdunlap@infradead.org \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=masahiroy@kernel.org \
--cc=mchehab@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).