From: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
To: Mark Brown <broonie@kernel.org>
Cc: lgirdwood@gmail.com, perex@perex.cz, tiwai@suse.com,
pierre-louis.bossart@linux.intel.com,
alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org,
quic_srivasam@quicinc.com
Subject: Re: [PATCH 0/4] ASoC: qcom: fixes for Qualcomm codecs and q6apm
Date: Thu, 27 Jan 2022 10:20:09 +0000 [thread overview]
Message-ID: <bd870824-c171-85df-23d9-537a0c6e7036@linaro.org> (raw)
In-Reply-To: <YfFMsvoqrJLbw28Q@sirena.org.uk>
Thanks Mark,
On 26/01/2022 13:29, Mark Brown wrote:
> On Wed, Jan 26, 2022 at 11:35:45AM +0000, Srinivas Kandagatla wrote:
>
>> Some recent testing found few issues with wcd938x and lpass-tx codec drivers.
>> WCD938x was accessing array out of boundaries resulting in corruption and
>> system crashes along with not handling kcontrol put return values correctly
>> and rx-macro had incorrect sidetone registers offsets. One final fix in q6apm
>> to add a check if graph started before stopping it.
>
> You probably want to run the new mixer kselftest on these devices,
Yes, this is really good test indeed already found few issues with
existing mixers. I will test this on all the Qualcomm boards and get
back with some fixes.
I also made some improvements to the mixer test to not keep writing new
values to controls that have returned -EPERM in cases like where put
callback is NULL, In my case I have a Impedance value read only control
whose value range is MAX_INT.
--srini
> including with the patch I posted the other day testing out of bounds
> writes. It doesn't cover change notifications yet, you might want to
> set up some automation for that for whenever someone gets round to
> adding coverage.
next prev parent reply other threads:[~2022-01-27 10:20 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-26 11:35 [PATCH 0/4] ASoC: qcom: fixes for Qualcomm codecs and q6apm Srinivas Kandagatla
2022-01-26 11:35 ` [PATCH 1/4] ASoC: codecs: wcd938x: fix incorrect used of portid Srinivas Kandagatla
2022-01-26 11:35 ` [PATCH 2/4] ASoC: codecs: lpass-rx-macro: fix sidetone register offsets Srinivas Kandagatla
2022-01-26 11:35 ` [PATCH 3/4] ASoC: codecs: wcd938x: fix return value of mixer put function Srinivas Kandagatla
2022-01-26 11:35 ` [PATCH 4/4] ASoC: qdsp6: q6apm-dai: only stop graphs that are started Srinivas Kandagatla
2022-01-26 13:29 ` [PATCH 0/4] ASoC: qcom: fixes for Qualcomm codecs and q6apm Mark Brown
2022-01-27 10:20 ` Srinivas Kandagatla [this message]
2022-01-28 15:58 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bd870824-c171-85df-23d9-537a0c6e7036@linaro.org \
--to=srinivas.kandagatla@linaro.org \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=perex@perex.cz \
--cc=pierre-louis.bossart@linux.intel.com \
--cc=quic_srivasam@quicinc.com \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).