From: Hector Martin <marcan@marcan.st>
To: Guenter Roeck <linux@roeck-us.net>, Sven Peter <sven@svenpeter.dev>
Cc: Rob Herring <robh+dt@kernel.org>,
devicetree@vger.kernel.org,
Wim Van Sebroeck <wim@linux-watchdog.org>,
Alyssa Rosenzweig <alyssa@rosenzweig.io>,
linux-kernel@vger.kernel.org, linux-watchdog@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, Janne Grunau <j@jannau.net>,
Mark Kettenis <kettenis@openbsd.org>,
Rob Herring <robh@kernel.org>
Subject: Re: [PATCH v2 1/2] dt-bindings: watchdog: Add Apple Watchdog
Date: Tue, 7 Dec 2021 13:35:43 +0900 [thread overview]
Message-ID: <bd9a52eb-2aca-38a9-e183-2857960a4842@marcan.st> (raw)
In-Reply-To: <20211202144301.GA829000@roeck-us.net>
On 02/12/2021 23.43, Guenter Roeck wrote:
> On Tue, Nov 30, 2021 at 05:18:08PM +0100, Sven Peter wrote:
>> Apple SoCs come with a simple embedded watchdog. This watchdog is also
>> required in order to reset the SoC.
>>
>> Reviewed-by: Mark Kettenis <kettenis@openbsd.org>
>> Reviewed-by: Rob Herring <robh@kernel.org>
>> Signed-off-by: Sven Peter <sven@svenpeter.dev>
>
> Reviewed-by: Guenter Roeck <linux@roeck-us.net>
>
>> ---
>> v1 --> v2:
>> - add Mark's and Rob's r-b tags
>>
>> .../bindings/watchdog/apple,wdt.yaml | 52 +++++++++++++++++++
>> MAINTAINERS | 1 +
>> 2 files changed, 53 insertions(+)
>> create mode 100644 Documentation/devicetree/bindings/watchdog/apple,wdt.yaml
>>
>> diff --git a/Documentation/devicetree/bindings/watchdog/apple,wdt.yaml b/Documentation/devicetree/bindings/watchdog/apple,wdt.yaml
>> new file mode 100644
>> index 000000000000..e58c56a6fdf6
>> --- /dev/null
>> +++ b/Documentation/devicetree/bindings/watchdog/apple,wdt.yaml
>> @@ -0,0 +1,52 @@
>> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
>> +%YAML 1.2
>> +---
>> +$id: http://devicetree.org/schemas/watchdog/apple,wdt.yaml#
>> +$schema: http://devicetree.org/meta-schemas/core.yaml#
>> +
>> +title: Apple SoC Watchdog
>> +
>> +allOf:
>> + - $ref: "watchdog.yaml#"
>> +
>> +maintainers:
>> + - Sven Peter <sven@svenpeter.dev>
>> +
>> +properties:
>> + compatible:
>> + items:
>> + - enum:
>> + - apple,t8103-wdt
>> + - apple,t6000-wdt
>> + - const: apple,wdt
>> +
>> + reg:
>> + maxItems: 1
>> +
>> + clocks:
>> + maxItems: 1
>> +
>> + interrupts:
>> + maxItems: 1
>> +
>> +required:
>> + - compatible
>> + - reg
>> + - clocks
>> + - interrupts
>> +
>> +unevaluatedProperties: false
>> +
>> +examples:
>> + - |
>> + #include <dt-bindings/interrupt-controller/apple-aic.h>
>> + #include <dt-bindings/interrupt-controller/irq.h>
>> +
>> + wdt: watchdog@50000000 {
>> + compatible = "apple,t8103-wdt", "apple,wdt";
>> + reg = <0x50000000 0x4000>;
>> + clocks = <&clk>;
>> + interrupts = <AIC_IRQ 123 IRQ_TYPE_LEVEL_HIGH>;
>> + };
>> +
>> +...
>> diff --git a/MAINTAINERS b/MAINTAINERS
>> index 360e9aa0205d..859201bbd4e8 100644
>> --- a/MAINTAINERS
>> +++ b/MAINTAINERS
>> @@ -1750,6 +1750,7 @@ F: Documentation/devicetree/bindings/interrupt-controller/apple,aic.yaml
>> F: Documentation/devicetree/bindings/mailbox/apple,mailbox.yaml
>> F: Documentation/devicetree/bindings/pci/apple,pcie.yaml
>> F: Documentation/devicetree/bindings/pinctrl/apple,pinctrl.yaml
>> +F: Documentation/devicetree/bindings/watchdog/apple,wdt.yaml
>> F: arch/arm64/boot/dts/apple/
>> F: drivers/i2c/busses/i2c-pasemi-core.c
>> F: drivers/i2c/busses/i2c-pasemi-platform.c
>> --
>> 2.25.1
>>
>
I've gone ahead and applied this patch to the asahi-soc/dt tree, so we
can build off of that to add the DT nodes.
Sven, can you spin a v3 with the MAINTAINERS split and just the driver
itself, without this patch? I imagine Guenter will want to take the
driver itself through the linux-watchdog tree.
--
Hector Martin (marcan@marcan.st)
Public Key: https://mrcn.st/pub
prev parent reply other threads:[~2021-12-07 4:35 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-30 16:18 [PATCH v2 1/2] dt-bindings: watchdog: Add Apple Watchdog Sven Peter
2021-11-30 16:18 ` [PATCH v2 2/2] watchdog: Add Apple SoC watchdog driver Sven Peter
2021-11-30 20:55 ` Janne Grunau
2021-12-02 6:44 ` Hector Martin "marcan"
2021-12-02 14:36 ` Guenter Roeck
2021-12-03 13:50 ` Hector Martin
2021-12-03 15:08 ` Guenter Roeck
2021-12-02 12:38 ` Hector Martin
2021-12-02 14:43 ` Guenter Roeck
2021-12-02 14:43 ` [PATCH v2 1/2] dt-bindings: watchdog: Add Apple Watchdog Guenter Roeck
2021-12-07 4:35 ` Hector Martin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bd9a52eb-2aca-38a9-e183-2857960a4842@marcan.st \
--to=marcan@marcan.st \
--cc=alyssa@rosenzweig.io \
--cc=devicetree@vger.kernel.org \
--cc=j@jannau.net \
--cc=kettenis@openbsd.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=robh+dt@kernel.org \
--cc=robh@kernel.org \
--cc=sven@svenpeter.dev \
--cc=wim@linux-watchdog.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).