From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751686AbcIIN40 (ORCPT ); Fri, 9 Sep 2016 09:56:26 -0400 Received: from mx0b-00082601.pphosted.com ([67.231.153.30]:39115 "EHLO mx0a-00082601.pphosted.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1750899AbcIIN4V (ORCPT ); Fri, 9 Sep 2016 09:56:21 -0400 Subject: Re: [PATCH 3/5] nbd: use flags instead of bool To: Joe Perches , Josef Bacik , , , , , References: <1473369130-22986-1-git-send-email-jbacik@fb.com> <1473369130-22986-4-git-send-email-jbacik@fb.com> <1473384038.13672.23.camel@perches.com> From: Jens Axboe Message-ID: Date: Fri, 9 Sep 2016 07:55:52 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.2.0 MIME-Version: 1.0 In-Reply-To: <1473384038.13672.23.camel@perches.com> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [216.160.245.98] X-ClientProxiedBy: CY1PR10CA0024.namprd10.prod.outlook.com (10.162.208.34) To DM5PR15MB1194.namprd15.prod.outlook.com (10.173.209.12) X-MS-Office365-Filtering-Correlation-Id: 9e5da630-10d4-4ed7-eaab-08d3d8b90658 X-Microsoft-Exchange-Diagnostics: 1;DM5PR15MB1194;2:RwHPbiyKnjHjznICFMmeFFov3AGkoOn4tH2Jm0UZmOQjWmIP17+jtZVykdiGisP8R8GE3P6Hnr3t1yAUUXlE7BrTooI0bK6l5XcwvGd+D9q6YxYMOdphLtsT+KM1dM3wQVFC6l6/H2VAv9mpmgU42nBkKXgtCk0c3yDW+yPj7vjz1kco9kh4LfEShqyetNVs;3:UFU3UehklbWnXQBqNI3s2sQtQ95kSrmMQL9gNpAt7Q5YjU20imHNooExunaSQ/36N8cfiKo4SpNOZpqiwEPOPO8D+KqBn5pIgCDxNZncpjOPj7UujuHXnk8yoETcMPGt X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:DM5PR15MB1194; X-Microsoft-Exchange-Diagnostics: 1;DM5PR15MB1194;25:qtK5PIgisNf8TaQ7swtjo+cjyTcEOAHrVh7uoEDBrT2cK87BPr7b9RI7WuMgseXV4jCUNn6VgFShZV8kfWztwKPYIBMEICopEBp7iKtUpgNBEkmpsyKG57CCLujCxKkCNtUe57mzPoswsIVU+XrUxWfSQIQBh4E2NmOsS3Cbyg/au4SDMPc0iCB7ewm6mMVWngJENcqGesvEaw7aFh/ERSzPfw1Fy1amhp5XGsBobjZHZn/Nrz/5ynFGLVaMJnDE1ogqUdUZk/Fgx7wlKghLBps6bbb2PT4rFNaMI90Qn/2avzCjXM3GVqWmWvmKqAktmfh9ti1NkM02XNlHMyqvWx0BRsUPzj6d30UT4z4WWBOgEeGMeybw6OG61I+MFh/vHzC06LndQRIzXblxbmdLdOMjj0a8CMU+XndI+TWHj5jsSTy/7YiC38AQ1sMXDcxlXtv8WrkupkIOYHgzWB3iymDBWY709ZItCkVoazrqp/zErq2Hpcl9wO2oh+GyqCTWeTb+TMYX56QNJS25p2uUxKvt+FGghjz6KKl3pEQJC9mf36fvwYpHUJnsDdrmSggFEdfHGMOTNsyy74rjH4itlwMkzCJohouQv3QzwMLFQFI+Dmug+8F0iho0Ccg4VPk1QqaoBsy47eejJqhjLZ6CCix3UocBxp9OEDaCt8xWzZO/nq1XkzaxbI8ObngGYgDRSsVNzzY8zjjtoxHCr6cdmQ==;31:IS5Z2Zb6Nd2ef6WPznXeAIB0v6vFre10pXpEb6o9or1L4NRiMROipVvkwl/MezeWBAB1Lj9BYT0QVeExy+y26cmdiS0yqSm0LrFDSmKP5x53Ab72895JvobeJMRTPQxSD+12S2k3uEzFE2vKFjsUNH7kBE7Ky7oEL0UE9971eiSv6OhfGVpgRJjMyETILYZU0FBb3bFLGSJPLcTcmcnjU9nz3ViH0a5zTRWgPjY3Luc= X-LD-Processed: 8ae927fe-1255-47a7-a2af-5f3a069daaa2,ExtAddr X-Microsoft-Exchange-Diagnostics: 1;DM5PR15MB1194;20:QweZ50KahbWm8zHvA4XJBRdkuvMxSG4egekJfvH+PPqxtcEgFqaiPiPLkev+GrQ9UgyiKD9GWG6mWlCriKpi3nUHkFNee+uuA+S2aDQ6ICT3WuV2yvcIAWtsQoAzbFrAKDpJG9xmRqFgjDDUvnSEjK134E6GkkFGgKyuJqw+sE0=;4:6bWmrhvyrxIK+mikKf+4n179s3MFGOa7DwL/ox2nzjnWslxEY67q6JjOfhJCP19zR/tjcOo6K6aOswTN5ptVZUqZI3Ml8FYyAe8Gl4VPSeMJxdFxyN1EnJY9N+0I7WGxGfIQT9HiNNNeySdKnik7ZfYj+3QuwKxAr9berTqZtEE2W9hPDl/DMZqxq5mVPGOCdSKZvE4663kpO7RtOGUMSGEPJPrEr429P9Xxwpld9A1PxkKgIA1wDi0Cb27LGQgznWYRxjD6dwt/aR+gHYmipdzT7h62LjtIVqKkZPQSgZk4jxClQbJLXEFrx80tztksh+dbpXlC4w2uk6eHGtraXHpvrCgU/si1AI8Cqfg3yVISGvQX/hhuMF6ngBwXY10hxZRmfpUp6j1tepwNY47Hqg== X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(6040176)(601004)(2401047)(8121501046)(5005006)(10201501046)(3002001);SRVR:DM5PR15MB1194;BCL:0;PCL:0;RULEID:;SRVR:DM5PR15MB1194; X-Forefront-PRVS: 00603B7EEF X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10019020)(4630300001)(6009001)(6049001)(7916002)(199003)(189002)(377424004)(377454003)(24454002)(31686004)(117156001)(42186005)(106356001)(101416001)(31696002)(305945005)(83506001)(86362001)(105586002)(54356999)(33646002)(76176999)(50986999)(7846002)(2950100001)(230700001)(7736002)(47776003)(2201001)(36756003)(5660300001)(97736004)(23746002)(66066001)(5001770100001)(65956001)(92566002)(65806001)(68736007)(189998001)(586003)(50466002)(6116002)(64126003)(81156014)(81166006)(77096005)(3846002)(4001350100001)(8676002)(2906002)(65826007)(107886002);DIR:OUT;SFP:1102;SCL:1;SRVR:DM5PR15MB1194;H:[192.168.1.153];FPR:;SPF:None;PTR:InfoNoRecords;A:1;MX:1;LANG:en; X-Microsoft-Exchange-Diagnostics: =?Windows-1252?Q?1;DM5PR15MB1194;23:waABCuZIvSShgEJoTQFEjAtVLpAoIpejlaP2e?= =?Windows-1252?Q?iwvXzSqhDVtIMzmWPTyVKEbyBxHf/1pC7B87/TgMvarZ/VKxWZ8SFgkY?= =?Windows-1252?Q?fVvzEvBV+YZt2ej7Ka2rQGt0JP0e7unnQ7oFD+Ejx+R8kA0FTY6lRgv5?= =?Windows-1252?Q?NeUGL7plCIQVKeOxQr1G20SdMOeo/jfEAmgksPqq6WTv9u+5XZgUkOlb?= =?Windows-1252?Q?WO5wbBP1i+O8984H/xyAPRAebAnduAhVLx/z4qZpPiZGy3kJc29pkgyf?= =?Windows-1252?Q?sDtLMUMziRUj6uGzM8zTOvIaZAld8tnWvOcLSn//s48cYmKpd0ZnkMhZ?= =?Windows-1252?Q?QSvj2+X1+ryyf9KSC0+9izSe3ob7bf1+/4A65Zhh8g7QFNMTW3ZwBHjb?= =?Windows-1252?Q?CoTRW4kFYEYqYNMuf1zY893tkBTkiG6w3rw1LHEppox9iVze6VQmML7R?= =?Windows-1252?Q?c8KWfvvpWHSONUKTRiXebTBCerKnAwkbjmeCFE6HQm/z/Y4JINcyMIRA?= =?Windows-1252?Q?xk4QSZhjgaM7yY876RQhx6Sy9DDJbku0Z9HvO/X/8FrcSOcXgPsYr8OL?= =?Windows-1252?Q?hXVb9t74mre9qAOceN2fTNngz4xhX9O4/vRY4/CLEjxJfR0QwJdK28dF?= =?Windows-1252?Q?WBK8zKwdUVqNxE4Nga29wn+0lkN2G11Huko1rxc6XOKfUwDL12+LZV+p?= =?Windows-1252?Q?QWhf36V1ago5zKqUBNYfeAIxhgKjBWw6kUO+1E8lfJaOKTaP754QGIP7?= =?Windows-1252?Q?J/X9aA+mElmHzfES+bTvkHVAGKTmQNPN3l3R1TUZgxWY3C3AXiB7DX22?= =?Windows-1252?Q?Zu0nU/4VxWMIWF7EYXCm3YRCPpXDMk3BbEEN1yLYaThehfWWAMG4IR+2?= =?Windows-1252?Q?7Q/dUjkJUdL3CT+CqO0k//BqXxpsIq1GJW1SZ/nVV/Tvw9f4yjnC/4HS?= =?Windows-1252?Q?2roBGUPd0w9mPqbr4ebgPc3OQwz2GUBenSTUud5j6Bc7knggWgRDKA4m?= =?Windows-1252?Q?Xu14nXuWJytDKxAoPi0k0YzJ38fr9QMkkkohhKbgiR9dtlBTud/nAWuV?= =?Windows-1252?Q?YSTKaJlrUlReEJEHQlBc6ScBDqmk4Fee+Mmp6l2vtwXwuDQIA04N9BIR?= =?Windows-1252?Q?b8BU2V4OpRw634DHRldYTA1T7ZsZZJMUsHRKqW8S4KP6duh1W5cYoOjf?= =?Windows-1252?Q?6szg38hUGTpby2937cEgHe7P0/3dY/XbHqmk6bMTKwf29LbJ8Wuwwhon?= =?Windows-1252?Q?jldcscYTCip/TwWj9yUuE3+qFzkAI3ZlrWMZWqdwO37ThZs1zJLPf8zG?= =?Windows-1252?Q?ys3VbyZOAkhO818OMQIYvt6LofLYcpg/nbPp0IW6735b+gvd53GZxZFM?= =?Windows-1252?Q?SaRj1c+FAUTm0xdLXRRTm/q+dL9O0rBmoIry5CoT0Q24uf+YpvgRQA?= =?Windows-1252?Q?=3D?= X-Microsoft-Exchange-Diagnostics: 1;DM5PR15MB1194;6:wHJ6hZSiRa2JXfOBPQQ/SCMK1kSzH63EgzumH4GvgG2BTn5HnuO/3fMalLEQzD/v1vdmd2adQsqCjACviz0qcTQleJgvRNYWZy6tEyFZU/DxLKYXxKdFjkAyP2fb/vwN4IQ827wBl5i0KJlCW5X3g7aKDtvYtUIZTZ1Vki5nLSr7nzULlc9EdtC6JUjk9IQ4lWP5+V9fSuIBL2taQ5LIoVpXaHJ4A4K9gF9OJv8io4BTB5pCsuZfnSv+pG9Jxp6M9rX6FvBa63L0u+Tx5Af59vq1kqoNviVP1YOCJuwMWKw=;5:i9Jj/Dlxfv4Nf1VVVpj/lGZ8PZwdTE0AvafAro23Or4WEncicmqfPrfJqGFnIKjGB2Bn8FkMIjGl6yDbCpuo9x6hfC10XXWRL8PcehmBtbVt9kTYu2TevtR0XIQPX7ZQCcw1ig4n8+i99ulSNOZdoA==;24:HdH2OcKDRhfyEIH0Fpajy3KQ0/GZ/1svaePIqvOez8zLITGMIFeG+JyXPZo/Wi8t0cMccQRORJDWOV1DenZtXnTTi0DVYGh8hbt01TqIL5E=;7:67xMsMCOfGF6nbU9ko0WFVpgVMfCww0SdiKR3y7HTOR2CObMEfD0q4/T4RaumkLwT0peIPVHLwzDUrxliUGofqMsv6zSPHu7iBnPUcIR9YeJNV73AW3R1AmPnfZhgUEJUt2Po+XXPFgGUa9deKs/6a4c629Oq1dVNCcPZyMfG18dq4gWHvqmcs36B7nL4V3oC1k5+u62w1nx0GAXVR2j0F5f3CkbsvmOmuXCyuhTXG+E9J6PnR1CQJHJLvHDwOKg SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1;DM5PR15MB1194;20:W6njh3srqncnBHt1e+tjq7rgkZtAwPB43Lf3BxcBsxV5Ce18UOycXXAatqBjKJv79iJeVd/uJ8bRM2sbOJUGJUZCefZxH2BpXO4e7Ygtds9fOSaeMyhBFHrYgRr/9Fl8KsEvOIIVp3Coxn+e26NVnIim0gdIbESPGaNQbBM2nkg= X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Sep 2016 13:55:57.2858 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR15MB1194 X-OriginatorOrg: fb.com X-Proofpoint-Spam-Reason: safe X-FB-Internal: Safe X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2016-09-09_07:,, signatures=0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 09/08/2016 07:20 PM, Joe Perches wrote: > On Thu, 2016-09-08 at 17:12 -0400, Josef Bacik wrote: >> In preparation for some future changes, change a few of the state bools over to >> normal bits to set/clear properly. > [] >> diff --git a/drivers/block/nbd.c b/drivers/block/nbd.c > [] >> @@ -41,8 +41,12 @@ >> >> #include >> >> +#define NBD_TIMEDOUT 0 >> +#define NBD_DISCONNECT_REQUESTED 1 >> + >> struct nbd_device { >> u32 flags; >> + unsigned long runtime_flags; > > Better to use DECLARE_BITMAP It's a few flags, we know it fits in a long. There's no point to using anything but that, and set/test/clear_bit(). -- Jens Axboe