linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Shawn Lin <shawn.lin@rock-chips.com>
To: Doug Anderson <dianders@chromium.org>,
	Shawn Lin <shawn.lin@rock-chips.com>
Cc: "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
	Heiko Stuebner <heiko@sntech.de>, Arnd Bergmann <arnd@arndb.de>,
	Marc Zyngier <marc.zyngier@arm.com>,
	linux-pci@vger.kernel.org, Wenrui Li <wenrui.li@rock-chips.com>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"open list:ARM/Rockchip SoC..."
	<linux-rockchip@lists.infradead.org>,
	Rob Herring <robh+dt@kernel.org>,
	Bjorn Helgaas <bhelgaas@google.com>
Subject: Re: [PATCH v2 1/2] Documentation: bindings: add dt doc for Rockchip PCIe controller
Date: Sun, 12 Jun 2016 09:34:56 +0800	[thread overview]
Message-ID: <bdbc3e8e-b06a-4adf-bf61-56cc19ca67d9@rock-chips.com> (raw)
In-Reply-To: <CAD=FV=XiRgjAU2STck4mcWAERqZDvNSsCUytHDnWD+SHL2sRrQ@mail.gmail.com>

在 2016/6/10 12:01, Doug Anderson 写道:
> Shawn,
>
> On Wed, Jun 8, 2016 at 1:05 AM, Shawn Lin <shawn.lin@rock-chips.com> wrote:
>> +pcie0: pcie@f8000000 {
>> +       compatible = "rockchip,rk3399-pcie";
>> +       #address-cells = <3>;
>> +       #size-cells = <2>;
>> +       clocks = <&cru ACLK_PCIE>, <&cru ACLK_PERF_PCIE>,
>> +                <&cru PCLK_PCIE>;
>> +       clock-names = "aclk", "aclk-perf",
>> +                     "hclk";
>
> Code also requires a "pm" clock.
>
>> +       bus-range = <0x0 0x1>;
>> +       interrupts = <GIC_SPI 49 IRQ_TYPE_LEVEL_HIGH>, <GIC_SPI 50 IRQ_TYPE_LEVEL_HIGH>,
>> +                    <GIC_SPI 51 IRQ_TYPE_LEVEL_HIGH>;
>> +       interrupt-names: "sys", "legacy", "client";
>
> Shouldn't be ":", should be "=".
>
>
>> +       assigned-clocks = <&cru SCLK_PCIEPHY_REF>;
>> +       assigned-clock-parents = <&cru SCLK_PCIEPHY_REF100M>;
>> +       assigned-clock-rates = <100000000>;
>> +       ep-gpios = <&gpio3 13 GPIO_ACTIVE_HIGH>;
>> +       ranges = < 0x82000000 0 0xfa000000 0x0 0xfa000000 0 0x600000
>> +                  0x81000000 0 0xfa600000 0x0 0xfa600000 0 0x100000 >;
>
> nit: I don't thin it's common to have spaces before/after the ">" and "<".
> nit: Be consistent about 0 vs. 0x0 in ranges.
>
>
>> +       num-lanes = <4>;
>> +       reg = < 0x0 0xf8000000 0x0 0x2000000 >, < 0x0 0xfd000000 0x0 0x1000000 >;
>> +       reg-name = "axi-base", "apb-base";
>
> Should be "reg-names" (with an "s")
>
>
>> +       resets = <&cru SRST_PCIEPHY>, <&cru SRST_PCIE_CORE>, <&cru SRST_PCIE_MGMT>,
>> +                <&cru SRST_PCIE_MGMT_STICKY>, <&cru SRST_PCIE_PIPE>;
>> +       reset-names = "core", "mgmt", "mgmt-sticky", "pipe";
>
> You have 5 resets but 4 reset names.  That doesn't seem right.  Code
> shows you only getting 4, so presumably you need to remove the
> SRST_PCIEPHY one.

Thanks for catching these above as I forgot to rework the this sample.

>
>
> -Doug
>
> _______________________________________________
> Linux-rockchip mailing list
> Linux-rockchip@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-rockchip
>


-- 
Best Regards
Shawn Lin

  reply	other threads:[~2016-06-12  1:35 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-06-08  8:05 Shawn Lin
2016-06-08  9:24 ` Marc Zyngier
2016-06-08 20:44 ` Rob Herring
2016-06-12  1:42   ` Shawn Lin
2016-06-10  4:01 ` Doug Anderson
2016-06-12  1:34   ` Shawn Lin [this message]
2016-06-10  7:32 ` Marc Zyngier
2016-06-16 15:31   ` Doug Anderson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bdbc3e8e-b06a-4adf-bf61-56cc19ca67d9@rock-chips.com \
    --to=shawn.lin@rock-chips.com \
    --cc=arnd@arndb.de \
    --cc=bhelgaas@google.com \
    --cc=devicetree@vger.kernel.org \
    --cc=dianders@chromium.org \
    --cc=heiko@sntech.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=linux-rockchip@lists.infradead.org \
    --cc=marc.zyngier@arm.com \
    --cc=robh+dt@kernel.org \
    --cc=wenrui.li@rock-chips.com \
    --subject='Re: [PATCH v2 1/2] Documentation: bindings: add dt doc for Rockchip PCIe controller' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).