From: Tom Zanussi <zanussi@kernel.org>
To: Masami Hiramatsu <mhiramat@kernel.org>,
Steven Rostedt <rostedt@goodmis.org>
Cc: LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 0/2] tracing: Fix config dependency and trigger parser
Date: Tue, 23 Jun 2020 16:03:48 -0500 [thread overview]
Message-ID: <bdcdd6d10342005a8c773f4ffb882dabf398e5ac.camel@kernel.org> (raw)
In-Reply-To: <159262474473.185015.177609153974879988.stgit@devnote2>
Hi Masami,
On Sat, 2020-06-20 at 12:45 +0900, Masami Hiramatsu wrote:
> Hi,
>
> These are some fixes which I found recentry on ftrace.
>
> - Since the boot-time tracing synthetic event feature is decoupled
> from trigger recenty, it should use CONFIG_SYNTH_EVENT.
Oops, yeah, I missed this one in the update, thanks for finding it.
> - The parser of event trigger seems rejecting some redundant
> spaces. But it is hard users to find the wrong point. Such
> spaces should be accepted.
>
Agreed, your patch makes things much better, thanks.
You can add my reviewed-by for both patches.
Reviewed-by: Tom Zanussi <zanussi@kernel.org>
Thanks,
Tom
> BTW, I also found the trigger parser accepts some inputs which
> may not correctly formatted, e.g.
>
> # echo "traceon 1" > events/ftrace/print/trigger
>
> (from the document, it must be "traceon:1")
> But I think this does not decrease the usability.
>
> Thank you,
>
> ---
>
> Masami Hiramatsu (2):
> tracing/boot: Fix config dependency for synthedic event
> tracing: Fix event trigger to accept redundant spaces
>
>
> kernel/trace/trace_boot.c | 2 +-
> kernel/trace/trace_events_trigger.c | 21 +++++++++++++++++++--
> 2 files changed, 20 insertions(+), 3 deletions(-)
>
> --
> Masami Hiramatsu (Linaro) <mhiramat@kernel.org>
prev parent reply other threads:[~2020-06-23 21:04 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-20 3:45 [PATCH 0/2] tracing: Fix config dependency and trigger parser Masami Hiramatsu
2020-06-20 3:45 ` [PATCH 1/2] tracing/boot: Fix config dependency for synthedic event Masami Hiramatsu
2020-06-20 3:46 ` [PATCH 2/2] tracing: Fix event trigger to accept redundant spaces Masami Hiramatsu
2020-06-23 21:03 ` Tom Zanussi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bdcdd6d10342005a8c773f4ffb882dabf398e5ac.camel@kernel.org \
--to=zanussi@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mhiramat@kernel.org \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).