From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Jiri Slaby <jirislaby@kernel.org>, Andy Gross <agross@kernel.org>,
Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konrad.dybcio@linaro.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Satya Priya <quic_c_skakit@quicinc.com>,
linux-arm-msm@vger.kernel.org, linux-serial@vger.kernel.org,
linux-kernel@vger.kernel.org
Cc: stable@vger.kernel.org
Subject: Re: [PATCH] tty: serial: qcom-geni-serial: fix slab-out-of-bounds on RX FIFO buffer
Date: Wed, 21 Dec 2022 08:49:19 +0100 [thread overview]
Message-ID: <bdddd72f-a118-ff43-c53f-5ffd724fbd55@linaro.org> (raw)
In-Reply-To: <b21a17c7-df9c-ce20-f986-8f093a33278c@kernel.org>
On 21/12/2022 07:43, Jiri Slaby wrote:
> On 20. 12. 22, 17:15, Krzysztof Kozlowski wrote:
>> Driver's probe allocates memory for RX FIFO (port->rx_fifo) based on
>> default RX FIFO depth, e.g. 16. Later during serial startup the
>> qcom_geni_serial_port_setup() updates the RX FIFO depth
>> (port->rx_fifo_depth) to match real device capabilities, e.g. to 32.
> ...
>> If the RX FIFO depth changes after probe, be sure to resize the buffer.
>>
>> Fixes: f9d690b6ece7 ("tty: serial: qcom_geni_serial: Allocate port->rx_fifo buffer in probe")
>> Cc: <stable@vger.kernel.org>
>> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
>
> Reviewed-by: Jiri Slaby <jirislaby@kernel.org>
>
> This patch LGTM, I only wonder:
>
>> --- a/drivers/tty/serial/qcom_geni_serial.c
>> +++ b/drivers/tty/serial/qcom_geni_serial.c
>> @@ -864,9 +864,10 @@ static irqreturn_t qcom_geni_serial_isr(int isr, void *dev)
>> return IRQ_HANDLED;
>> }
>>
>> -static void get_tx_fifo_size(struct qcom_geni_serial_port *port)
>> +static int get_tx_fifo_size(struct qcom_geni_serial_port *port)
>
> ... why is this function dubbed get_tx_fifo_size(), provided it handles
> rx fifo too? And it does not "get" the tx fifo size. In fact, the
> function sets that :).
I reads the FIFO sizes from the device registers, so I guess that was
behind the naming.
>
>> {
>> struct uart_port *uport;
>> + u32 old_rx_fifo_depth = port->rx_fifo_depth;
>>
>> uport = &port->uport;
>> port->tx_fifo_depth = geni_se_get_tx_fifo_depth(&port->se);
>> @@ -874,6 +875,16 @@ static void get_tx_fifo_size(struct qcom_geni_serial_port *port)
>> port->rx_fifo_depth = geni_se_get_rx_fifo_depth(&port->se);
>> uport->fifosize =
>> (port->tx_fifo_depth * port->tx_fifo_width) / BITS_PER_BYTE;
>> +
>> + if (port->rx_fifo && (old_rx_fifo_depth != port->rx_fifo_depth) && port->rx_fifo_depth) {
>> + port->rx_fifo = devm_krealloc(uport->dev, port->rx_fifo,
>> + port->rx_fifo_depth * sizeof(u32),
>> + GFP_KERNEL);
>
> And now it even allocates memory.
>
> So more appropriate name should be setup_fifos() or similar.
Sure, I'll rename it and keep your Rb tag.
>
Best regards,
Krzysztof
prev parent reply other threads:[~2022-12-21 7:49 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-20 16:15 [PATCH] tty: serial: qcom-geni-serial: fix slab-out-of-bounds on RX FIFO buffer Krzysztof Kozlowski
2022-12-21 6:43 ` Jiri Slaby
2022-12-21 7:49 ` Krzysztof Kozlowski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bdddd72f-a118-ff43-c53f-5ffd724fbd55@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=agross@kernel.org \
--cc=andersson@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=jirislaby@kernel.org \
--cc=konrad.dybcio@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=quic_c_skakit@quicinc.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).