From: <Claudiu.Beznea@microchip.com>
To: <alexandre.belloni@bootlin.com>, <davem@davemloft.net>
Cc: <Nicolas.Ferre@microchip.com>, <harini.katakam@xilinx.com>,
<shubhrajyoti.datta@xilinx.com>, <netdev@vger.kernel.org>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH net] net: macb: ensure interface is not suspended on at91rm9200
Date: Wed, 12 Feb 2020 17:41:12 +0000 [thread overview]
Message-ID: <bdf8550b-e49f-5e3a-2cfb-02ae7b7bf26e@microchip.com> (raw)
In-Reply-To: <20200212164538.383741-1-alexandre.belloni@bootlin.com>
On 12.02.2020 18:45, Alexandre Belloni wrote:
> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
>
> Because of autosuspend, at91ether_start is called with clocks disabled.
> Ensure that pm_runtime doesn't suspend the interface as soon as it is
> opened as there is no pm_runtime support is the other relevant parts of the
> platform support for at91rm9200.
>
> Fixes: d54f89af6cc4 ("net: macb: Add pm runtime support")
> Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com>
Reviewed-by: Claudiu Beznea <claudiu.beznea@microchip.com>
> ---
> drivers/net/ethernet/cadence/macb_main.c | 6 +++++-
> 1 file changed, 5 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/net/ethernet/cadence/macb_main.c b/drivers/net/ethernet/cadence/macb_main.c
> index 4508f0d150da..def94e91883a 100644
> --- a/drivers/net/ethernet/cadence/macb_main.c
> +++ b/drivers/net/ethernet/cadence/macb_main.c
> @@ -3790,6 +3790,10 @@ static int at91ether_open(struct net_device *dev)
> u32 ctl;
> int ret;
>
> + ret = pm_runtime_get_sync(&lp->pdev->dev);
> + if (ret < 0)
> + return ret;
> +
> /* Clear internal statistics */
> ctl = macb_readl(lp, NCR);
> macb_writel(lp, NCR, ctl | MACB_BIT(CLRSTAT));
> @@ -3854,7 +3858,7 @@ static int at91ether_close(struct net_device *dev)
> q->rx_buffers, q->rx_buffers_dma);
> q->rx_buffers = NULL;
>
> - return 0;
> + return pm_runtime_put(&lp->pdev->dev);
> }
>
> /* Transmit packet */
> --
> 2.24.1
>
>
next prev parent reply other threads:[~2020-02-12 17:41 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-12 16:45 [PATCH net] net: macb: ensure interface is not suspended on at91rm9200 Alexandre Belloni
2020-02-12 17:41 ` Claudiu.Beznea [this message]
2020-02-13 8:45 ` Nicolas Ferre
2020-02-17 2:42 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bdf8550b-e49f-5e3a-2cfb-02ae7b7bf26e@microchip.com \
--to=claudiu.beznea@microchip.com \
--cc=Nicolas.Ferre@microchip.com \
--cc=alexandre.belloni@bootlin.com \
--cc=davem@davemloft.net \
--cc=harini.katakam@xilinx.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=shubhrajyoti.datta@xilinx.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).