From: "Moger, Babu" <babu.moger@amd.com>
To: Reinette Chatre <reinette.chatre@intel.com>,
corbet@lwn.net, tglx@linutronix.de, mingo@redhat.com,
bp@alien8.de
Cc: fenghua.yu@intel.com, dave.hansen@linux.intel.com,
x86@kernel.org, hpa@zytor.com, paulmck@kernel.org,
akpm@linux-foundation.org, quic_neeraju@quicinc.com,
rdunlap@infradead.org, damien.lemoal@opensource.wdc.com,
songmuchun@bytedance.com, peterz@infradead.org,
jpoimboe@kernel.org, pbonzini@redhat.com,
chang.seok.bae@intel.com, pawan.kumar.gupta@linux.intel.com,
jmattson@google.com, daniel.sneddon@linux.intel.com,
sandipan.das@amd.com, tony.luck@intel.com, james.morse@arm.com,
linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org,
bagasdotme@gmail.com, eranian@google.com
Subject: Re: [PATCH v7 06/12] x86/resctrl: Introduce data structure to support monitor configuration
Date: Wed, 26 Oct 2022 14:25:45 -0500 [thread overview]
Message-ID: <bdf90b2a-7f92-8f82-f1a6-225d7938cfb9@amd.com> (raw)
In-Reply-To: <8cb913f4-feee-de7d-60d0-055e234c6501@intel.com>
Hi Reinette,
On 10/25/22 18:45, Reinette Chatre wrote:
> Hi Babu,
>
> On 10/17/2022 3:26 PM, Babu Moger wrote:
>> Add a new field in mon_evt to support Bandwidth Monitoring Event
>> Configuration(BMEC) and also update the "mon_features" display.
>>
>> The sysfs file "mon_features" will display the monitor configuration
>> if supported.
>>
>> Before the change.
>> $cat /sys/fs/resctrl/info/L3_MON/mon_features
>> llc_occupancy
>> mbm_total_bytes
>> mbm_local_bytes
>>
>> After the change if BMEC is supported.
>> $cat /sys/fs/resctrl/info/L3_MON/mon_features
>> llc_occupancy
>> mbm_total_bytes
>> mbm_total_config
>> mbm_local_bytes
>> mbm_local_config
> This does not seem to be what the code in this patch does.
You are right. it is
# cat /sys/fs/resctrl/info/L3_MON/mon_features
llc_occupancy
mbm_total_bytes
mbm_total_bytes_config
mbm_local_bytes
mbm_local_bytes_config
>
>> Signed-off-by: Babu Moger <babu.moger@amd.com>
>> ---
>> arch/x86/kernel/cpu/resctrl/core.c | 3 ++-
>> arch/x86/kernel/cpu/resctrl/internal.h | 4 +++-
>> arch/x86/kernel/cpu/resctrl/monitor.c | 7 ++++++-
>> arch/x86/kernel/cpu/resctrl/rdtgroup.c | 5 ++++-
>> 4 files changed, 15 insertions(+), 4 deletions(-)
>>
>> diff --git a/arch/x86/kernel/cpu/resctrl/core.c b/arch/x86/kernel/cpu/resctrl/core.c
>> index d79f494a4e91..46813b1c50c2 100644
>> --- a/arch/x86/kernel/cpu/resctrl/core.c
>> +++ b/arch/x86/kernel/cpu/resctrl/core.c
>> @@ -814,6 +814,7 @@ static __init bool get_rdt_alloc_resources(void)
>> static __init bool get_rdt_mon_resources(void)
>> {
>> struct rdt_resource *r = &rdt_resources_all[RDT_RESOURCE_L3].r_resctrl;
>> + bool mon_configurable = rdt_cpu_has(X86_FEATURE_BMEC);
>>
>> if (rdt_cpu_has(X86_FEATURE_CQM_OCCUP_LLC))
>> rdt_mon_features |= (1 << QOS_L3_OCCUP_EVENT_ID);
>> @@ -825,7 +826,7 @@ static __init bool get_rdt_mon_resources(void)
>> if (!rdt_mon_features)
>> return false;
>>
>> - return !rdt_get_mon_l3_config(r);
>> + return !rdt_get_mon_l3_config(r, mon_configurable);
>> }
> This seems to do a portion of configuration in the calling function, pass the
> results of to the actual configuration function where the rest of the configuration is
> done. Determining "mon_configurable" really looks like it belongs in
> rdt_get_mon_l3_config(). Is it availability of rdt_cpu_has() that prevented
> that change? Why not make it available internally to all resctrl code?
Yes. It is because of rdt_cpu_has availability. Also, it is __init routine.
Yes. I can make it available.
>
> Patch 7's mbm_config_rftype_init() can also be moved to rdt_get_mon_l3_config()
> to match how other related configs (thread_throttle_mode_init()) are done.
Sure. Will do.
>
>>
>> static __init void __check_quirks_intel(void)
>> diff --git a/arch/x86/kernel/cpu/resctrl/internal.h b/arch/x86/kernel/cpu/resctrl/internal.h
>> index 16e3c6e03c79..b458f768f30c 100644
>> --- a/arch/x86/kernel/cpu/resctrl/internal.h
>> +++ b/arch/x86/kernel/cpu/resctrl/internal.h
>> @@ -63,11 +63,13 @@ DECLARE_STATIC_KEY_FALSE(rdt_mon_enable_key);
>> * struct mon_evt - Entry in the event list of a resource
>> * @evtid: event id
>> * @name: name of the event
>> + * @configurable: true if the event is configurable
>> * @list: entry in &rdt_resource->evt_list
>> */
>> struct mon_evt {
>> enum resctrl_event_id evtid;
>> char *name;
>> + bool configurable;
>> struct list_head list;
>> };
>>
>> @@ -522,7 +524,7 @@ int closids_supported(void);
>> void closid_free(int closid);
>> int alloc_rmid(void);
>> void free_rmid(u32 rmid);
>> -int rdt_get_mon_l3_config(struct rdt_resource *r);
>> +int rdt_get_mon_l3_config(struct rdt_resource *r, bool configurable);
>> void mon_event_count(void *info);
>> int rdtgroup_mondata_show(struct seq_file *m, void *arg);
>> void mon_event_read(struct rmid_read *rr, struct rdt_resource *r,
>> diff --git a/arch/x86/kernel/cpu/resctrl/monitor.c b/arch/x86/kernel/cpu/resctrl/monitor.c
>> index efe0c30d3a12..4b8adb7f1c5c 100644
>> --- a/arch/x86/kernel/cpu/resctrl/monitor.c
>> +++ b/arch/x86/kernel/cpu/resctrl/monitor.c
>> @@ -746,7 +746,7 @@ static void l3_mon_evt_init(struct rdt_resource *r)
>> list_add_tail(&mbm_local_event.list, &r->evt_list);
>> }
>>
>> -int rdt_get_mon_l3_config(struct rdt_resource *r)
>> +int rdt_get_mon_l3_config(struct rdt_resource *r, bool configurable)
>> {
>> unsigned int mbm_offset = boot_cpu_data.x86_cache_mbm_width_offset;
>> struct rdt_hw_resource *hw_res = resctrl_to_arch_res(r);
>> @@ -783,6 +783,11 @@ int rdt_get_mon_l3_config(struct rdt_resource *r)
>> if (ret)
>> return ret;
>>
>> + if (configurable) {
>> + mbm_total_event.configurable = true;
>> + mbm_local_event.configurable = true;
>> + }
>> +
>> l3_mon_evt_init(r);
>>
>> r->mon_capable = true;
>> diff --git a/arch/x86/kernel/cpu/resctrl/rdtgroup.c b/arch/x86/kernel/cpu/resctrl/rdtgroup.c
>> index 1271fd1ae2f3..5f0ef1bf4c78 100644
>> --- a/arch/x86/kernel/cpu/resctrl/rdtgroup.c
>> +++ b/arch/x86/kernel/cpu/resctrl/rdtgroup.c
>> @@ -1001,8 +1001,11 @@ static int rdt_mon_features_show(struct kernfs_open_file *of,
>> struct rdt_resource *r = of->kn->parent->priv;
>> struct mon_evt *mevt;
>>
>> - list_for_each_entry(mevt, &r->evt_list, list)
>> + list_for_each_entry(mevt, &r->evt_list, list) {
>> seq_printf(seq, "%s\n", mevt->name);
>> + if (mevt->configurable)
>> + seq_printf(seq, "%s_config\n", mevt->name);
>> + }
>>
>> return 0;
>> }
>>
> If mevt->name is "mbm_total_bytes", then would this not
> print "mbm_total_bytes_config"? This is different from "mbm_total_config"
> in the changelog and does not match the actual files created in later
> patches..
Sure. Will update the changelog,
Thanks
Babu
next prev parent reply other threads:[~2022-10-26 19:26 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-17 22:25 [PATCH v7 00/12] x86/resctrl: Support for AMD QoS new features Babu Moger
2022-10-17 22:26 ` [PATCH v7 01/12] x86/cpufeatures: Add Slow Memory Bandwidth Allocation feature flag Babu Moger
2022-10-27 18:49 ` Reinette Chatre
2022-10-27 19:17 ` Moger, Babu
2022-10-17 22:26 ` [PATCH v7 02/12] x86/resctrl: Add a new resource type RDT_RESOURCE_SMBA Babu Moger
2022-10-17 22:26 ` [PATCH v7 03/12] x86/cpufeatures: Add Bandwidth Monitoring Event Configuration feature flag Babu Moger
2022-10-17 22:26 ` [PATCH v7 04/12] x86/resctrl: Include new features in command line options Babu Moger
2022-10-17 22:26 ` [PATCH v7 05/12] x86/resctrl: Detect and configure Slow Memory Bandwidth allocation Babu Moger
2022-10-25 23:43 ` Reinette Chatre
2022-10-26 19:07 ` Moger, Babu
2022-10-26 20:23 ` Reinette Chatre
2022-10-27 15:30 ` Moger, Babu
2022-10-27 18:37 ` Reinette Chatre
2022-10-28 15:16 ` Moger, Babu
2022-10-17 22:26 ` [PATCH v7 06/12] x86/resctrl: Introduce data structure to support monitor configuration Babu Moger
2022-10-25 23:45 ` Reinette Chatre
2022-10-26 19:25 ` Moger, Babu [this message]
2022-10-17 22:26 ` [PATCH v7 07/12] x86/resctrl: Add sysfs interface to read mbm_total_bytes event configuration Babu Moger
2022-10-25 23:47 ` Reinette Chatre
2022-10-26 19:36 ` Moger, Babu
2022-10-17 22:27 ` [PATCH v7 08/12] x86/resctrl: Add sysfs interface to read mbm_local_bytes " Babu Moger
2022-10-17 22:27 ` [PATCH v7 09/12] x86/resctrl: Add sysfs interface to write mbm_total_bytes " Babu Moger
2022-10-25 23:48 ` Reinette Chatre
2022-10-26 19:52 ` Moger, Babu
2022-10-17 22:27 ` [PATCH v7 10/12] x86/resctrl: Add sysfs interface to write mbm_local_bytes " Babu Moger
2022-10-17 22:27 ` [PATCH v7 11/12] x86/resctrl: Replace smp_call_function_many() with on_each_cpu_mask() Babu Moger
2022-10-17 22:27 ` [PATCH v7 12/12] Documentation/x86: Update resctrl.rst for new features Babu Moger
2022-10-18 3:24 ` Bagas Sanjaya
2022-10-25 23:50 ` Reinette Chatre
2022-10-26 20:00 ` Moger, Babu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bdf90b2a-7f92-8f82-f1a6-225d7938cfb9@amd.com \
--to=babu.moger@amd.com \
--cc=akpm@linux-foundation.org \
--cc=bagasdotme@gmail.com \
--cc=bp@alien8.de \
--cc=chang.seok.bae@intel.com \
--cc=corbet@lwn.net \
--cc=damien.lemoal@opensource.wdc.com \
--cc=daniel.sneddon@linux.intel.com \
--cc=dave.hansen@linux.intel.com \
--cc=eranian@google.com \
--cc=fenghua.yu@intel.com \
--cc=hpa@zytor.com \
--cc=james.morse@arm.com \
--cc=jmattson@google.com \
--cc=jpoimboe@kernel.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=paulmck@kernel.org \
--cc=pawan.kumar.gupta@linux.intel.com \
--cc=pbonzini@redhat.com \
--cc=peterz@infradead.org \
--cc=quic_neeraju@quicinc.com \
--cc=rdunlap@infradead.org \
--cc=reinette.chatre@intel.com \
--cc=sandipan.das@amd.com \
--cc=songmuchun@bytedance.com \
--cc=tglx@linutronix.de \
--cc=tony.luck@intel.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).