From: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Stephen Rothwell <sfr@canb.auug.org.au>,
"Ricardo B. Marliere" <ricardo@marliere.net>,
Thorsten Scherer <T.Scherer@eckelmann.de>,
linux-kernel@vger.kernel.org,
Pengutronix Kernel Team <kernel@pengutronix.de>
Subject: Re: siox patches for next development cycle [Re: [PATCH 0/4] siox: Move some complexity into the core]
Date: Thu, 7 Mar 2024 08:08:33 +0100 [thread overview]
Message-ID: <bdp3rbzcfvjvibyseqzwgmokj6hchwt6fxysjfg2vz5er67li4@ih6cpndluxlj> (raw)
In-Reply-To: <2024030655-sketch-conical-b506@gregkh>
[-- Attachment #1: Type: text/plain, Size: 2219 bytes --]
Hey Greg,
On Wed, Mar 06, 2024 at 10:46:43PM +0000, Greg Kroah-Hartman wrote:
> On Wed, Mar 06, 2024 at 07:24:38PM +0100, Uwe Kleine-König wrote:
> > On Tue, Feb 27, 2024 at 11:21:24AM +0100, Thorsten Scherer wrote:
> > > On Mon, Feb 19, 2024 at 08:46:28AM +0100, Uwe Kleine-König wrote:
> > > The series looks sensible.
> > >
> > > Acked-by: Thorsten Scherer <t.scherer@eckelmann.de>
> > >
> > > @gregkh: Would you please pick up Uwe's series as well?
> >
> > There are currently six patches for drivers/siox waiting to be applied.
> > (Two by Ricardo and four by me.) Thorsten asked Greg to do so. Greg
> > didn't pick these up yet though. So I collected them and put them to a
> > branch at:
> >
> > https://git.kernel.org/pub/scm/linux/kernel/git/ukleinek/linux.git siox/for-next
> >
> > I'd like to get them in during the next development cycle.
> >
> > Greg, what is easiest for you? Are they still on your list of open
> > patches and we (I) need just a bit more patience? Or should I send a PR
> > to Linus when the merge window opens?
>
> Yes, they are on my list, but I am way behind, sorry. But hey, a pull
> request is faster, I'll go take this now, thanks!
>
> Oops, nope, I get the following build error with this tree:
> ERROR: modpost: "devm_siox_master_alloc" [drivers/siox/siox-bus-gpio.ko] undefined!
>
> So are you sure you tested this?
Dang, Stephen notices that, too. TIL if I only do:
make allmodconfig drivers/siox/
a missing EXPORT_SYMBOL doesn't make the build fail.
I squashed
diff --git a/drivers/siox/siox-core.c b/drivers/siox/siox-core.c
index ae103349c91a..24a45920a240 100644
--- a/drivers/siox/siox-core.c
+++ b/drivers/siox/siox-core.c
@@ -730,6 +730,7 @@ struct siox_master *devm_siox_master_alloc(struct device *dev,
return smaster;
}
+EXPORT_SYMBOL_GPL(devm_siox_master_alloc);
int siox_master_register(struct siox_master *smaster)
{
into the offending commit in my above branch and did some more extensive
build testing.
Sorry
Uwe
--
Pengutronix e.K. | Uwe Kleine-König |
Industrial Linux Solutions | https://www.pengutronix.de/ |
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
prev parent reply other threads:[~2024-03-07 7:08 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-19 7:46 [PATCH 0/4] siox: Move some complexity into the core Uwe Kleine-König
2024-02-19 7:46 ` [PATCH 1/4] siox: Don't pass the reference on a master in siox_master_register() Uwe Kleine-König
2024-02-19 7:46 ` [PATCH 2/4] siox: Provide a devm variant of siox_master_alloc() Uwe Kleine-König
2024-03-07 7:13 ` Uwe Kleine-König
2024-03-07 7:29 ` Greg Kroah-Hartman
2024-03-07 8:38 ` Uwe Kleine-König
2024-03-08 21:20 ` [PULL] siox changes for 6.9 Uwe Kleine-König
2024-03-16 7:37 ` Uwe Kleine-König
2024-03-22 7:22 ` Uwe Kleine-König
2024-03-22 7:31 ` Greg Kroah-Hartman
2024-03-23 9:21 ` Uwe Kleine-König
2024-02-19 7:46 ` [PATCH 3/4] siox: Provide a devm variant of siox_master_register() Uwe Kleine-König
2024-02-19 7:46 ` [PATCH 4/4] siox: bus-gpio: Simplify using devm_siox_* functions Uwe Kleine-König
2024-02-27 10:21 ` [PATCH 0/4] siox: Move some complexity into the core Thorsten Scherer
2024-03-06 18:24 ` siox patches for next development cycle [Re: [PATCH 0/4] siox: Move some complexity into the core] Uwe Kleine-König
2024-03-06 21:34 ` Stephen Rothwell
2024-03-06 22:46 ` Greg Kroah-Hartman
2024-03-07 7:08 ` Uwe Kleine-König [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bdp3rbzcfvjvibyseqzwgmokj6hchwt6fxysjfg2vz5er67li4@ih6cpndluxlj \
--to=u.kleine-koenig@pengutronix.de \
--cc=T.Scherer@eckelmann.de \
--cc=gregkh@linuxfoundation.org \
--cc=kernel@pengutronix.de \
--cc=linux-kernel@vger.kernel.org \
--cc=ricardo@marliere.net \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).