On 2020/2/11 5:00, Pierre-Louis Bossart wrote:
> 
> 
> On 2/10/20 12:15 AM, YueHaibing wrote:
>> when do randconfig like this:
>> CONFIG_SND_SOC_SOF_IMX8_SUPPORT=y
>> CONFIG_SND_SOC_SOF_IMX8=y
>> CONFIG_SND_SOC_SOF_OF=y
>> CONFIG_IMX_DSP=m
>> CONFIG_IMX_SCU=y
>>
>> there is a link error:
>>
>> sound/soc/sof/imx/imx8.o: In function 'imx8_send_msg':
>> imx8.c:(.text+0x380): undefined reference to 'imx_dsp_ring_doorbell'
>>
>> Select IMX_DSP in SND_SOC_SOF_IMX8_SUPPORT to fix this
>>
>> Reported-by: Hulk Robot <hulkci@huawei.com>
>> Fixes: f9ad75468453 ("ASoC: SOF: imx: fix reverse CONFIG_SND_SOC_SOF_OF dependency")
>> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
> 
> Thanks for the report.
> 
> Would you mind sharing the .config and instructions to reproduce this case? we have an unrelated issue with allyesconfig that was reviewed here:
> 
> https://github.com/thesofproject/linux/pull/1778
> 
> and I'd probably a good thing to fix everything in one shot.

config is attached, which is on x86_64
> 
> Thanks!
> 
>> ---
>>   sound/soc/sof/imx/Kconfig | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/sound/soc/sof/imx/Kconfig b/sound/soc/sof/imx/Kconfig
>> index bae4f7b..81274906 100644
>> --- a/sound/soc/sof/imx/Kconfig
>> +++ b/sound/soc/sof/imx/Kconfig
>> @@ -14,7 +14,7 @@ if SND_SOC_SOF_IMX_TOPLEVEL
>>   config SND_SOC_SOF_IMX8_SUPPORT
>>       bool "SOF support for i.MX8"
>>       depends on IMX_SCU
>> -    depends on IMX_DSP
>> +    select IMX_DSP
>>       help
>>         This adds support for Sound Open Firmware for NXP i.MX8 platforms
>>         Say Y if you have such a device.
>>
> 
> .
>