linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Matthias Schiffer <matthias.schiffer@ew.tq-group.com>
To: Andrew Lunn <andrew@lunn.ch>
Cc: Linus Walleij <linus.walleij@linaro.org>,
	Bartosz Golaszewski <bgolaszewski@baylibre.com>,
	Lee Jones <lee.jones@linaro.org>,
	Andy Shevchenko <andy.shevchenko@gmail.com>,
	linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 0/7] TQMx86: TQMx110EB and TQMxE40x MFD/GPIO support
Date: Mon, 05 Jul 2021 09:13:02 +0200	[thread overview]
Message-ID: <be0f9d179f0adcc13f46c0b8d36bec78fa99c2e6.camel@ew.tq-group.com> (raw)
In-Reply-To: <YN8Xhu3XXGeLAlhj@lunn.ch>

On Fri, 2021-07-02 at 15:41 +0200, Andrew Lunn wrote:
> On Fri, Jul 02, 2021 at 02:23:46PM +0200, Matthias Schiffer wrote:
> > Updated patch series:
> > 
> > - A number of new patches (more hardware support and a few fixes)
> > - Patches 1-3 have gained Fixes tags
> > - Patch 2 depends on 1, so maybe we can push the GPIO patch through the
> >   MFD tree to keep them together?
> > - The change in patch 7 was somewhat controversial. I've added a
> >   warning, but it is the last patch of the series, so it doesn't affect
> >   the rest of the series if it is rejected.
> 
> Hi Matthias
> 
> Nice to see the vendor involved. That does not happen enough.
> 
> Please split these into fixes and new features. They go into different
> trees, so splitting them makes it easier for the maintainers.
> 
> I would also suggest splitting the patches per subsystem, and send
> them to the specific subsystem maintainer. The exception would be when
> there is cross subsystem dependencies.
> 
>      Andrew

Hi Andrew,

thanks for the quick review.

As mentioned in the cover letter, patch 2 depends on 1, so I think it
would make sense to push all through the MFD tree, including the GPIO
fix.

I guess patches 5 and 6 would be covered by the "new device IDs and
quirks" rule of the stable kernel rules. Does that mean they should
also go through the "fixes" rather than the "next" branch, making 4 and
7 the only ones for "next"?

Should I add "Cc: stable@vger.kernel.org" to all patches for the
"fixes" tree?

Kind regards,
Matthias


  reply	other threads:[~2021-07-05  7:13 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-07-02 12:23 [PATCH v2 0/7] TQMx86: TQMx110EB and TQMxE40x MFD/GPIO support Matthias Schiffer
2021-07-02 12:23 ` [PATCH v2 1/7] gpio: tqmx86: really make IRQ optional Matthias Schiffer
2021-07-02 13:45   ` Andrew Lunn
2021-07-02 14:14     ` Andy Shevchenko
2021-07-02 12:23 ` [PATCH v2 2/7] mfd: tqmx86: clear GPIO IRQ resource when no IRQ is set Matthias Schiffer
2021-07-02 13:52   ` Andrew Lunn
2021-07-02 12:23 ` [PATCH v2 3/7] mfd: tqmx86: remove incorrect TQMx90UC board ID Matthias Schiffer
2021-07-02 13:56   ` Andrew Lunn
2021-07-02 12:23 ` [PATCH v2 4/7] mfd: tqmx86: fix typo in "platform" Matthias Schiffer
2021-07-02 14:00   ` Andrew Lunn
2021-07-02 12:23 ` [PATCH v2 5/7] mfd: tqmx86: add support for TQMx110EB and TQMxE40x Matthias Schiffer
2021-07-02 14:01   ` Andrew Lunn
2021-07-02 12:23 ` [PATCH v2 6/7] mfd: tqmx86: add support for TQ-Systems DMI IDs Matthias Schiffer
2021-07-02 14:01   ` Andrew Lunn
2021-07-02 12:23 ` [PATCH v2 7/7] mfd: tqmx86: assume 24MHz LPC clock for unknown boards Matthias Schiffer
2021-07-02 14:04   ` Andrew Lunn
2021-07-02 13:41 ` [PATCH v2 0/7] TQMx86: TQMx110EB and TQMxE40x MFD/GPIO support Andrew Lunn
2021-07-05  7:13   ` Matthias Schiffer [this message]
2021-07-16  9:20 ` Lee Jones
2021-07-16  9:23   ` Matthias Schiffer
2021-07-16  9:42     ` Lee Jones

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=be0f9d179f0adcc13f46c0b8d36bec78fa99c2e6.camel@ew.tq-group.com \
    --to=matthias.schiffer@ew.tq-group.com \
    --cc=andrew@lunn.ch \
    --cc=andy.shevchenko@gmail.com \
    --cc=bgolaszewski@baylibre.com \
    --cc=lee.jones@linaro.org \
    --cc=linus.walleij@linaro.org \
    --cc=linux-gpio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).