From: Jarkko Nikula <jarkko.nikula@linux.intel.com>
To: Luis Oliveira <Luis.Oliveira@synopsys.com>,
wsa@the-dreams.de, robh+dt@kernel.org, mark.rutland@arm.com,
andriy.shevchenko@linux.intel.com,
mika.westerberg@linux.intel.com, linux-i2c@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: Ramiro.Oliveira@synopsys.com, Joao.Pinto@synopsys.com,
CARLOS.PALMINHA@synopsys.com
Subject: Re: [RESEND PATCH v6 5/6] i2c: designware: add SLAVE mode functions
Date: Thu, 2 Mar 2017 16:33:59 +0200 [thread overview]
Message-ID: <be10879b-a81b-9047-6c67-45916a85ef31@linux.intel.com> (raw)
In-Reply-To: <07463ebe12af8c88c21c24601cf54b0cd2077e07.1488383202.git.lolivei@synopsys.com>
On 03/01/17 17:59, Luis Oliveira wrote:
> - Changes in Kconfig to enable I2C_DESIGNWARE_SLAVE support
> - Slave functions added to core library file
> - Slave abort sources added to common source file
> - New driver: i2c-designware-slave added
> - Changes in the Makefile to compile the I2C_DESIGNWARE_SLAVE module
> when supported by the architecture.
>
> All the SLAVE flow is added but it is not enabled via platform
> driver.
>
> Signed-off-by: Luis Oliveira <lolivei@synopsys.com>
> ---
> V5->V6
> - Enable Slave mode using a different option (kbuild reported an error)
> - Identation fixes needed
> - Changed debug prints to dev_vdbg
> - Fixed slave enumeration
>
> drivers/i2c/busses/Kconfig | 14 +-
> drivers/i2c/busses/Makefile | 1 +
> drivers/i2c/busses/i2c-designware-common.c | 7 +
> drivers/i2c/busses/i2c-designware-core.h | 3 +
> drivers/i2c/busses/i2c-designware-slave.c | 403 +++++++++++++++++++++++++++++
> 5 files changed, 427 insertions(+), 1 deletion(-)
> create mode 100644 drivers/i2c/busses/i2c-designware-slave.c
>
...
> diff --git a/drivers/i2c/busses/i2c-designware-common.c b/drivers/i2c/busses/i2c-designware-common.c
> index 6357c7c78f6d..24641635aa20 100644
> --- a/drivers/i2c/busses/i2c-designware-common.c
> +++ b/drivers/i2c/busses/i2c-designware-common.c
> @@ -56,6 +56,13 @@ static char *abort_sources[] = {
> "trying to use disabled adapter",
> [ARB_LOST] =
> "lost arbitration",
> + [ABRT_SLAVE_FLUSH_TXFIFO] =
> + "read command so flush old data in the TX FIFO",
> + [ABRT_SLAVE_ARBLOST] =
> + "slave lost the bus while transmitting data to a remote master",
> + [ABRT_SLAVE_RD_INTX] =
> + "slave request for data to be transmitted and there is a 1 in "
> + "bit 8 of IC_DATA_CMD",
> };
I know ABRT_SLAVE_RD_INTX case is from the specification but I would
prefer here one-line error text so it will be easier to grep from sources.
I would like it to be also be more understandable. I don't know did I
understood it correctly but does it occur when attempting to read
controller while transmitting or something like that?
> diff --git a/drivers/i2c/busses/i2c-designware-core.h b/drivers/i2c/busses/i2c-designware-core.h
> index b620d76ffc8d..6c70945cccea 100644
> --- a/drivers/i2c/busses/i2c-designware-core.h
> +++ b/drivers/i2c/busses/i2c-designware-core.h
> @@ -277,6 +277,7 @@ struct dw_i2c_dev {
> void (*disable)(struct dw_i2c_dev *dev);
> void (*disable_int)(struct dw_i2c_dev *dev);
> int (*init)(struct dw_i2c_dev *dev);
> + bool mode;
> };
>
As I mentioned add here comment for "mode" not in patch 4/6.
--
Jarkko
next prev parent reply other threads:[~2017-03-02 14:38 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-01 15:59 [RESEND PATCH v6 0/6] i2c: designware: add I2C SLAVE support Luis Oliveira
2017-03-01 15:59 ` [RESEND PATCH v6 1/6] i2c: designware: Cleaning and comment style fixes Luis Oliveira
2017-03-01 15:59 ` [RESEND PATCH v6 2/6] i2c: designware: refactoring of the i2c-designware Luis Oliveira
2017-03-02 13:40 ` Jarkko Nikula
2017-03-01 15:59 ` [RESEND PATCH v6 3/6] i2c: designware: MASTER mode as separated driver Luis Oliveira
2017-03-02 13:41 ` Jarkko Nikula
2017-03-02 15:34 ` Luis Oliveira
2017-03-02 20:28 ` kbuild test robot
2017-03-02 22:36 ` kbuild test robot
2017-03-01 15:59 ` [RESEND PATCH v6 4/6] i2c: designware: introducing I2C_SLAVE definitions Luis Oliveira
2017-03-02 13:46 ` Jarkko Nikula
2017-03-01 15:59 ` [RESEND PATCH v6 5/6] i2c: designware: add SLAVE mode functions Luis Oliveira
2017-03-02 14:33 ` Jarkko Nikula [this message]
2017-03-02 15:17 ` Luis Oliveira
2017-03-17 11:24 ` Luis Oliveira
2017-03-17 13:29 ` Jarkko Nikula
2017-03-01 15:59 ` [RESEND PATCH v6 6/6] i2c: designware: enable SLAVE in platform module Luis Oliveira
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=be10879b-a81b-9047-6c67-45916a85ef31@linux.intel.com \
--to=jarkko.nikula@linux.intel.com \
--cc=CARLOS.PALMINHA@synopsys.com \
--cc=Joao.Pinto@synopsys.com \
--cc=Luis.Oliveira@synopsys.com \
--cc=Ramiro.Oliveira@synopsys.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=devicetree@vger.kernel.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mika.westerberg@linux.intel.com \
--cc=robh+dt@kernel.org \
--cc=wsa@the-dreams.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).