From: "Kim, Milo" <milo.kim@ti.com>
To: Rob Herring <robh@kernel.org>
Cc: Mark Brown <broonie@kernel.org>, <devicetree@vger.kernel.org>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/2] Documentation: dt-bindings: Use generic property for hardware enable pins
Date: Fri, 3 Mar 2017 15:56:15 +0900 [thread overview]
Message-ID: <be14e98c-62c8-10bd-fc36-d7c146f39194@ti.com> (raw)
In-Reply-To: <20170303062119.kdogozkkhsvwewwa@rob-hp-laptop>
On 3/3/2017 3:21 PM, Rob Herring wrote:
> On Tue, Feb 28, 2017 at 04:50:40PM +0900, Milo Kim wrote:
>> With index usages, device specific properties can be replaced with generic
>> one. Vpos is index 0 and Vneg is index 1.
>> DT examples are added as well.
>>
>> Signed-off-by: Milo Kim <milo.kim@ti.com>
>> ---
>> .../bindings/regulator/lm363x-regulator.txt | 78 +++++++++++++++++++++-
>> 1 file changed, 76 insertions(+), 2 deletions(-)
>>
>> diff --git a/Documentation/devicetree/bindings/regulator/lm363x-regulator.txt b/Documentation/devicetree/bindings/regulator/lm363x-regulator.txt
>> index 8f14df9d1205..cc5a6151d85f 100644
>> --- a/Documentation/devicetree/bindings/regulator/lm363x-regulator.txt
>> +++ b/Documentation/devicetree/bindings/regulator/lm363x-regulator.txt
>> @@ -8,8 +8,8 @@ Required property:
>>
>> Optional properties:
>> LM3632 has external enable pins for two LDOs.
>> - - ti,lcm-en1-gpio: A GPIO specifier for Vpos control pin.
>> - - ti,lcm-en2-gpio: A GPIO specifier for Vneg control pin.
>> + - enable-gpios: Two GPIO specifiers for Vpos and Vneg control pins.
>> + The first entry is Vpos, the second is Vneg enable pin.
>
> You're breaking compatibility with existing DTBs. You need to explain
> that and why it is okay in the commit message. In this case, I don't
> think it is okay as this chip could be used across vendors' platforms.
Thanks for your comment.
The lm363x-regulator has a dependency on ti-lmu MFD driver which is not
upstreamed. So I don't think this patch will break the compatibility
because two properties are not used anywhere at this moment.
Please correct me if it's incorrect.
Using general DT property is simple/clear because two enable pins are
differentiable by selecting the index number. That's the main reason of
this patch.
Best regards,
Milo
next prev parent reply other threads:[~2017-03-03 7:14 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-28 7:50 [PATCH 1/2] Documentation: dt-bindings: Use generic property for hardware enable pins Milo Kim
2017-02-28 7:50 ` [PATCH 2/2] regulator: lm363x: Use generic DT property name for external control pins Milo Kim
2017-03-07 14:21 ` Applied "regulator: lm363x: Use generic DT property name for external control pins" to the regulator tree Mark Brown
2017-03-03 6:21 ` [PATCH 1/2] Documentation: dt-bindings: Use generic property for hardware enable pins Rob Herring
2017-03-03 6:56 ` Kim, Milo [this message]
2017-03-07 13:56 ` Mark Brown
2017-03-07 14:21 ` Applied "regulator: lm363x: Use generic property for hardware enable pins" to the regulator tree Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=be14e98c-62c8-10bd-fc36-d7c146f39194@ti.com \
--to=milo.kim@ti.com \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).