From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1030413AbcJ0PuC (ORCPT ); Thu, 27 Oct 2016 11:50:02 -0400 Received: from vern.gendns.com ([206.190.152.46]:45878 "EHLO vern.gendns.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756030AbcJ0PuB (ORCPT ); Thu, 27 Oct 2016 11:50:01 -0400 Subject: Re: [PATCH 4/5] ARM: davinci: enable LEDs default-on trigger in default config To: Sekhar Nori , Kevin Hilman References: <1477075018-20176-1-git-send-email-david@lechnology.com> <1477075018-20176-5-git-send-email-david@lechnology.com> <669b14c2-7f62-35bc-c8a3-6dde05a99fb1@ti.com> Cc: Rob Herring , Mark Rutland , Russell King , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org From: David Lechner Message-ID: Date: Thu, 27 Oct 2016 10:49:57 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.3.0 MIME-Version: 1.0 In-Reply-To: <669b14c2-7f62-35bc-c8a3-6dde05a99fb1@ti.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - vern.gendns.com X-AntiAbuse: Original Domain - vger.kernel.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - lechnology.com X-Get-Message-Sender-Via: vern.gendns.com: authenticated_id: davidmain+lechnology.com/only user confirmed/virtual account not confirmed X-Authenticated-Sender: vern.gendns.com: davidmain@lechnology.com X-Source: X-Source-Args: X-Source-Dir: Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 10/27/2016 06:29 AM, Sekhar Nori wrote: > On Saturday 22 October 2016 12:06 AM, David Lechner wrote: >> The LEDs default-on trigger is nice to have. For example, it can be used >> to configure a LED as a power indicator. >> >> Signed-off-by: David Lechner >> --- >> arch/arm/configs/davinci_all_defconfig | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/arch/arm/configs/davinci_all_defconfig b/arch/arm/configs/davinci_all_defconfig >> index 9d7f0bc..e380743 100644 >> --- a/arch/arm/configs/davinci_all_defconfig >> +++ b/arch/arm/configs/davinci_all_defconfig >> @@ -181,6 +181,7 @@ CONFIG_LEDS_GPIO=m >> CONFIG_LEDS_TRIGGERS=y >> CONFIG_LEDS_TRIGGER_TIMER=m >> CONFIG_LEDS_TRIGGER_HEARTBEAT=m >> +CONFIG_LEDS_TRIGGER_DEFAULT_ON=y > > Can this be module like rest of the triggers? It will come on later, but > not sure if you care about the difference that much. Having it a module > will be better for those boards that don't need it. > > Thanks, > Sekhar > Yes, module is OK here.