linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: Linux-Renesas <linux-renesas-soc@vger.kernel.org>,
	"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" 
	<devicetree@vger.kernel.org>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2] arm64: dts: renesas: falcon-cpu: Add GP LEDs
Date: Mon, 29 Mar 2021 10:15:17 +0100	[thread overview]
Message-ID: <be500812-d3e3-4499-c6e0-504773520087@ideasonboard.com> (raw)
In-Reply-To: <CAMuHMdVzW=pAbJzSmC3Wt3zH4F8kUfd-s0JkQeg5NdPsGJAVrw@mail.gmail.com>

Hi Geert,

On 29/03/2021 09:30, Geert Uytterhoeven wrote:
> Hi Kieran,
> 
> On Mon, Mar 22, 2021 at 6:20 PM Kieran Bingham
> <kieran.bingham+renesas@ideasonboard.com> wrote:
>> Three general purpose LEDs are provided on the Falcon CPU board.
>>
>> Connect GP_LED1, GP_LED2, and GP_LED3 to the gpio-leds frameworks as
>> indicator LEDs.
>>
>> These LEDs are arranged in a block of four LEDs on the board itself, but
>> the fourth LED is as yet unidentified.
>>
>> Signed-off-by: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>
> 
> Thanks for your patch (which does not apply against renesas-devel)!

Oh, I'm sure I was based on renesas-devel/master when submitting that...
I guess I need to rebase my branch again.

> 
>> --
> 
> --- ;-)

Yup - sorry ;-)

> 
>> v2:
>>  - Move to r8a779a0-falcon-cpu.dtsi
>>  - Define the colour, and function.
> 
>> --- a/arch/arm64/boot/dts/renesas/r8a779a0-falcon-cpu.dtsi
>> +++ b/arch/arm64/boot/dts/renesas/r8a779a0-falcon-cpu.dtsi
>> @@ -6,12 +6,37 @@
>>   */
>>
>>  #include <dt-bindings/gpio/gpio.h>
>> +#include <dt-bindings/leds/common.h>
>> +
>>  #include "r8a779a0.dtsi"
>>
>>  / {
>>         model = "Renesas Falcon CPU board";
>>         compatible = "renesas,falcon-cpu", "renesas,r8a779a0";
>>
>> +       leds {
>> +               compatible = "gpio-leds";
>> +
>> +               led1 {
> 
> led-1?
> 
> Documentation/devicetree/bindings/leds/leds-gpio.yaml says:
> 
>   # The first form is preferred, but fall back to just 'led' anywhere in the
>   # node name to at least catch some child nodes.
>   "(^led-[0-9a-f]$|led)":

Aha so picky ;-)


>> +                       gpios = <&gpio4 18 GPIO_ACTIVE_HIGH>;
>> +                       color = <LED_COLOR_ID_GREEN>;
>> +                       function = LED_FUNCTION_INDICATOR;
>> +                       function-enumerator = <1>;
>> +               };
>> +               led2 {
>> +                       gpios = <&gpio4 19 GPIO_ACTIVE_HIGH>;
>> +                       color = <LED_COLOR_ID_GREEN>;
>> +                       function = LED_FUNCTION_INDICATOR;
>> +                       function-enumerator = <2>;
>> +               };
>> +               led3 {
>> +                       gpios = <&gpio4 20 GPIO_ACTIVE_HIGH>;
>> +                       color = <LED_COLOR_ID_GREEN>;
>> +                       function = LED_FUNCTION_INDICATOR;
>> +                       function-enumerator = <3>;
>> +               };
>> +       };
>> +
>>         memory@48000000 {
>>                 device_type = "memory";
>>                 /* first 128MB is reserved for secure area. */
> 
> Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
> i.e. will queue in renesas-devel for v5.13, with the above fixed.

Thanks.

For reference only, As previously discussed there is a fourth led in
this block of LEDs arranged on the board.

I can only confirm that it is not controllable by either GPIO4{17,21}.

But I have not been able to locate what might be controlling it.

So for now, it remains ignored. It might not be the safest to go
flipping all of the GPIOs randomly on this board ;-)

--
Kieran


> 
> Gr{oetje,eeting}s,
> 
>                         Geert
> 


      reply	other threads:[~2021-03-29  9:16 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-03-22 17:20 Kieran Bingham
2021-03-29  8:30 ` Geert Uytterhoeven
2021-03-29  9:15   ` Kieran Bingham [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=be500812-d3e3-4499-c6e0-504773520087@ideasonboard.com \
    --to=kieran.bingham+renesas@ideasonboard.com \
    --cc=devicetree@vger.kernel.org \
    --cc=geert@linux-m68k.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-renesas-soc@vger.kernel.org \
    --subject='Re: [PATCH v2] arm64: dts: renesas: falcon-cpu: Add GP LEDs' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).