linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jacek Anaszewski <jacek.anaszewski@gmail.com>
To: Krzysztof Kozlowski <krzk@kernel.org>,
	Pavel Machek <pavel@ucw.cz>, Rob Herring <robh+dt@kernel.org>,
	Mark Rutland <mark.rutland@arm.com>,
	Baolin Wang <baolin.wang@linaro.org>,
	linux-leds@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 0/5] leds: trigger: Add pattern initialization from Device Tree
Date: Mon, 10 Dec 2018 22:03:18 +0100	[thread overview]
Message-ID: <be526095-5af9-38bb-7c72-629a82d318e0@gmail.com> (raw)
In-Reply-To: <1544434201-14190-1-git-send-email-krzk@kernel.org>

Hi Krzysztof,

Thank you for the update.

On 12/10/18 10:29 AM, Krzysztof Kozlowski wrote:
> Hi,
> 
> I rebased on top of Jacek's patches and, as I could not find them on git kernel
> tree, I included them here. Also with small fixup.
> 
> Changes since v1:
> 1. Rebase on Jacek's patches.

Made following amendments to 2/5:

- removed extra empty line
- fixed language in the commit message as proposed by Pavel

> 2. Add patch 3/5 for fixup of Jacek's solution.
> 3. Drop first two patches from the series (applied).
> 4. Patch 5/5: Use LED_INIT_DEFAULT_TRIGGER (suggested by Jacek Anaszewski).
> 5. Patch 5/5: Return-on-error and log warning (suggested by Pavel Machek)
Applied to the for-next branch of linux-leds.git, thanks.

Pavel - I'm still awaiting your acks, just wanted to have
the patch set in linux-next quicker, taking into account that
merge window is imminent.

Best regards,
Jacek Anaszewski

> Jacek Anaszewski (2):
>    led: triggers: Break the for loop after default trigger is found
>    led: triggers: Add LED_INIT_DEFAULT_TRIGGER flag
> 
> Krzysztof Kozlowski (3):
>    led: triggers: Initialize LED_INIT_DEFAULT_TRIGGER if trigger is
>      brought after class
>    dt-bindings: leds: Add pattern initialization from Device Tree
>    leds: trigger: Add pattern initialization from Device Tree
> 
>   Documentation/devicetree/bindings/leds/common.txt |  7 +++++
>   drivers/leds/led-triggers.c                       | 10 +++++--
>   drivers/leds/trigger/ledtrig-pattern.c            | 32 +++++++++++++++++++++++
>   include/linux/leds.h                              |  1 +
>   4 files changed, 48 insertions(+), 2 deletions(-)
> 


  parent reply	other threads:[~2018-12-10 21:03 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-12-10  9:29 [PATCH v2 0/5] leds: trigger: Add pattern initialization from Device Tree Krzysztof Kozlowski
2018-12-10  9:29 ` [PATCH v2 1/5] led: triggers: Break the for loop after default trigger is found Krzysztof Kozlowski
2018-12-10  9:29 ` [PATCH v2 2/5] led: triggers: Add LED_INIT_DEFAULT_TRIGGER flag Krzysztof Kozlowski
2018-12-10  9:29 ` [PATCH v2 3/5] led: triggers: Initialize LED_INIT_DEFAULT_TRIGGER if trigger is brought after class Krzysztof Kozlowski
2018-12-10  9:30 ` [PATCH v2 4/5] dt-bindings: leds: Add pattern initialization from Device Tree Krzysztof Kozlowski
2018-12-11 17:23   ` Rob Herring
2018-12-12  8:42     ` Krzysztof Kozlowski
2018-12-10  9:30 ` [PATCH v2 5/5] leds: trigger: " Krzysztof Kozlowski
2018-12-10 21:03 ` Jacek Anaszewski [this message]
2018-12-12 12:16   ` [PATCH v2 0/5] " Pavel Machek
2018-12-12 19:18     ` Jacek Anaszewski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=be526095-5af9-38bb-7c72-629a82d318e0@gmail.com \
    --to=jacek.anaszewski@gmail.com \
    --cc=baolin.wang@linaro.org \
    --cc=devicetree@vger.kernel.org \
    --cc=krzk@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-leds@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=pavel@ucw.cz \
    --cc=robh+dt@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).