From: Jens Axboe <axboe@fb.com>
To: Tejun Heo <tj@kernel.org>, "axboe@kernel.dk" <axboe@kernel.dk>
Cc: "jack@suse.cz" <jack@suse.cz>,
"josef@toxicpanda.com" <josef@toxicpanda.com>,
Chris Mason <clm@fb.com>, "dsterba@suse.com" <dsterba@suse.com>,
"linux-block@vger.kernel.org" <linux-block@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-btrfs@vger.kernel.org" <linux-btrfs@vger.kernel.org>,
Kernel Team <Kernel-team@fb.com>
Subject: Re: [PATCHSET for-5.3/block] block: add blkcg bio punt mechanism
Date: Wed, 10 Jul 2019 13:53:11 +0000 [thread overview]
Message-ID: <be63af25-6245-18f8-4c0b-4f48682a34ed@fb.com> (raw)
In-Reply-To: <20190627203952.386785-1-tj@kernel.org>
On 6/27/19 2:39 PM, Tejun Heo wrote:
> Hello,
>
> This patchset contains only the block part of the following
>
> [1] [PATCHSET v2 btrfs/for-next] blkcg, btrfs: fix cgroup writeback support
>
> with the following changes
>
> * wbc_account_io() is renamed to wbc_account_cgroup_owner() and
> wbc->no_account_io to wbc->no_cgroup_owner for clarity.
>
> When writeback is executed asynchronously (e.g. for compression), bios
> are bounced to and issued by worker pool shared by all cgroups. This
> leads to significant priority inversions when cgroup IO control is in
> use - IOs for a low priority cgroup can tie down the workers forcing
> higher priority IOs to wait behind them.
>
> This patchset adds an bio punt mechanism to blkcg and updates btrfs to
> issue async IOs through it. A bio tagged with REQ_CGROUP_PUNT flag is
> bounced to the asynchronous issue context of the associated blkcg on
> bio_submit(). As the bios are issued from per-blkcg work items,
> there's no concern for priority inversions and it doesn't require
> invasive changes to the filesystems. The mechanism should be
> generally useful for IO control support across different filesystems.
Applied for 5.3, thanks Tejun.
--
Jens Axboe
prev parent reply other threads:[~2019-07-10 13:53 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-27 20:39 [PATCHSET for-5.3/block] block: add blkcg bio punt mechanism Tejun Heo
2019-06-27 20:39 ` [PATCH 1/5] cgroup, blkcg: Prepare some symbols for module and !CONFIG_CGROUP usages Tejun Heo
2019-06-27 20:39 ` [PATCH 2/5] blkcg, writeback: Rename wbc_account_io() to wbc_account_cgroup_owner() Tejun Heo
2019-07-10 10:54 ` Jan Kara
2019-06-27 20:39 ` [PATCH 3/5] blkcg, writeback: Add wbc->no_cgroup_owner Tejun Heo
2019-06-27 20:39 ` [PATCH 4/5] blkcg, writeback: Implement wbc_blkcg_css() Tejun Heo
2019-06-27 20:39 ` [PATCH 5/5] blkcg: implement REQ_CGROUP_PUNT Tejun Heo
2019-07-10 13:53 ` Jens Axboe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=be63af25-6245-18f8-4c0b-4f48682a34ed@fb.com \
--to=axboe@fb.com \
--cc=Kernel-team@fb.com \
--cc=axboe@kernel.dk \
--cc=clm@fb.com \
--cc=dsterba@suse.com \
--cc=jack@suse.cz \
--cc=josef@toxicpanda.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-btrfs@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).