From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id E8BD5C00140 for ; Fri, 5 Aug 2022 09:58:07 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240589AbiHEJ57 (ORCPT ); Fri, 5 Aug 2022 05:57:59 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53666 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236370AbiHEJ5s (ORCPT ); Fri, 5 Aug 2022 05:57:48 -0400 Received: from mail-ej1-x629.google.com (mail-ej1-x629.google.com [IPv6:2a00:1450:4864:20::629]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1E52377556 for ; Fri, 5 Aug 2022 02:57:46 -0700 (PDT) Received: by mail-ej1-x629.google.com with SMTP id m4so4140693ejr.3 for ; Fri, 05 Aug 2022 02:57:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=rasmusvillemoes.dk; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc; bh=Td4g1Kh1bfrx34l0/UewmcPgD1HP9zjlky++5KBl8rw=; b=MsVxcm9F8W6ERzILshCCpr8HgmZ2AKHSzQ/ShS6Rzh11nmJ2jC2qh16rOmKVAh7jSN qRC9Q7+XMu5FUEiho+8LDX6PTDBspcxZNBfY6kOqTu9Xw+ofqsBnY1CYPa9mG0R2fvWK 3JrAL1mmMyBkHxdEkTPwP+PoYRamjdU1Guigw= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc; bh=Td4g1Kh1bfrx34l0/UewmcPgD1HP9zjlky++5KBl8rw=; b=w0qdskdRrzh2vCvz5VTlLA0jKxl4tFCDyecYkTeZGWQ6QsVp7ZBBWsWcEBup8zVBU7 jnMIzNIp3IX3kEC0WLTodCakgawHKOM1Ur6oHu/799Krh6ru9wHyfo7bCTaPYBRJ/q98 Uz5ck2m+oEUEyWa4tmkdPJj4v2NauoETKID0O33B4ddAQ2VO0TT+zUDOYo0POgtm8wWR c6aDUSPnVtCBoocLZZlOPrzYeXLQN+9r36HYchxcrt66kmB+NNtUDEKQ1Rz7dzAqiMPt U9bgGE1lBoJ2QXwL9wf8IsAuNtBLMT9EAzsJy8tfrzLtB6vLCQKRJC6nqPrQM6GANwNo Q91w== X-Gm-Message-State: ACgBeo06BXXZLNo4vXPxSWRPOFDnacXJXVsh3e6Pn+uD0J/Y0lRf04NS yh+NID59QGqT6pe3fg8RpyrwVQ== X-Google-Smtp-Source: AA6agR6/awoYCaaW+MhRbzO2wn8SNzT6MJXkAEcUGdIJnR+2VTNEQg/Fz/9iNqBuznVDyPeQC6ji1w== X-Received: by 2002:a17:907:2856:b0:730:86f7:4fda with SMTP id el22-20020a170907285600b0073086f74fdamr4580504ejc.689.1659693464711; Fri, 05 Aug 2022 02:57:44 -0700 (PDT) Received: from [192.168.1.149] ([80.208.71.65]) by smtp.gmail.com with ESMTPSA id f1-20020a50fe01000000b0043d5ead65a6sm1780812edt.84.2022.08.05.02.57.43 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 05 Aug 2022 02:57:44 -0700 (PDT) Message-ID: Date: Fri, 5 Aug 2022 11:57:42 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH] net: phy: dp83867: fix get nvmem cell fail Content-Language: en-US To: Nikita Shubin Cc: linux@yadro.com, Nikita Shubin , Andrew Lunn , Heiner Kallweit , Russell King , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , netdev@vger.kernel.org, linux-kernel@vger.kernel.org References: <20220805084843.24542-1-nikita.shubin@maquefel.me> From: Rasmus Villemoes In-Reply-To: <20220805084843.24542-1-nikita.shubin@maquefel.me> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 05/08/2022 10.48, Nikita Shubin wrote: > From: Nikita Shubin > > If CONFIG_NVMEM is not set of_nvmem_cell_get, of_nvmem_device_get > functions will return ERR_PTR(-EOPNOTSUPP) and "failed to get nvmem > cell io_impedance_ctrl" error would be reported despite "io_impedance_ctrl" > is completely missing in Device Tree and we should use default values. > > Check -EOPNOTSUPP togather with -ENOENT to avoid this situation. Ah, sorry about that, and thanks for catching. Acked-by: Rasmus Villemoes