From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932337AbdDQPci (ORCPT ); Mon, 17 Apr 2017 11:32:38 -0400 Received: from mout.web.de ([212.227.17.12]:49900 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932198AbdDQPcd (ORCPT ); Mon, 17 Apr 2017 11:32:33 -0400 Subject: [PATCH 22/25] net: pxa168_eth: Adjust four checks for null pointers From: SF Markus Elfring To: netdev@vger.kernel.org, "David S. Miller" , Florian Fainelli , Jarod Wilson , Jisheng Zhang , Mirko Lindner , Philippe Reynes , Russell King , Sergei Shtylyov , Stephen Hemminger , Thomas Petazzoni Cc: LKML , kernel-janitors@vger.kernel.org References: Message-ID: Date: Mon, 17 Apr 2017 17:32:16 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-GB Content-Transfer-Encoding: 8bit X-Provags-ID: V03:K0:bkqJ9qwTk2GeA2haU5RG29MiFEZ3Wr4zQAf3zghGt06/1Wl5izg XK6zCKvQ6gmYsJNICFVe9CVifrjQcc81hG7on+4nY37kzq3DB6AnOSjFSGMLGEdXmoaeSuU WpD+6sFRBwkMp8kjY549PSdLyhlGGGaANiBonZgr8BEMDqwYalL7USFrnN/sZFEJEABDPuz EoM2bfG25TZvKOAv5xsxg== X-UI-Out-Filterresults: notjunk:1;V01:K0:McPYd7PbwC0=:AryaqG58jc9VZ4jPQAqXS3 e438IxXyJeqXZaKKoPsvAZorYa2lfr8wXF98izxGhWHFTUZKeIBdBCksyJ7KLtv595tVLy7qB czXBPrB1stfCGWltaTdrmZzRw/klyuo590XVq5YiKz8Z5BzQbqQnDNUUI+Di0Y5x1KhGYf8KU 89n+Sn5lcYicf1BDkCa+nIxzTcFHtXExsTxx8AdIgbkT8XtSsLvIEE32ye+CkpLmdbzkPUUu7 fksOCavHGJ6z6B3h0ssK0ULqKya/OoA3hWYil8puWL+kTGA9qoEdCClNFFS3Usf6qlqQaMu0h ol6GaCTvAR4NeTsvZmu6eLThoJ/rt64Ydubz4pWGC6o0cf9BV6YEXIKgJvTEbzOxV9Dirmrh3 h8k77XZCMjyD+nWM3KYYUg0eUtUJbFtqXooWxA7i4TS+YShlNy22OS4EodKQg7mSruWzBX+yi d9fBb6dr7cyinJE9KZ2NRGcjzGF296eIBw8EtmPUpXfsxKt0u5yiw7IHp4ttUgYFOnZ6Mb4WK ZTx7+OZdDnEVyvvoAR0uUoS5Lv8/0lk0EJEwtiEr67AgP6sJbC9uwD/Fx9vIrW7fC4Nb4ipCN wFaiwVOcXcIZkfX+Vjb3OTyeNv4l7TA8oYNjlL4paCDhuJnZDRMmwUS0hxeC7L89SL0UowVfy bkldU1yLDZ3IZYKmDhAAE21uins8n8aVaA1lP40s5ETDnl+MMB5YV/UDqCj9tLuAqNibt7e8M Je30qy3hDbFCdohIqPWlbvWkuHtWFss16t05XUJTRMHzjXQfbKfjMwkdGwWHN8N8kgaAAdl8D H5ikTw9 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Markus Elfring Date: Mon, 17 Apr 2017 15:23:45 +0200 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit The script “checkpatch.pl” pointed information out like the following. Comparison to NULL could be written … Thus fix the affected source code places. Signed-off-by: Markus Elfring --- drivers/net/ethernet/marvell/pxa168_eth.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/net/ethernet/marvell/pxa168_eth.c b/drivers/net/ethernet/marvell/pxa168_eth.c index 2404eac51c63..993724959a7c 100644 --- a/drivers/net/ethernet/marvell/pxa168_eth.c +++ b/drivers/net/ethernet/marvell/pxa168_eth.c @@ -556,11 +556,11 @@ static int init_hash_table(struct pxa168_eth_private *pep) * function.Driver can dynamically switch to them if the 1/2kB hash * table is full. */ - if (pep->htpr == NULL) { + if (!pep->htpr) { pep->htpr = dma_zalloc_coherent(pep->dev->dev.parent, HASH_ADDR_TABLE_SIZE, &pep->htpr_dma, GFP_KERNEL); - if (pep->htpr == NULL) + if (!pep->htpr) return -ENOMEM; } else { memset(pep->htpr, 0, HASH_ADDR_TABLE_SIZE); @@ -1356,7 +1356,7 @@ static int pxa168_smi_write(struct mii_bus *bus, int phy_addr, int regnum, static int pxa168_eth_do_ioctl(struct net_device *dev, struct ifreq *ifr, int cmd) { - if (dev->phydev != NULL) + if (dev->phydev) return phy_mii_ioctl(dev->phydev, ifr, cmd); return -EOPNOTSUPP; @@ -1501,7 +1501,7 @@ static int pxa168_eth_probe(struct platform_device *pdev) pep->timeout.data = (unsigned long)pep; pep->smi_bus = mdiobus_alloc(); - if (pep->smi_bus == NULL) { + if (!pep->smi_bus) { err = -ENOMEM; goto err_netdev; } -- 2.12.2