From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1760206AbdAJIp3 (ORCPT ); Tue, 10 Jan 2017 03:45:29 -0500 Received: from lucky1.263xmail.com ([211.157.147.130]:48864 "EHLO lucky1.263xmail.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750739AbdAJIp1 (ORCPT ); Tue, 10 Jan 2017 03:45:27 -0500 X-263anti-spam: KSV:0; X-MAIL-GRAY: 1 X-MAIL-DELIVERY: 0 X-KSVirus-check: 0 X-ABS-CHECKED: 4 X-RL-SENDER: shawn.lin@rock-chips.com X-FST-TO: kernel-janitors@vger.kernel.org X-SENDER-IP: 58.22.7.114 X-LOGIN-NAME: shawn.lin@rock-chips.com X-UNIQUE-TAG: <53e88e7865cc03db5e5aee432d230dc3> X-ATTACHMENT-NUM: 0 X-DNS-TYPE: 0 Subject: Re: [PATCH 1/8] mmc-core: Use kmalloc_array() in mmc_test_area_init() To: SF Markus Elfring , linux-mmc@vger.kernel.org, Adrian Hunter , Harjani Ritesh , Jens Axboe , Linus Walleij , Mike Christie , Ulf Hansson , Wolfram Sang References: <8e2accf5-90b3-6bd0-2abd-699927bc459b@users.sourceforge.net> Cc: shawn.lin@rock-chips.com, LKML , kernel-janitors@vger.kernel.org From: Shawn Lin Message-ID: Date: Tue, 10 Jan 2017 16:44:38 +0800 User-Agent: Mozilla/5.0 (Windows NT 6.3; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.6.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2017/1/9 5:42, SF Markus Elfring wrote: > From: Markus Elfring > Date: Sun, 8 Jan 2017 18:44:26 +0100 > > * A multiplication for the size determination of a memory allocation > indicated that an array data structure should be processed. > Thus use the corresponding function "kmalloc_array". > > This issue was detected by using the Coccinelle software. > Reviewed-by: Shawn Lin > * Replace the specification of a data structure by a pointer dereference > to make the corresponding size determination a bit safer according to > the Linux coding style convention. > > Signed-off-by: Markus Elfring > --- > drivers/mmc/core/mmc_test.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/mmc/core/mmc_test.c b/drivers/mmc/core/mmc_test.c > index 3ab6e52d106c..e85ef503d7ce 100644 > --- a/drivers/mmc/core/mmc_test.c > +++ b/drivers/mmc/core/mmc_test.c > @@ -1579,7 +1579,7 @@ static int mmc_test_area_init(struct mmc_test_card *test, int erase, int fill) > if (!t->mem) > return -ENOMEM; > > - t->sg = kmalloc(sizeof(struct scatterlist) * t->max_segs, GFP_KERNEL); > + t->sg = kmalloc_array(t->max_segs, sizeof(*t->sg), GFP_KERNEL); > if (!t->sg) { > ret = -ENOMEM; > goto out_free; > -- Best Regards Shawn Lin