From: "Andrew Jeffery" <andrew@aj.id.au>
To: "Eddie James" <eajames@linux.ibm.com>, linux-kernel@vger.kernel.org
Cc: devicetree@vger.kernel.org, "Jason Cooper" <jason@lakedaemon.net>,
linux-aspeed@lists.ozlabs.org, "Marc Zyngier" <maz@kernel.org>,
"Rob Herring" <robh+dt@kernel.org>,
tglx@linutronix.de, mark.rutland@arm.com,
"Joel Stanley" <joel@jms.id.au>
Subject: Re: [PATCH v2 03/12] ARM: dts: aspeed: ast2500: Add SCU interrupt controller
Date: Wed, 11 Dec 2019 11:06:42 +1030 [thread overview]
Message-ID: <beb61d28-7284-44bb-8da8-2fb0b8a4ab5a@www.fastmail.com> (raw)
In-Reply-To: <1575566112-11658-4-git-send-email-eajames@linux.ibm.com>
On Fri, 6 Dec 2019, at 03:45, Eddie James wrote:
> Add a node for the interrupt controller provided by the SCU.
>
> Signed-off-by: Eddie James <eajames@linux.ibm.com>
> ---
> arch/arm/boot/dts/aspeed-g5.dtsi | 10 +++++++++-
> 1 file changed, 9 insertions(+), 1 deletion(-)
>
> diff --git a/arch/arm/boot/dts/aspeed-g5.dtsi b/arch/arm/boot/dts/aspeed-g5.dtsi
> index a259c63..df44022 100644
> --- a/arch/arm/boot/dts/aspeed-g5.dtsi
> +++ b/arch/arm/boot/dts/aspeed-g5.dtsi
> @@ -216,8 +216,9 @@
> syscon: syscon@1e6e2000 {
> compatible = "aspeed,ast2500-scu", "syscon", "simple-mfd";
> reg = <0x1e6e2000 0x1a8>;
> + ranges = <0 0x1e6e2000 0x1a8>;
> #address-cells = <1>;
> - #size-cells = <0>;
> + #size-cells = <1>;
You're no-longer adding a reg property to the interrupt controller node below so the
hunk above is unnecessary.
Andrew
> #clock-cells = <1>;
> #reset-cells = <1>;
>
> @@ -231,6 +232,13 @@
> compatible = "aspeed,ast2500-p2a-ctrl";
> status = "disabled";
> };
> +
> + scu_ic: interrupt-controller@18 {
> + #interrupt-cells = <1>;
> + compatible = "aspeed,ast2500-scu-ic";
> + interrupts = <21>;
> + interrupt-controller;
> + };
> };
>
> rng: hwrng@1e6e2078 {
> --
> 1.8.3.1
>
>
next prev parent reply other threads:[~2019-12-11 0:35 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-05 17:15 [PATCH v2 00/12] Aspeed: Add SCU interrupt controller and XDMA engine drivers Eddie James
2019-12-05 17:15 ` [PATCH v2 01/12] dt-bindings: interrupt-controller: Add Aspeed SCU interrupt controller Eddie James
2019-12-10 23:32 ` Andrew Jeffery
2019-12-05 17:15 ` [PATCH v2 02/12] irqchip: " Eddie James
2019-12-11 0:32 ` Andrew Jeffery
2019-12-05 17:15 ` [PATCH v2 03/12] ARM: dts: aspeed: ast2500: Add " Eddie James
2019-12-11 0:36 ` Andrew Jeffery [this message]
2019-12-05 17:15 ` [PATCH v2 04/12] ARM: dts: aspeed: ast2600: Add SCU interrupt controllers Eddie James
2019-12-11 0:42 ` Andrew Jeffery
2019-12-05 17:15 ` [PATCH v2 05/12] dt-bindings: soc: Add Aspeed XDMA Engine Eddie James
2019-12-11 0:40 ` Andrew Jeffery
2019-12-05 17:15 ` [PATCH v2 06/12] drivers/soc: Add Aspeed XDMA Engine Driver Eddie James
2019-12-11 3:47 ` Andrew Jeffery
2019-12-11 20:39 ` Eddie James
2019-12-12 4:52 ` Andrew Jeffery
2019-12-12 19:16 ` Eddie James
2019-12-13 1:42 ` Andrew Jeffery
2019-12-05 17:15 ` [PATCH v2 07/12] drivers/soc: xdma: Add user interface Eddie James
2019-12-11 3:48 ` Andrew Jeffery
2019-12-11 20:43 ` Eddie James
2019-12-12 5:02 ` Andrew Jeffery
2019-12-05 17:15 ` [PATCH v2 08/12] ARM: dts: aspeed: ast2500: Add XDMA Engine Eddie James
2019-12-05 17:15 ` [PATCH v2 09/12] ARM: dts: aspeed: ast2600: " Eddie James
2019-12-11 3:48 ` Andrew Jeffery
2019-12-05 17:15 ` [PATCH v2 10/12] ARM: dts: aspeed: witherspoon: Enable " Eddie James
2019-12-05 17:15 ` [PATCH v2 11/12] ARM: dts: aspeed: rainier: Enable XDMA engine Eddie James
2019-12-05 17:15 ` [PATCH v2 12/12] ARM: dts: aspeed: tacoma: " Eddie James
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=beb61d28-7284-44bb-8da8-2fb0b8a4ab5a@www.fastmail.com \
--to=andrew@aj.id.au \
--cc=devicetree@vger.kernel.org \
--cc=eajames@linux.ibm.com \
--cc=jason@lakedaemon.net \
--cc=joel@jms.id.au \
--cc=linux-aspeed@lists.ozlabs.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=maz@kernel.org \
--cc=robh+dt@kernel.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).