* [PATCH] arc: kernel: Return -EFAULT if copy_to_user() fails
@ 2021-03-01 12:05 Wang Qing
2021-03-02 19:01 ` Vineet Gupta
0 siblings, 1 reply; 3+ messages in thread
From: Wang Qing @ 2021-03-01 12:05 UTC (permalink / raw)
To: Vineet Gupta, Jens Axboe, Wang Qing, Thomas Gleixner,
Gustavo A. R. Silva, linux-snps-arc, linux-kernel
The copy_to_user() function returns the number of bytes remaining to be
copied, but we want to return -EFAULT if the copy doesn't complete.
Signed-off-by: Wang Qing <wangqing@vivo.com>
---
arch/arc/kernel/signal.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/arc/kernel/signal.c b/arch/arc/kernel/signal.c
index a78d8f7..fdbe06c
--- a/arch/arc/kernel/signal.c
+++ b/arch/arc/kernel/signal.c
@@ -96,7 +96,7 @@ stash_usr_regs(struct rt_sigframe __user *sf, struct pt_regs *regs,
sizeof(sf->uc.uc_mcontext.regs.scratch));
err |= __copy_to_user(&sf->uc.uc_sigmask, set, sizeof(sigset_t));
- return err;
+ return err ? -EFAULT : 0;
}
static int restore_usr_regs(struct pt_regs *regs, struct rt_sigframe __user *sf)
@@ -110,7 +110,7 @@ static int restore_usr_regs(struct pt_regs *regs, struct rt_sigframe __user *sf)
&(sf->uc.uc_mcontext.regs.scratch),
sizeof(sf->uc.uc_mcontext.regs.scratch));
if (err)
- return err;
+ return -EFAULT;
set_current_blocked(&set);
regs->bta = uregs.scratch.bta;
--
2.7.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] arc: kernel: Return -EFAULT if copy_to_user() fails
2021-03-01 12:05 [PATCH] arc: kernel: Return -EFAULT if copy_to_user() fails Wang Qing
@ 2021-03-02 19:01 ` Vineet Gupta
2021-03-10 2:41 ` 王擎
0 siblings, 1 reply; 3+ messages in thread
From: Vineet Gupta @ 2021-03-02 19:01 UTC (permalink / raw)
To: Wang Qing, Jens Axboe, Thomas Gleixner, Gustavo A. R. Silva,
linux-snps-arc, linux-kernel
On 3/1/21 4:05 AM, Wang Qing wrote:
> The copy_to_user() function returns the number of bytes remaining to be
> copied, but we want to return -EFAULT if the copy doesn't complete.
>
> Signed-off-by: Wang Qing <wangqing@vivo.com>
Acked-by: Vineet Gupta <vgupta@synopsys.com>
Do you want me to pick this up via ARC tree ?
Thx,
-Vineet
> ---
> arch/arc/kernel/signal.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arc/kernel/signal.c b/arch/arc/kernel/signal.c
> index a78d8f7..fdbe06c
> --- a/arch/arc/kernel/signal.c
> +++ b/arch/arc/kernel/signal.c
> @@ -96,7 +96,7 @@ stash_usr_regs(struct rt_sigframe __user *sf, struct pt_regs *regs,
> sizeof(sf->uc.uc_mcontext.regs.scratch));
> err |= __copy_to_user(&sf->uc.uc_sigmask, set, sizeof(sigset_t));
>
> - return err;
> + return err ? -EFAULT : 0;
> }
>
> static int restore_usr_regs(struct pt_regs *regs, struct rt_sigframe __user *sf)
> @@ -110,7 +110,7 @@ static int restore_usr_regs(struct pt_regs *regs, struct rt_sigframe __user *sf)
> &(sf->uc.uc_mcontext.regs.scratch),
> sizeof(sf->uc.uc_mcontext.regs.scratch));
> if (err)
> - return err;
> + return -EFAULT;
>
> set_current_blocked(&set);
> regs->bta = uregs.scratch.bta;
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re:Re: [PATCH] arc: kernel: Return -EFAULT if copy_to_user() fails
2021-03-02 19:01 ` Vineet Gupta
@ 2021-03-10 2:41 ` 王擎
0 siblings, 0 replies; 3+ messages in thread
From: 王擎 @ 2021-03-10 2:41 UTC (permalink / raw)
To: Vineet Gupta; +Cc: linux-kernel
Subject: Re: [PATCH] arc: kernel: Return -EFAULT if copy_to_user() fails>On 3/1/21 4:05 AM, Wang Qing wrote:
>> The copy_to_user() function returns the number of bytes remaining to be
>> copied, but we want to return -EFAULT if the copy doesn't complete.
>>
>> Signed-off-by: Wang Qing <wangqing@vivo.com>
>
>Acked-by: Vineet Gupta <vgupta@synopsys.com>
>
>Do you want me to pick this up via ARC tree ?
Yes, thank you for picking this up.
Wangqing
>
>Thx,
>-Vineet
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-03-10 2:51 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-03-01 12:05 [PATCH] arc: kernel: Return -EFAULT if copy_to_user() fails Wang Qing
2021-03-02 19:01 ` Vineet Gupta
2021-03-10 2:41 ` 王擎
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).