From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.4 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A2854C43464 for ; Thu, 17 Sep 2020 23:36:55 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 5A40720874 for ; Thu, 17 Sep 2020 23:36:55 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="DpNU85rB" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726135AbgIQXgy (ORCPT ); Thu, 17 Sep 2020 19:36:54 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59150 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725987AbgIQXgy (ORCPT ); Thu, 17 Sep 2020 19:36:54 -0400 Received: from casper.infradead.org (casper.infradead.org [IPv6:2001:8b0:10b:1236::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E4E6FC06174A; Thu, 17 Sep 2020 16:36:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=Content-Transfer-Encoding:Content-Type: In-Reply-To:MIME-Version:Date:Message-ID:From:References:Cc:To:Subject:Sender :Reply-To:Content-ID:Content-Description; bh=L/ik8xWQGsvCl/IsgAaxVy6/l+78WiZ2kJbVDcmurfY=; b=DpNU85rBpi9QWuwMXSt0RSN27K hVOTDjhXYcEbg7fIU+WHVF8s0R44HWDiTrXVJPDFswR9YXCbV2JU76RRB44b5F09eyf+wR21Gm2zD B90HvTFceK5krxzoTUueFEMxnm8nrWiqsJqHpXv3YIqOyLiGke3oyf+8AKoaynxca5uhj7t823Q87 9IRELZdXHXR/8jG+N+OUEvVj0whCZThAxsiv8yqxQOk/NvgIqXZMDFISMzlQekzdJYWpSWUF7N5b9 oAmK/usXYPdUIoxqfDgrGmdbgHhsemaXzBXnlAfhdRs6AvXbzudjQxvRR6U92IqzFvEn2HfPF6GF7 LK/7A9Pg==; Received: from [2601:1c0:6280:3f0::19c2] by casper.infradead.org with esmtpsa (Exim 4.92.3 #3 (Red Hat Linux)) id 1kJ3SN-0000dd-NW; Thu, 17 Sep 2020 23:36:52 +0000 Subject: Re: [PATCH v1 2/3] bus: mhi: core: Introduce debugfs entries for MHI To: Bhaumik Bhatt , manivannan.sadhasivam@linaro.org Cc: linux-arm-msm@vger.kernel.org, hemantk@codeaurora.org, jhugo@codeaurora.org, linux-kernel@vger.kernel.org References: <1600381176-37604-1-git-send-email-bbhatt@codeaurora.org> <1600381176-37604-3-git-send-email-bbhatt@codeaurora.org> From: Randy Dunlap Message-ID: Date: Thu, 17 Sep 2020 16:36:47 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.12.0 MIME-Version: 1.0 In-Reply-To: <1600381176-37604-3-git-send-email-bbhatt@codeaurora.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 9/17/20 3:19 PM, Bhaumik Bhatt wrote: > diff --git a/drivers/bus/mhi/Kconfig b/drivers/bus/mhi/Kconfig > index a8bd9bd..ae68347 100644 > --- a/drivers/bus/mhi/Kconfig > +++ b/drivers/bus/mhi/Kconfig > @@ -12,3 +12,11 @@ config MHI_BUS > communication protocol used by the host processors to control > and communicate with modem devices over a high speed peripheral > bus or shared memory. > + > +config MHI_BUS_DEBUG > + bool "Debugfs support for the MHI bus" > + depends on MHI_BUS && DEBUG_FS > + help > + Enable debugfs support for use with the MHI transport. Allows > + reading and/or modifying some values within the MHI controller > + for debug and test purposes. from Documentation/process/coding-style.rst: """For all of the Kconfig* configuration files throughout the source tree, the indentation is somewhat different. Lines under a ``config`` definition are indented with one tab, while help text is indented an additional two spaces.""" Several lines above use spaces instead of one tab... -- ~Randy