From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B4A10C32789 for ; Fri, 2 Nov 2018 08:44:36 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 76F772081B for ; Fri, 2 Nov 2018 08:44:36 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 76F772081B Authentication-Results: mail.kernel.org; dmarc=fail (p=quarantine dis=none) header.from=ti.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726315AbeKBRu6 (ORCPT ); Fri, 2 Nov 2018 13:50:58 -0400 Received: from lelv0142.ext.ti.com ([198.47.23.249]:43310 "EHLO lelv0142.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726041AbeKBRu6 (ORCPT ); Fri, 2 Nov 2018 13:50:58 -0400 Received: from lelv0265.itg.ti.com ([10.180.67.224]) by lelv0142.ext.ti.com (8.15.2/8.15.2) with ESMTP id wA28i6o3124228; Fri, 2 Nov 2018 03:44:06 -0500 Received: from DFLE105.ent.ti.com (dfle105.ent.ti.com [10.64.6.26]) by lelv0265.itg.ti.com (8.15.2/8.15.2) with ESMTPS id wA28i6tP107886 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Fri, 2 Nov 2018 03:44:06 -0500 Received: from DFLE102.ent.ti.com (10.64.6.23) by DFLE105.ent.ti.com (10.64.6.26) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1466.3; Fri, 2 Nov 2018 03:44:06 -0500 Received: from dflp32.itg.ti.com (10.64.6.15) by DFLE102.ent.ti.com (10.64.6.23) with Microsoft SMTP Server (version=TLS1_0, cipher=TLS_RSA_WITH_AES_256_CBC_SHA) id 15.1.1466.3 via Frontend Transport; Fri, 2 Nov 2018 03:44:06 -0500 Received: from [172.24.190.233] (ileax41-snat.itg.ti.com [10.172.224.153]) by dflp32.itg.ti.com (8.14.3/8.13.8) with ESMTP id wA28i30V027758; Fri, 2 Nov 2018 03:44:04 -0500 Subject: Re: [PATCH v4 03/10] phy: sun4i-usb: add support for H6 USB2 PHY To: Icenowy Zheng , Rob Herring , Maxime Ripard , Chen-Yu Tsai CC: , , , References: <20181004122855.22981-1-icenowy@aosc.io> <20181004122855.22981-4-icenowy@aosc.io> <9cca3453d646f38793df411c4471d062769b4f72.camel@aosc.io> From: Kishon Vijay Abraham I Message-ID: Date: Fri, 2 Nov 2018 14:13:38 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.2.1 MIME-Version: 1.0 In-Reply-To: <9cca3453d646f38793df411c4471d062769b4f72.camel@aosc.io> Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 8bit X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 02/11/18 2:11 PM, Icenowy Zheng wrote: > 在 2018-10-04四的 20:28 +0800，Icenowy Zheng写道： >> The USB 2.0 PHY on Allwinner H6 SoC is similar to older Allwinner >> SoCs, >> with some USB0 quirk like A83T and PHY index 1/2 missing. >> >> Add support for it. >> >> Signed-off-by: Icenowy Zheng >> Reviewed-by: Chen-Yu Tsai > > Excuse me. > > Kishon, could you check PATCH 1~3 and queue them? > > Even if USB3 support is pending, USB2 support will still be useful, and > they're independent. I'll queue once -rc1 is tagged. Thanks Kishon > >> --- >> No changes in v4. >> >> Changes in v3: >> - Added Chen-Yu's Review tag. >> >> drivers/phy/allwinner/phy-sun4i-usb.c | 19 +++++++++++++++++-- >> 1 file changed, 17 insertions(+), 2 deletions(-) >> >> diff --git a/drivers/phy/allwinner/phy-sun4i-usb.c >> b/drivers/phy/allwinner/phy-sun4i-usb.c >> index 881078ff73f6..ae16854a770a 100644 >> --- a/drivers/phy/allwinner/phy-sun4i-usb.c >> +++ b/drivers/phy/allwinner/phy-sun4i-usb.c >> @@ -115,6 +115,7 @@ enum sun4i_usb_phy_type { >> sun8i_r40_phy, >> sun8i_v3s_phy, >> sun50i_a64_phy, >> + sun50i_h6_phy, >> }; >> >> struct sun4i_usb_phy_cfg { >> @@ -295,7 +296,8 @@ static int sun4i_usb_phy_init(struct phy *_phy) >> return ret; >> } >> >> - if (data->cfg->type == sun8i_a83t_phy) { >> + if (data->cfg->type == sun8i_a83t_phy || >> + data->cfg->type == sun50i_h6_phy) { >> if (phy->index == 0) { >> val = readl(data->base + data->cfg- >>> phyctl_offset); >> val |= PHY_CTL_VBUSVLDEXT; >> @@ -344,7 +346,8 @@ static int sun4i_usb_phy_exit(struct phy *_phy) >> struct sun4i_usb_phy_data *data = to_sun4i_usb_phy_data(phy); >> >> if (phy->index == 0) { >> - if (data->cfg->type == sun8i_a83t_phy) { >> + if (data->cfg->type == sun8i_a83t_phy || >> + data->cfg->type == sun50i_h6_phy) { >> void __iomem *phyctl = data->base + >> data->cfg->phyctl_offset; >> >> @@ -959,6 +962,17 @@ static const struct sun4i_usb_phy_cfg >> sun50i_a64_cfg = { >> .phy0_dual_route = true, >> }; >> >> +static const struct sun4i_usb_phy_cfg sun50i_h6_cfg = { >> + .num_phys = 4, >> + .type = sun50i_h6_phy, >> + .disc_thresh = 3, >> + .phyctl_offset = REG_PHYCTL_A33, >> + .dedicated_clocks = true, >> + .enable_pmu_unk1 = true, >> + .phy0_dual_route = true, >> + .missing_phys = BIT(1) | BIT(2), >> +}; >> + >> static const struct of_device_id sun4i_usb_phy_of_match[] = { >> { .compatible = "allwinner,sun4i-a10-usb-phy", .data = >> &sun4i_a10_cfg }, >> { .compatible = "allwinner,sun5i-a13-usb-phy", .data = >> &sun5i_a13_cfg }, >> @@ -972,6 +986,7 @@ static const struct of_device_id >> sun4i_usb_phy_of_match[] = { >> { .compatible = "allwinner,sun8i-v3s-usb-phy", .data = >> &sun8i_v3s_cfg }, >> { .compatible = "allwinner,sun50i-a64-usb-phy", >> .data = &sun50i_a64_cfg}, >> + { .compatible = "allwinner,sun50i-h6-usb-phy", .data = >> &sun50i_h6_cfg }, >> { }, >> }; >> MODULE_DEVICE_TABLE(of, sun4i_usb_phy_of_match); >