From: Michael Walle <michael@walle.cc>
To: Tudor.Ambarus@microchip.com
Cc: linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org,
miquel.raynal@bootlin.com, richard@nod.at, vigneshr@ti.com,
boris.brezillon@collabora.com, stable@vger.kernel.org
Subject: Re: [PATCH v7 1/7] mtd: spi-nor: sst: fix BPn bits for the SST25VF064C
Date: Thu, 03 Dec 2020 15:39:40 +0100 [thread overview]
Message-ID: <bf31d41ca489b5d1b7976bfb8ede88e9@walle.cc> (raw)
In-Reply-To: <44be8e3c-86ca-501e-e575-55f17747bda6@microchip.com>
Am 2020-12-03 15:34, schrieb Tudor.Ambarus@microchip.com:
> On 12/3/20 1:00 AM, Michael Walle wrote:
>> EXTERNAL EMAIL: Do not click links or open attachments unless you know
>> the content is safe
>>
>> This flash part actually has 4 block protection bits.
>>
>> Reported-by: Tudor Ambarus <tudor.ambarus@microchip.com>
>> Cc: stable@vger.kernel.org # v5.7+
>
> While the patch is correct according to the datasheet, it was
> not tested, so it's not a candidate for stable. I would update
> the commit message to indicate that the the patch was made
> solely on datasheet info and not tested, I would add the fixes
> tag, and strip cc-ing to stable.
What is the difference? Any commit with a Fixes tag will also land
in the stable trees. Just that it will cause compile errors for
kernel older than 5.7.
So if you don't want to have it in stable then you must not add
a Fixes: tag either.
-michael
next prev parent reply other threads:[~2020-12-03 14:46 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-02 23:00 [PATCH v7 0/7] mtd: spi-nor: keep lock bits if they are non-volatile Michael Walle
2020-12-02 23:00 ` [PATCH v7 1/7] mtd: spi-nor: sst: fix BPn bits for the SST25VF064C Michael Walle
2020-12-03 14:34 ` Tudor.Ambarus
2020-12-03 14:39 ` Michael Walle [this message]
2020-12-03 15:08 ` Tudor.Ambarus
2020-12-03 18:24 ` Greg KH
2020-12-03 14:40 ` Tudor.Ambarus
2020-12-03 14:41 ` Michael Walle
2020-12-02 23:00 ` [PATCH v7 2/7] mtd: spi-nor: ignore errors in spi_nor_unlock_all() Michael Walle
2020-12-03 14:36 ` Tudor.Ambarus
2020-12-02 23:00 ` [PATCH v7 3/7] mtd: spi-nor: atmel: remove global protection flag Michael Walle
2020-12-02 23:00 ` [PATCH v7 4/7] mtd: spi-nor: sst: " Michael Walle
2020-12-02 23:00 ` [PATCH v7 5/7] mtd: spi-nor: intel: " Michael Walle
2020-12-02 23:00 ` [PATCH v7 6/7] mtd: spi-nor: atmel: fix unlock_all() for AT25FS010/040 Michael Walle
2020-12-03 14:44 ` Tudor.Ambarus
2020-12-02 23:00 ` [PATCH v7 7/7] mtd: spi-nor: keep lock bits if they are non-volatile Michael Walle
2020-12-03 14:51 ` Tudor.Ambarus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bf31d41ca489b5d1b7976bfb8ede88e9@walle.cc \
--to=michael@walle.cc \
--cc=Tudor.Ambarus@microchip.com \
--cc=boris.brezillon@collabora.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=miquel.raynal@bootlin.com \
--cc=richard@nod.at \
--cc=stable@vger.kernel.org \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).