From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 16C0AC46475 for ; Thu, 25 Oct 2018 06:23:46 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 9DBE92083E for ; Thu, 25 Oct 2018 06:23:45 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9DBE92083E Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727573AbeJYOzA (ORCPT ); Thu, 25 Oct 2018 10:55:00 -0400 Received: from foss.arm.com ([217.140.101.70]:51732 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727185AbeJYOzA (ORCPT ); Thu, 25 Oct 2018 10:55:00 -0400 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.72.51.249]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 53AE9A78; Wed, 24 Oct 2018 23:23:43 -0700 (PDT) Received: from [10.163.1.68] (unknown [10.163.1.68]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 3C20C3F627; Wed, 24 Oct 2018 23:23:37 -0700 (PDT) Subject: Re: [PATCH V3 3/5] mm/hugetlb: Enable arch specific huge page size support for migration To: Michal Hocko Cc: linux-mm@kvack.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, suzuki.poulose@arm.com, punit.agrawal@arm.com, will.deacon@arm.com, Steven.Price@arm.com, steve.capper@arm.com, catalin.marinas@arm.com, akpm@linux-foundation.org, mike.kravetz@oracle.com, n-horiguchi@ah.jp.nec.com References: <1540299721-26484-1-git-send-email-anshuman.khandual@arm.com> <1540299721-26484-4-git-send-email-anshuman.khandual@arm.com> <20181024135639.GH18839@dhcp22.suse.cz> <20181024135859.GI18839@dhcp22.suse.cz> From: Anshuman Khandual Message-ID: Date: Thu, 25 Oct 2018 11:53:34 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <20181024135859.GI18839@dhcp22.suse.cz> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 10/24/2018 07:28 PM, Michal Hocko wrote: > On Wed 24-10-18 15:56:39, Michal Hocko wrote: >> On Tue 23-10-18 18:31:59, Anshuman Khandual wrote: >>> Architectures like arm64 have HugeTLB page sizes which are different than >>> generic sizes at PMD, PUD, PGD level and implemented via contiguous bits. >>> At present these special size HugeTLB pages cannot be identified through >>> macros like (PMD|PUD|PGDIR)_SHIFT and hence chosen not be migrated. >>> >>> Enabling migration support for these special HugeTLB page sizes along with >>> the generic ones (PMD|PUD|PGD) would require identifying all of them on a >>> given platform. A platform specific hook can precisely enumerate all huge >>> page sizes supported for migration. Instead of comparing against standard >>> huge page orders let hugetlb_migration_support() function call a platform >>> hook arch_hugetlb_migration_support(). Default definition for the platform >>> hook maintains existing semantics which checks standard huge page order. >>> But an architecture can choose to override the default and provide support >>> for a comprehensive set of huge page sizes. >>> >>> Reviewed-by: Naoya Horiguchi >>> Signed-off-by: Anshuman Khandual >> >> Acked-by: Michal Hocko > > fat fingers here, should be mhocko@suse.com of course. Sure no problems. As we had discussed earlier and agreed to keep the previous patch "mm/hugetlb: Enable PUD level huge page migration" separate and not fold into this one, I will assume your ACK on it as well unless your disagree.