From: "Daniel Xu" <dxu@dxuuu.xyz>
To: "Andrii Nakryiko" <andrii.nakryiko@gmail.com>
Cc: "bpf@vger.kernel.org" <bpf@vger.kernel.org>,
"Song Liu" <songliubraving@fb.com>, "Yonghong Song" <yhs@fb.com>,
"Andrii Nakryiko" <andriin@fb.com>,
"Peter Ziljstra" <peterz@infradead.org>,
"Ingo Molnar" <mingo@redhat.com>,
"Arnaldo Carvalho de Melo" <acme@kernel.org>,
"Alexei Starovoitov" <ast@fb.com>,
alexander.shishkin@linux.intel.com,
"Jiri Olsa" <jolsa@redhat.com>,
"Namhyung Kim" <namhyung@kernel.org>,
"open list" <linux-kernel@vger.kernel.org>,
"Kernel Team" <kernel-team@fb.com>
Subject: Re: [PATCH v3 bpf-next 2/4] libbpf: Add helpers to extract perf fd from bpf_link
Date: Mon, 19 Aug 2019 14:30:06 -0700 [thread overview]
Message-ID: <bf85e622-afa9-4f9e-a41b-ba67be24a9e3@www.fastmail.com> (raw)
In-Reply-To: <CAEf4BzYbckCr2mxgsAn0z-fi-jxjvL5RGF4vdCLdfWgOzQfb-A@mail.gmail.com>
On Mon, Aug 19, 2019, at 10:45 AM, Andrii Nakryiko wrote:
> On Fri, Aug 16, 2019 at 3:32 PM Daniel Xu <dxu@dxuuu.xyz> wrote:
> >
> > It is sometimes necessary to perform ioctl's on the underlying perf fd.
> > There is not currently a way to extract the fd given a bpf_link, so add a
> > a pair of casting and getting helpers.
> >
> > The casting and getting helpers are nice because they let us define
> > broad categories of links that makes it clear to users what they can
> > expect to extract from what type of link.
> >
> > Acked-by: Song Liu <songliubraving@fb.com>
> > Signed-off-by: Daniel Xu <dxu@dxuuu.xyz>
> > ---
>
> This looks great, thanks a lot!
>
> I think you might have a conflict with dadb81d0afe7 ("libbpf: make
> libbpf.map source of truth for libbpf version") in libbpf.map, so you
> might need to pull, rebase and re-post rebased version. But in any
> case:
>
The patchset is already rebased on top :). Thanks for the tip.
Daniel
next prev parent reply other threads:[~2019-08-19 21:30 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-16 22:31 [PATCH v3 bpf-next 0/4] tracing/probe: Add PERF_EVENT_IOC_QUERY_PROBE Daniel Xu
2019-08-16 22:31 ` [PATCH v3 bpf-next 1/4] tracing/probe: Add PERF_EVENT_IOC_QUERY_PROBE ioctl Daniel Xu
2019-08-19 18:22 ` kbuild test robot
2019-08-20 1:26 ` Alexei Starovoitov
2019-08-20 2:34 ` Daniel Xu
2019-08-20 2:52 ` Alexei Starovoitov
2019-08-20 2:04 ` kbuild test robot
2019-08-20 14:45 ` Peter Zijlstra
2019-08-20 17:58 ` Daniel Xu
2019-08-21 11:08 ` Peter Zijlstra
2019-08-21 16:54 ` Yonghong Song
2019-08-21 18:31 ` Peter Zijlstra
2019-08-21 18:43 ` Yonghong Song
2019-08-21 20:04 ` Arnaldo Carvalho de Melo
2019-08-22 7:47 ` Peter Zijlstra
2019-08-22 7:54 ` Song Liu
2019-08-22 9:05 ` Peter Zijlstra
2019-08-22 21:08 ` Daniel Xu
2019-08-21 20:07 ` Arnaldo Carvalho de Melo
2019-08-21 22:10 ` Yonghong Song
2019-08-16 22:31 ` [PATCH v3 bpf-next 2/4] libbpf: Add helpers to extract perf fd from bpf_link Daniel Xu
2019-08-19 17:45 ` Andrii Nakryiko
2019-08-19 21:30 ` Daniel Xu [this message]
2019-08-16 22:31 ` [PATCH v3 bpf-next 3/4] tracing/probe: Sync perf_event.h to tools Daniel Xu
2019-08-16 22:31 ` [PATCH v3 bpf-next 4/4] tracing/probe: Add self test for PERF_EVENT_IOC_QUERY_PROBE Daniel Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bf85e622-afa9-4f9e-a41b-ba67be24a9e3@www.fastmail.com \
--to=dxu@dxuuu.xyz \
--cc=acme@kernel.org \
--cc=alexander.shishkin@linux.intel.com \
--cc=andrii.nakryiko@gmail.com \
--cc=andriin@fb.com \
--cc=ast@fb.com \
--cc=bpf@vger.kernel.org \
--cc=jolsa@redhat.com \
--cc=kernel-team@fb.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
--cc=songliubraving@fb.com \
--cc=yhs@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).