From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Henrik Grimler <henrik@grimler.se>,
robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org,
alim.akhtar@samsung.com, devicetree@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org,
phone-devel@vger.kernel.org,
~postmarketos/upstreaming@lists.sr.ht
Subject: Re: [PATCH 3/6] ARM: dts: exynos: add mmc aliases for Exynos4412
Date: Thu, 26 Jan 2023 13:24:19 +0100 [thread overview]
Message-ID: <bfbff227-7a97-a45e-40b7-ed73085f9be3@linaro.org> (raw)
In-Reply-To: <20230126103828.481441-4-henrik@grimler.se>
On 26/01/2023 11:38, Henrik Grimler wrote:
> So that mmcblk numbering is fixed for the eMMC and sdcard, no matter
> if a storage device is attached or not. Also remove old, no longer
> used, mshc alias while we are at it.
>
> Signed-off-by: Henrik Grimler <henrik@grimler.se>
> ---
> arch/arm/boot/dts/exynos4412.dtsi | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/arch/arm/boot/dts/exynos4412.dtsi b/arch/arm/boot/dts/exynos4412.dtsi
> index 7b4e2c442888..9625e9fe63b1 100644
> --- a/arch/arm/boot/dts/exynos4412.dtsi
> +++ b/arch/arm/boot/dts/exynos4412.dtsi
> @@ -28,7 +28,10 @@ aliases {
> pinctrl3 = &pinctrl_3;
> fimc-lite0 = &fimc_lite_0;
> fimc-lite1 = &fimc_lite_1;
> - mshc0 = &mshc_0;
> + mmc0 = &mshc_0; /* eMMC */
> + mmc1 = &sdhci_1;
> + mmc2 = &sdhci_2; /* uSD */
> + mmc3 = &sdhci_3;
This is definitely not correct. Several boards do not have mmc1 or mmc2
exposed at all.
Best regards,
Krzysztof
next prev parent reply other threads:[~2023-01-26 12:24 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-26 10:38 [PATCH 0/6] ARM: dts: add mmc aliases for Exynos devices Henrik Grimler
2023-01-26 10:38 ` [PATCH 1/6] ARM: dts: exynos: add mmc aliases for Exynos3250 Henrik Grimler
2023-01-26 10:38 ` [PATCH 2/6] ARM: dts: exynos: add mmc aliases for Exynos4210 Henrik Grimler
2023-01-26 10:38 ` [PATCH 3/6] ARM: dts: exynos: add mmc aliases for Exynos4412 Henrik Grimler
2023-01-26 12:24 ` Krzysztof Kozlowski [this message]
2023-01-26 10:38 ` [PATCH 4/6] ARM: dts: exynos: add mmc aliases for Exynos5250 Henrik Grimler
2023-01-26 10:38 ` [PATCH 5/6] ARM: dts: exynos: add mmc aliases for Exynos5410 Henrik Grimler
2023-01-26 10:38 ` [PATCH 6/6] ARM: dts: exynos: add mmc aliases for Exynos5420 Henrik Grimler
2023-01-26 12:22 ` [PATCH 0/6] ARM: dts: add mmc aliases for Exynos devices Krzysztof Kozlowski
2023-01-26 13:19 ` Henrik Grimler
2023-01-26 13:28 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bfbff227-7a97-a45e-40b7-ed73085f9be3@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=alim.akhtar@samsung.com \
--cc=devicetree@vger.kernel.org \
--cc=henrik@grimler.se \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=phone-devel@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=~postmarketos/upstreaming@lists.sr.ht \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).