From: Qian Cai <cai@lca.pw>
To: Michal Hocko <mhocko@kernel.org>
Cc: akpm@linux-foundation.org, Pavel.Tatashin@microsoft.com,
mingo@kernel.org, mgorman@techsingularity.net,
iamjoonsoo.kim@lge.com, tglx@linutronix.de, linux-mm@kvack.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3] mm/page_owner: fix for deferred struct page init
Date: Mon, 7 Jan 2019 20:53:08 -0500 [thread overview]
Message-ID: <bfcd017d-dcf4-b687-1aef-ab0810b12c73@lca.pw> (raw)
In-Reply-To: <20190107184309.GM31793@dhcp22.suse.cz>
On 1/7/19 1:43 PM, Michal Hocko wrote:
> On Fri 04-01-19 15:18:08, Qian Cai wrote:
> [...]
>> Though, I can't see any really benefit of this approach apart from "beautify"
>
> This is not about beautifying! This is about making the code long term
> maintainable. As you can see it is just too easy to break it with the
> current scheme. And that is bad especially when the code is broken
> because of an optimization.
>
Understood, but the code is now fixed. If there is something fundamentally
broken in the future, it may be a good time then to create a looks like
hundred-line cleanup patch for long-term maintenance at the same time to fix
real bugs.
next prev parent reply other threads:[~2019-01-08 1:53 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1545172285.18411.26.camel@lca.pw>
2018-12-19 1:57 ` [PATCH] mm: skip checking poison pattern for page_to_nid() Qian Cai
2018-12-19 10:20 ` Michal Hocko
2018-12-19 12:46 ` Qian Cai
2018-12-20 6:03 ` [PATCH] mm/page_owner: fix for deferred struct page init Qian Cai
2018-12-20 9:22 ` Michal Hocko
2018-12-20 18:50 ` [PATCH v2] " Qian Cai
2018-12-20 20:31 ` [PATCH v3] " Qian Cai
2018-12-20 21:00 ` William Kucharski
2018-12-20 21:04 ` Qian Cai
2019-01-03 11:51 ` Michal Hocko
2019-01-03 16:38 ` Qian Cai
2019-01-03 16:59 ` Michal Hocko
2019-01-03 17:38 ` Qian Cai
2019-01-03 19:07 ` Michal Hocko
2019-01-03 19:53 ` Qian Cai
2019-01-03 20:22 ` Michal Hocko
2019-01-03 22:22 ` Qian Cai
2019-01-04 13:09 ` Michal Hocko
2019-01-04 15:01 ` Qian Cai
2019-01-04 15:17 ` Michal Hocko
2019-01-04 15:25 ` Qian Cai
2019-01-04 15:32 ` Michal Hocko
2019-01-04 20:18 ` Qian Cai
2019-01-07 18:43 ` Michal Hocko
2019-01-08 1:53 ` Qian Cai [this message]
2019-01-08 8:20 ` Michal Hocko
2019-01-08 13:19 ` Qian Cai
2019-01-08 22:02 ` Andrew Morton
2019-01-08 22:13 ` Qian Cai
2019-01-08 22:40 ` Michal Hocko
2019-01-09 7:34 ` [PATCH v2] " Michal Hocko
2019-01-15 20:28 ` [PATCH] Revert "mm: use early_pfn_to_nid in page_ext_init" Qian Cai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bfcd017d-dcf4-b687-1aef-ab0810b12c73@lca.pw \
--to=cai@lca.pw \
--cc=Pavel.Tatashin@microsoft.com \
--cc=akpm@linux-foundation.org \
--cc=iamjoonsoo.kim@lge.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mgorman@techsingularity.net \
--cc=mhocko@kernel.org \
--cc=mingo@kernel.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).